GNU bug report logs - #27047
26.0.50; Scroll bar menu UI glitches [patch]

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stephen Berman <stephen.berman <at> gmx.net>
Subject: bug#27047: closed (Re: bug#27047: 26.0.50; Scroll bar menu UI
 glitches [patch])
Date: Wed, 24 May 2017 11:40:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#27047: 26.0.50; Scroll bar menu UI glitches [patch]

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 27047 <at> debbugs.gnu.org.

-- 
27047: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27047
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stephen Berman <stephen.berman <at> gmx.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 27047-done <at> debbugs.gnu.org
Subject: Re: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch]
Date: Wed, 24 May 2017 13:39:00 +0200

On Wed, 24 May 2017 08:15:11 +0200 martin rudalics <rudalics <at> gmx.at> wrote:

> Fine.  Please install.

Done, as commit 08f00c01d6 and closing the bug.  (The commit also
removed the two functions that were no longer used as a result of the
change, which the patch I posted had overlooked.)

Steve Berman

[Message part 3 (message/rfc822, inline)]

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; Scroll bar menu UI glitches [patch]
Date: Tue, 23 May 2017 23:08:03 +0200

[Message part 4 (text/plain, inline)]

The Options->Show/Hide->Scroll-bar menu functions correctly -- when you
press any of the five radio buttons, the result is what it should be --
but the UI is broken.  With -Q the vertical scroll bar is on the right,
there is no horizontal scroll bar and the menu shows the radio button
"None-horizontal" [sic] pressed.  If you press any of the other buttons
in that menu, the scroll bars change accordingly, but the menu continues
to show the same "None-horizontal" button pressed.  The attached patch
fixes this UI glitch.  In addition, I find the current scroll bar menu
somewhat incoherent and the patch offers an improvement (IMO): the radio
buttons are confined to the vertical scroll bar, and the two buttons for
the horizontal scroll bar are replaced by a single check box toggle, and
a separator is added to visually emphasize that two UI components are
involved.

While I was looking at the Show/Hide menu, I noticed that the spelling
there is not consistent with the convention of the Emacs manual, which
uses "scroll bar", "tool bar" and "menu bar" without hyphenation.  So
the patch changes the spelling of these in the menu and tooltips too.

In GNU Emacs 26.0.50 (build 19, x86_64-pc-linux-gnu, GTK+ Version 3.22.8)
 of 2017-05-22 built on rosalinde
Repository revision: bc78276e81956b3caa8a5eb7ef26959fa4c84b7b
Windowing system distributor 'The X.Org Foundation', version 11.0.11901000

[Message part 5 (text/plain, inline)]

2017-05-23  Stephen Berman  <Stephen.Berman <at> gmx.net>

	Fix and improve UI of scroll bar menu

        In addition, since the Emacs manual writes "scroll bar", "tool
	bar" and "menu bar", use this convention in the Show/Hide menues
	and tooltips as well.

	* lisp/menu-bar.el (menu-bar-showhide-scroll-bar-menu): Make
	pressing a radio button in the menu actually show that it was
	pressed.  Replace the two radio buttons to turn the horizontal
	scroll bar on and off with a single check-box toggle and add a
	separator between this and the vertical scroll bar radio
	buttons.
	(menu-bar-showhide-tool-bar-menu):
	(menu-bar-showhide-menu):
	(menu-bar-mode): Use conventional spelling.

[Message part 6 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.