GNU bug report logs - #27047
26.0.50; Scroll bar menu UI glitches [patch]

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27047 in the body.
You can then email your comments to 27047 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; Scroll bar menu UI glitches [patch]
Date: Tue, 23 May 2017 23:08:03 +0200

[Message part 1 (text/plain, inline)]

The Options->Show/Hide->Scroll-bar menu functions correctly -- when you
press any of the five radio buttons, the result is what it should be --
but the UI is broken.  With -Q the vertical scroll bar is on the right,
there is no horizontal scroll bar and the menu shows the radio button
"None-horizontal" [sic] pressed.  If you press any of the other buttons
in that menu, the scroll bars change accordingly, but the menu continues
to show the same "None-horizontal" button pressed.  The attached patch
fixes this UI glitch.  In addition, I find the current scroll bar menu
somewhat incoherent and the patch offers an improvement (IMO): the radio
buttons are confined to the vertical scroll bar, and the two buttons for
the horizontal scroll bar are replaced by a single check box toggle, and
a separator is added to visually emphasize that two UI components are
involved.

While I was looking at the Show/Hide menu, I noticed that the spelling
there is not consistent with the convention of the Emacs manual, which
uses "scroll bar", "tool bar" and "menu bar" without hyphenation.  So
the patch changes the spelling of these in the menu and tooltips too.

In GNU Emacs 26.0.50 (build 19, x86_64-pc-linux-gnu, GTK+ Version 3.22.8)
 of 2017-05-22 built on rosalinde
Repository revision: bc78276e81956b3caa8a5eb7ef26959fa4c84b7b
Windowing system distributor 'The X.Org Foundation', version 11.0.11901000

[Message part 2 (text/plain, inline)]

2017-05-23  Stephen Berman  <Stephen.Berman <at> gmx.net>

	Fix and improve UI of scroll bar menu

        In addition, since the Emacs manual writes "scroll bar", "tool
	bar" and "menu bar", use this convention in the Show/Hide menues
	and tooltips as well.

	* lisp/menu-bar.el (menu-bar-showhide-scroll-bar-menu): Make
	pressing a radio button in the menu actually show that it was
	pressed.  Replace the two radio buttons to turn the horizontal
	scroll bar on and off with a single check-box toggle and add a
	separator between this and the vertical scroll bar radio
	buttons.
	(menu-bar-showhide-tool-bar-menu):
	(menu-bar-showhide-menu):
	(menu-bar-mode): Use conventional spelling.

[Message part 3 (text/x-patch, attachment)]

Message #8 received at 27047 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stephen Berman <stephen.berman <at> gmx.net>, 27047 <at> debbugs.gnu.org
Subject: Re: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch]
Date: Wed, 24 May 2017 08:15:11 +0200

> The Options->Show/Hide->Scroll-bar menu functions correctly -- when you
> press any of the five radio buttons, the result is what it should be --
> but the UI is broken.  With -Q the vertical scroll bar is on the right,
> there is no horizontal scroll bar and the menu shows the radio button
> "None-horizontal" [sic] pressed.  If you press any of the other buttons
> in that menu, the scroll bars change accordingly, but the menu continues
> to show the same "None-horizontal" button pressed.  The attached patch
> fixes this UI glitch.

Thanks.

> In addition, I find the current scroll bar menu
> somewhat incoherent and the patch offers an improvement (IMO): the radio
> buttons are confined to the vertical scroll bar, and the two buttons for
> the horizontal scroll bar are replaced by a single check box toggle, and
> a separator is added to visually emphasize that two UI components are
> involved.

I once planned to implement horizontal scroll bars on the top of a frame
too but lack of knowledge of the internals of the display engine impeded
me to do so properly (I failed to detect all uses of "0" indicating the
start of the text area, so display usually got mangled).  Also, I
doubted that anyone would ever need scoll bars on top, so I eventually
gave up on that idea.  The "None-horizontal" entry was the last remnant
of that failed attempt.

> While I was looking at the Show/Hide menu, I noticed that the spelling
> there is not consistent with the convention of the Emacs manual, which
> uses "scroll bar", "tool bar" and "menu bar" without hyphenation.  So
> the patch changes the spelling of these in the menu and tooltips too.

Fine.  Please install.

martin

Message #13 received at 27047-done <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 27047-done <at> debbugs.gnu.org
Subject: Re: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch]
Date: Wed, 24 May 2017 13:39:00 +0200

On Wed, 24 May 2017 08:15:11 +0200 martin rudalics <rudalics <at> gmx.at> wrote:

> Fine.  Please install.

Done, as commit 08f00c01d6 and closing the bug.  (The commit also
removed the two functions that were no longer used as a result of the
change, which the patch I posted had overlooked.)

Steve Berman

Message #16 received at 27047-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 27047-done <at> debbugs.gnu.org
Subject: Re: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch]
Date: Wed, 24 May 2017 14:27:00 +0200

> Done, as commit 08f00c01d6 and closing the bug.  (The commit also
> removed the two functions that were no longer used as a result of the
> change, which the patch I posted had overlooked.)

Thanks again, martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.