GNU bug report logs - #26984
Add loksh (ported OpenBSD pdksh)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26984 in the body.
You can then email your comments to 26984 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: guix-patches <at> gnu.org
Subject: Add loksh (ported OpenBSD pdksh)
Date: Thu, 18 May 2017 18:20:47 +0000

[Message part 1 (text/plain, inline)]

The first patch adds loksh, a port of OpenBSD pdksh to Linux userland.
Intended for musl build, but we don't have that now.
It seems to work, I use it.
-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

[0001-gnu-Add-loksh.patch (text/plain, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: guix-patches <at> gnu.org
Subject: Re: bug#26984: Add loksh (ported OpenBSD pdksh)
Date: Thu, 18 May 2017 20:22:02 +0000

ng0 transcribed 2.8K bytes:
> The first patch adds loksh, a port of OpenBSD pdksh to Linux userland.
> Intended for musl build, but we don't have that now.
> It seems to work, I use it.

By the way, this can not be used for the test suite in graphviz.
There are many ksh implementations, and this is not the one
the tests accept. Or at least its ksh93 checks fail ;)

> -- 
> https://pragmatique.xyz
> PGP: https://people.pragmatique.xyz/ng0/

> From b72f88bfa8c3f26fcac4a0c0e9ef07a76e727fcf Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> no-reply.pragmatique.xyz>
> Date: Thu, 18 May 2017 16:55:12 +0000
> Subject: [PATCH] gnu: Add loksh.
> 
> * gnu/packages/shells.scm (loksh): New variable.
> ---
>  gnu/packages/shells.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
> index 4e684e8c8..5035c935a 100644
> --- a/gnu/packages/shells.scm
> +++ b/gnu/packages/shells.scm
> @@ -32,6 +32,7 @@
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages documentation)
>    #:use-module (gnu packages groff)
> +  #:use-module (gnu packages libbsd)
>    #:use-module (gnu packages libedit)
>    #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages pcre)
> @@ -457,3 +458,39 @@ components: a process notation for running programs and setting up pipelines
>  and redirections, and a complete syscall library for low-level access to the
>  operating system.")
>        (license bsd-3))))
> +
> +(define-public loksh
> +  (package
> +    (name "loksh")
> +    (version "6.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/dimkr/loksh/archive/"
> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1wg7ds56yr8fgg1m149bi53bvrwccwiashmwknggza1sqgj9m2lq"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("libbsd" ,libbsd)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (arguments
> +     `(#:tests? #f ;No tests included
> +       #:make-flags (list "CC=gcc" "HAVE_LIBBSD=1"
> +                          (string-append "DESTDIR="
> +                                         (assoc-ref %outputs "out"))
> +                          "PREFIX=")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)))) ;No configure script
> +    (home-page "https://github.com/dimkr/loksh")
> +    (synopsis "Port of OpenBSD pdksh to Linux")
> +    (description
> +     "loksh is a Linux port of OpenBSD's ksh (pdksh).
> +It is a small, interactive shell targeted at resource-constrained systems.")
> +    ;; The file 'LEGAL' says it is the public domain, and the 2
> +    ;; exceptions which are listed are not included in this port.
> +    (license public-domain)))
> -- 
> 2.13.0
> 


-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

Message #13 received at 26984-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: ng0 <ng0 <at> pragmatique.xyz>, 26984-done <at> debbugs.gnu.org
Subject: Re: bug#26984: Add loksh (ported OpenBSD pdksh)
Date: Sat, 20 May 2017 02:42:49 +0200

[Message part 1 (text/plain, inline)]

ng0 <ng0 <at> pragmatique.xyz> writes:

> Subject: [PATCH] gnu: Add loksh.
>
> * gnu/packages/shells.scm (loksh): New variable.

Thanks for this patch! I've used this shell a lot on OpenBSD. One
thing it does better than bash is that ^W stops at "/" and other
boundaries, not just spaces!

I've applied it with a slight adjustment to description:

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 5035c935a..47d3a4614 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -487,10 +487,10 @@ operating system.")
        (modify-phases %standard-phases
          (delete 'configure)))) ;No configure script
     (home-page "https://github.com/dimkr/loksh")
-    (synopsis "Port of OpenBSD pdksh to Linux")
+    (synopsis "Korn Shell from OpenBSD")
     (description
-     "loksh is a Linux port of OpenBSD's ksh (pdksh).
-It is a small, interactive shell targeted at resource-constrained systems.")
+     "loksh is a Linux port of OpenBSD's @command{ksh}.  It is a small,
+interactive POSIX shell targeted at resource-constrained systems.")
     ;; The file 'LEGAL' says it is the public domain, and the 2
     ;; exceptions which are listed are not included in this port.
     (license public-domain)))

> By the way, this can not be used for the test suite in graphviz.
> There are many ksh implementations, and this is not the one
> the tests accept. Or at least its ksh93 checks fail ;)

Maybe they need "mksh"? Another popular Korn Shell :)

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 26984 <at> debbugs.gnu.org (full text, mbox):

From: user <at> abyayala.i-did-not-set--mail-host-address--so-tickle-me
To: mbakke <at> fastmail.com
Cc: 26984 <at> debbugs.gnu.org, ng0 <ng0 <at> pragmatique.xyz>
Subject: Re: bug#26984: closed (Re: bug#26984: Add loksh (ported OpenBSD
 pdksh))
Date: Sat, 20 May 2017 09:19:32 +0000

help-debbugs <at> gnu.org (GNU bug Tracking System) writes:

> ng0 <ng0 <at> pragmatique.xyz> writes:
>
>> Subject: [PATCH] gnu: Add loksh.
>>
>> * gnu/packages/shells.scm (loksh): New variable.
>
> Thanks for this patch! I've used this shell a lot on OpenBSD. One
> thing it does better than bash is that ^W stops at "/" and other
> boundaries, not just spaces!
>
> I've applied it with a slight adjustment to description:

>> By the way, this can not be used for the test suite in graphviz.
>> There are many ksh implementations, and this is not the one
>> the tests accept. Or at least its ksh93 checks fail ;)
>
> Maybe they need "mksh"? Another popular Korn Shell :)

Maybe. It must be a ksh93 implementation, most implementations
are ksh88. I don't know enough about ksh to know if a shell
is compatible. I executed ksh and ran the lines which test for
ksh88 or ksh93. It failed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.