GNU bug report logs - #26953
[PATCH] 26.0.50; svg-line uses incorrect parameters

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26953: closed ([PATCH] 26.0.50; svg-line uses incorrect
 parameters)
Date: Sun, 21 May 2017 00:16:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 20 May 2017 20:15:17 -0400
with message-id <hhr2zjm5ey.fsf <at> fencepost.gnu.org>
and subject line Re: bug#26953: [PATCH] 26.0.50; svg-line uses incorrect parameters
has caused the debbugs.gnu.org bug report #26953,
regarding [PATCH] 26.0.50; svg-line uses incorrect parameters
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26953: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26953
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ari Roponen <ari.roponen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 26.0.50; svg-line uses incorrect parameters
Date: Tue, 16 May 2017 18:02:35 +0300

This code should draw a horizontal line:

  (require 'svg)
  (let ((svg (svg-create 50 50 :stroke-color "black")))
    (svg-line svg 0 25 50 25)
    (svg-insert-image svg))

but it draws a diagonal one instead. The following patch fixes the
problem.

* lisp/svg.el (svg-line): Use correct parameters.

diff --git a/lisp/svg.el b/lisp/svg.el
index cb924f8163..fc1a6d60e1 100644
--- a/lisp/svg.el
+++ b/lisp/svg.el
@@ -107,8 +107,8 @@ svg-line
    svg
    (dom-node 'line
 	     `((x1 . ,x1)
-	       (x2 . ,y1)
-	       (y1 . ,x2)
+	       (x2 . ,x2)
+	       (y1 . ,y1)
 	       (y2 . ,y2)
 	       ,@(svg--arguments svg args)))))
 

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 26953-done <at> debbugs.gnu.org
Subject: Re: bug#26953: [PATCH] 26.0.50; svg-line uses incorrect parameters
Date: Sat, 20 May 2017 20:15:17 -0400

Version: 26.1

Thanks; applied as 547f78c813c.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.