GNU bug report logs - #26953
[PATCH] 26.0.50; svg-line uses incorrect parameters

Previous Next

Package: emacs;

Reported by: Ari Roponen <ari.roponen <at> gmail.com>

Date: Tue, 16 May 2017 15:03:01 UTC

Severity: normal

Tags: patch

Fixed in version 26.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26953 in the body.
You can then email your comments to 26953 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#26953; Package emacs. (Tue, 16 May 2017 15:03:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Ari Roponen <ari.roponen <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 16 May 2017 15:03:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ari Roponen <ari.roponen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 26.0.50; svg-line uses incorrect parameters
Date: Tue, 16 May 2017 18:02:35 +0300

This code should draw a horizontal line:

  (require 'svg)
  (let ((svg (svg-create 50 50 :stroke-color "black")))
    (svg-line svg 0 25 50 25)
    (svg-insert-image svg))

but it draws a diagonal one instead. The following patch fixes the
problem.

* lisp/svg.el (svg-line): Use correct parameters.

diff --git a/lisp/svg.el b/lisp/svg.el
index cb924f8163..fc1a6d60e1 100644
--- a/lisp/svg.el
+++ b/lisp/svg.el
@@ -107,8 +107,8 @@ svg-line
    svg
    (dom-node 'line
 	     `((x1 . ,x1)
-	       (x2 . ,y1)
-	       (y1 . ,x2)
+	       (x2 . ,x2)
+	       (y1 . ,y1)
 	       (y2 . ,y2)
 	       ,@(svg--arguments svg args)))))
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Sun, 21 May 2017 00:16:02 GMT) Full text and rfc822 format available.
Notification sent to Ari Roponen <ari.roponen <at> gmail.com>:
bug acknowledged by developer. (Sun, 21 May 2017 00:16:02 GMT) Full text and rfc822 format available.

Message #10 received at 26953-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 26953-done <at> debbugs.gnu.org
Subject: Re: bug#26953: [PATCH] 26.0.50; svg-line uses incorrect parameters
Date: Sat, 20 May 2017 20:15:17 -0400

Version: 26.1

Thanks; applied as 547f78c813c.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 18 Jun 2017 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 5 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.