GNU bug report logs - #26702
[PATCH 1/2] gnu: Add font-cns11643

Previous Next

Package: guix-patches;

Reported by: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>

Date: Fri, 28 Apr 2017 19:35:02 UTC

Severity: normal

Tags: patch

Done: Alex Kost <alezost <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 26702 <at> debbugs.gnu.org
Subject: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Fri, 05 May 2017 09:55:58 +0200

Alex Kost <alezost <at> gmail.com> skribis:

> Marius Bakke (2017-04-30 17:10 +0200) wrote:
>
>>> +    (outputs '("out" "tw-kai" "tw-sung"))
>>> +    (build-system trivial-build-system)
>>> +    (native-inputs
>>> +     `(("unzip" ,unzip)))
>>> +    (arguments
>>> +     `(#:modules ((guix build utils))
>>> +       #:builder
>>> +       (begin
>>> +         (use-modules (guix build utils))
>>> +         (let* ((font-dir "/share/fonts/truetype/cns11643")
>>> +                (out (string-append %output font-dir))
>>
>> I've changes this to use (assoc-ref outputs "out") instead of the
>> magical %output.
>
> I would leave the magical %output :-)  Besides (assoc-ref outputs "out")
> wouldn't work here; you probably meant (assoc-ref %outputs "out").
>
> Regarding “%output” vs “(assoc-ref %outputs "out")”: I always prefer the
> former (Ludovic prefers the latter).  Why does “%output” exist anyway,
> if not for using it?

Both are meant to disappear with the advent of gexps anyway.  :-)

Ludo’.
This bug report was last modified 8 years and 100 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.