GNU bug report logs - #26702
[PATCH 1/2] gnu: Add font-cns11643

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26702 in the body.
You can then email your comments to 26702 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: Add font-cns11643
Date: Sat, 29 Apr 2017 04:53:13 +1000

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-font-cns11643.patch (text/x-patch, attachment)]

Message #8 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>,
 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Sun, 30 Apr 2017 17:10:02 +0200

[Message part 1 (text/plain, inline)]

Hi Brendan, thanks for this!

Brendan Tildesley <brendan.tildesley <at> openmailbox.org> writes:

> * gnu/packages/fonts.scm (font-cns11643): New variable.

[...]
  
> +(define-public font-cns11643
> +  (package
> +    (name "font-cns11643")
> +    (version "98.1.20170405")
> +    (source (origin
> +              (method url-fetch)
> +              (uri "http://www.cns11643.gov.tw/AIDB/Open_Data.zip")
> +              (sha256
> +               (base32
> +                "1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455"))))

I'm getting a different hash when downloading this:

@ build-failed /gnu/store/b4s6pjp7pvwn5028zxm7dn7hxb7akhxn-Open_Data.zip.drv - 1 output path `/gnu/store/kv2291fl8p8r3ic15pp68751qncrv830-Open_Data.zip' should have sha256 hash `1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455', instead has `02kb3bwjrra0k2hlr2p8xswd2y0xs6j8d9vm6yrby734h02a40qf'

Maybe I'm getting a newer version? If this is updated in-place upstream
very frequently, it would be good to have a way to access older
downloads. Any ideas?

Minor nit-picks follow, but I've corrected this in my local branch:

> +    (outputs '("out" "tw-kai" "tw-sung"))
> +    (build-system trivial-build-system)
> +    (native-inputs
> +     `(("unzip" ,unzip)))
> +    (arguments
> +     `(#:modules ((guix build utils))
> +       #:builder
> +       (begin
> +         (use-modules (guix build utils))
> +         (let* ((font-dir "/share/fonts/truetype/cns11643")
> +                (out (string-append %output font-dir))

I've changes this to use (assoc-ref outputs "out") instead of the
magical %output.

> +                (unzip (string-append
> +                        (assoc-ref %build-inputs "unzip") "/bin/unzip"))
> +                (tw-kai (string-append
> +                         (assoc-ref %outputs "tw-kai") font-dir))
> +                (tw-sung (string-append
> +                          (assoc-ref %outputs "tw-sung") font-dir)))
> +           (system* unzip (assoc-ref %build-inputs "source"))
> +           (chdir "Open_Data/Fonts/")
> +           (install-file "TW-Kai-98_1.ttf" tw-kai)
> +           (install-file "TW-Sung-98_1.ttf" tw-sung)
> +           (install-file "TW-Kai-98_1.ttf" out)
> +           (install-file "TW-Kai-Ext-B-98_1.ttf" out)
> +           (install-file "TW-Kai-Plus-98_1.ttf" out)
> +           (install-file "TW-Sung-98_1.ttf" out)
> +           (install-file "TW-Sung-Ext-B-98_1.ttf" out)
> +           (install-file "TW-Sung-Plus-98_1.ttf" out)))))

And added a #t at the end here, since the return value of "install-file"
is unspecified.

> +    (home-page "http://www.cns11643.gov.tw/AIDB/welcome.do")
> +    (synopsis "CJK TrueType fonts, TW-Kai and TW-Sung")
> +    (description
> +     "@code{CNS 11643} character set (Chinese National Standard, or Chinese
> +Standard Interchange Code) is the standard character set of the Republic of
> +China (Taiwan) for Chinese Characters and other Unicode symbols.  Contained
> +are six TrueType fonts based on two script styles, Regular Script (Kai), and
> +Sung/Ming Script, each with three variants:
> +
> +@itemize
> +@item @code{CNS 11643} (@code{TW-Kai} and @code{TW-Sung}): Tens of thousands
> +of CJK characters from frequency tables published by the Taiwanese
> +Ministry of Education.  ISO 10646 and Unicode compatible code encoding.
> +@item @code{Big-5 Plus}: Several thousand frequently used CJK characters
> +encoded in the user defined area of the Big-5 code.
> +@item @code{Big-5 Extended}: A Big-5 character set based on the
> +@code{Big-5 Plus} and @code{CNS 11643} character sets.
> +@end itemize\n")
> +    (license (license:non-copyleft
> +              "http://data.gov.tw/license"))))

...and added a comment about this license being compatible with CC-BY
4.0 here.

Thanks a lot for packaging these!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>,
 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Sun, 30 Apr 2017 14:07:34 -0400

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Hi Brendan, thanks for this!
>
> Brendan Tildesley <brendan.tildesley <at> openmailbox.org> writes:
>
>> * gnu/packages/fonts.scm (font-cns11643): New variable.
>
> [...]
>   
>> +(define-public font-cns11643
>> +  (package
>> +    (name "font-cns11643")
>> +    (version "98.1.20170405")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri "http://www.cns11643.gov.tw/AIDB/Open_Data.zip")
>> +              (sha256
>> +               (base32
>> +                "1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455"))))
>
> I'm getting a different hash when downloading this:
>
> @ build-failed
> /gnu/store/b4s6pjp7pvwn5028zxm7dn7hxb7akhxn-Open_Data.zip.drv - 1
> output path
> `/gnu/store/kv2291fl8p8r3ic15pp68751qncrv830-Open_Data.zip' should
> have sha256 hash
> `1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455', instead has
> `02kb3bwjrra0k2hlr2p8xswd2y0xs6j8d9vm6yrby734h02a40qf'
>

I just wanted to say that I get the same incorrect hash when downloading
the source.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
To: 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Tue, 2 May 2017 00:43:41 +1000

[Message part 1 (text/plain, inline)]

Marius Bakke 於 2017-05-01 01:10 寫道:
> Hi Brendan, thanks for this!
>
> Brendan Tildesley <brendan.tildesley <at> openmailbox.org> writes:
>
>> * gnu/packages/fonts.scm (font-cns11643): New variable.
> [...]
>   
>> +(define-public font-cns11643
>> +  (package
>> +    (name "font-cns11643")
>> +    (version "98.1.20170405")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri "http://www.cns11643.gov.tw/AIDB/Open_Data.zip")
>> +              (sha256
>> +               (base32
>> +                "1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455"))))
> I'm getting a different hash when downloading this:
>
> @ build-failed /gnu/store/b4s6pjp7pvwn5028zxm7dn7hxb7akhxn-Open_Data.zip.drv - 1 output path `/gnu/store/kv2291fl8p8r3ic15pp68751qncrv830-Open_Data.zip' should have sha256 hash `1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455', instead has `02kb3bwjrra0k2hlr2p8xswd2y0xs6j8d9vm6yrby734h02a40qf'
>
> Maybe I'm getting a newer version? If this is updated in-place upstream
> very frequently, it would be good to have a way to access older
> downloads. Any ideas?
>
> Minor nit-picks follow, but I've corrected this in my local branch:
I have confirmed that the new hash represents an update to the font. I
have thought about hosting this file, but I'm not sure where I can host
~300MiB. Also, It means I have to bother updating that file frequently.
On the other hand if we use upstream, a failing hash typically means
there is an update. There is unlikely any other Guix user interested in
these fonts at the present. So I'm not sure what to do.
>> +    (outputs '("out" "tw-kai" "tw-sung"))
>> +    (build-system trivial-build-system)
>> +    (native-inputs
>> +     `(("unzip" ,unzip)))
>> +    (arguments
>> +     `(#:modules ((guix build utils))
>> +       #:builder
>> +       (begin
>> +         (use-modules (guix build utils))
>> +         (let* ((font-dir "/share/fonts/truetype/cns11643")
>> +                (out (string-append %output font-dir))
> I've changes this to use (assoc-ref outputs "out") instead of the
> magical %output.
Ok, I don't understand much about those. Are the uses of %outputs (with
the 's') below also problematic?
>> +                (unzip (string-append
>> +                        (assoc-ref %build-inputs "unzip") "/bin/unzip"))
>> +                (tw-kai (string-append
>> +                         (assoc-ref %outputs "tw-kai") font-dir))
>> +                (tw-sung (string-append
>> +                          (assoc-ref %outputs "tw-sung") font-dir)))
>> +           (system* unzip (assoc-ref %build-inputs "source"))
>> +           (chdir "Open_Data/Fonts/")
>> +           (install-file "TW-Kai-98_1.ttf" tw-kai)
>> +           (install-file "TW-Sung-98_1.ttf" tw-sung)
>> +           (install-file "TW-Kai-98_1.ttf" out)
>> +           (install-file "TW-Kai-Ext-B-98_1.ttf" out)
>> +           (install-file "TW-Kai-Plus-98_1.ttf" out)
>> +           (install-file "TW-Sung-98_1.ttf" out)
>> +           (install-file "TW-Sung-Ext-B-98_1.ttf" out)
>> +           (install-file "TW-Sung-Plus-98_1.ttf" out)))))
> And added a #t at the end here, since the return value of "install-file"
> is unspecified.
>
>> [...]
>> +    (license (license:non-copyleft
>> +              "http://data.gov.tw/license"))))
> ...and added a comment about this license being compatible with CC-BY
> 4.0 here.
>
> Thanks a lot for packaging these!

I have attached an updated patch file, and will follow up a with [PATCH
2/2] update

[0001-gnu-Add-font-cns11643.patch (text/x-patch, attachment)]

Message #17 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>,
 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Tue, 02 May 2017 00:34:23 +0200

[Message part 1 (text/plain, inline)]

Brendan Tildesley <brendan.tildesley <at> openmailbox.org> writes:

> Marius Bakke 於 2017-05-01 01:10 寫道:
>> Hi Brendan, thanks for this!
>>
>> Brendan Tildesley <brendan.tildesley <at> openmailbox.org> writes:
>>
>>> * gnu/packages/fonts.scm (font-cns11643): New variable.
>> [...]
>>   
>>> +(define-public font-cns11643
>>> +  (package
>>> +    (name "font-cns11643")
>>> +    (version "98.1.20170405")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri "http://www.cns11643.gov.tw/AIDB/Open_Data.zip")
>>> +              (sha256
>>> +               (base32
>>> +                "1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455"))))
>> I'm getting a different hash when downloading this:
>>
>> @ build-failed /gnu/store/b4s6pjp7pvwn5028zxm7dn7hxb7akhxn-Open_Data.zip.drv - 1 output path `/gnu/store/kv2291fl8p8r3ic15pp68751qncrv830-Open_Data.zip' should have sha256 hash `1kyfrwamr8zpdp4qw3z9j3cimhsvr4xd05dmxmfphiknlbr6d455', instead has `02kb3bwjrra0k2hlr2p8xswd2y0xs6j8d9vm6yrby734h02a40qf'
>>
>> Maybe I'm getting a newer version? If this is updated in-place upstream
>> very frequently, it would be good to have a way to access older
>> downloads. Any ideas?
>>
>> Minor nit-picks follow, but I've corrected this in my local branch:
> I have confirmed that the new hash represents an update to the font. I
> have thought about hosting this file, but I'm not sure where I can host
> ~300MiB. Also, It means I have to bother updating that file frequently.
> On the other hand if we use upstream, a failing hash typically means
> there is an update. There is unlikely any other Guix user interested in
> these fonts at the present. So I'm not sure what to do.

Thanks for checking! Where did you take the version number and datestamp
from? Are you willing to help maintain this package?

The current situation is suboptimal, but I think it's fine if we can
ping you about any problems. What do you think?

I've committed this for now, let's see how long it holds. I may be able
to provide a fallback mirror in a not-too-distant future, but immediate
suggestions welcome.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>,
 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Thu, 04 May 2017 23:03:42 +0300

Marius Bakke (2017-04-30 17:10 +0200) wrote:

>> +    (outputs '("out" "tw-kai" "tw-sung"))
>> +    (build-system trivial-build-system)
>> +    (native-inputs
>> +     `(("unzip" ,unzip)))
>> +    (arguments
>> +     `(#:modules ((guix build utils))
>> +       #:builder
>> +       (begin
>> +         (use-modules (guix build utils))
>> +         (let* ((font-dir "/share/fonts/truetype/cns11643")
>> +                (out (string-append %output font-dir))
>
> I've changes this to use (assoc-ref outputs "out") instead of the
> magical %output.

I would leave the magical %output :-)  Besides (assoc-ref outputs "out")
wouldn't work here; you probably meant (assoc-ref %outputs "out").

Regarding “%output” vs “(assoc-ref %outputs "out")”: I always prefer the
former (Ludovic prefers the latter).  Why does “%output” exist anyway,
if not for using it?

-- 
Alex

Message #25 received at 26702-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
Cc: 26702-done <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Thu, 04 May 2017 23:12:00 +0300

Brendan Tildesley (2017-05-02 00:43 +1000) wrote:

> Marius Bakke 於 2017-05-01 01:10 寫道:
[...]
>>> +    (outputs '("out" "tw-kai" "tw-sung"))
>>> +    (build-system trivial-build-system)
>>> +    (native-inputs
>>> +     `(("unzip" ,unzip)))
>>> +    (arguments
>>> +     `(#:modules ((guix build utils))
>>> +       #:builder
>>> +       (begin
>>> +         (use-modules (guix build utils))
>>> +         (let* ((font-dir "/share/fonts/truetype/cns11643")
>>> +                (out (string-append %output font-dir))
>> I've changes this to use (assoc-ref outputs "out") instead of the
>> magical %output.
> Ok, I don't understand much about those. Are the uses of %outputs (with
> the 's') below also problematic?

No they are OK, moreover this is the only way to access the outputs.

-- 
Alex

Message #28 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Thu, 04 May 2017 23:15:53 +0300

Marius Bakke (2017-05-02 00:34 +0200) wrote:

> Brendan Tildesley <brendan.tildesley <at> openmailbox.org> writes:
[...]
>> I have confirmed that the new hash represents an update to the font. I
>> have thought about hosting this file, but I'm not sure where I can host
>> ~300MiB. Also, It means I have to bother updating that file frequently.
>> On the other hand if we use upstream, a failing hash typically means
>> there is an update. There is unlikely any other Guix user interested in
>> these fonts at the present. So I'm not sure what to do.
>
> Thanks for checking! Where did you take the version number and datestamp
> from? Are you willing to help maintain this package?
>
> The current situation is suboptimal, but I think it's fine if we can
> ping you about any problems. What do you think?
>
> I've committed this for now, let's see how long it holds. I may be able
> to provide a fallback mirror in a not-too-distant future, but immediate
> suggestions welcome.

Hi Marius, I've just found that you pushed this patch but didn't close
this "bug thread" (or whatever it should be called).  Was it intentional?

-- 
Alex

Message #31 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Fri, 05 May 2017 09:55:58 +0200

Alex Kost <alezost <at> gmail.com> skribis:

> Marius Bakke (2017-04-30 17:10 +0200) wrote:
>
>>> +    (outputs '("out" "tw-kai" "tw-sung"))
>>> +    (build-system trivial-build-system)
>>> +    (native-inputs
>>> +     `(("unzip" ,unzip)))
>>> +    (arguments
>>> +     `(#:modules ((guix build utils))
>>> +       #:builder
>>> +       (begin
>>> +         (use-modules (guix build utils))
>>> +         (let* ((font-dir "/share/fonts/truetype/cns11643")
>>> +                (out (string-append %output font-dir))
>>
>> I've changes this to use (assoc-ref outputs "out") instead of the
>> magical %output.
>
> I would leave the magical %output :-)  Besides (assoc-ref outputs "out")
> wouldn't work here; you probably meant (assoc-ref %outputs "out").
>
> Regarding “%output” vs “(assoc-ref %outputs "out")”: I always prefer the
> former (Ludovic prefers the latter).  Why does “%output” exist anyway,
> if not for using it?

Both are meant to disappear with the advent of gexps anyway.  :-)

Ludo’.

Message #34 received at 26702-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alex Kost <alezost <at> gmail.com>
Cc: 26702-done <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Fri, 05 May 2017 16:51:19 +0200

[Message part 1 (text/plain, inline)]

Alex Kost <alezost <at> gmail.com> writes:

> Marius Bakke (2017-05-02 00:34 +0200) wrote:
>
>> Brendan Tildesley <brendan.tildesley <at> openmailbox.org> writes:
> [...]
>>> I have confirmed that the new hash represents an update to the font. I
>>> have thought about hosting this file, but I'm not sure where I can host
>>> ~300MiB. Also, It means I have to bother updating that file frequently.
>>> On the other hand if we use upstream, a failing hash typically means
>>> there is an update. There is unlikely any other Guix user interested in
>>> these fonts at the present. So I'm not sure what to do.
>>
>> Thanks for checking! Where did you take the version number and datestamp
>> from? Are you willing to help maintain this package?
>>
>> The current situation is suboptimal, but I think it's fine if we can
>> ping you about any problems. What do you think?
>>
>> I've committed this for now, let's see how long it holds. I may be able
>> to provide a fallback mirror in a not-too-distant future, but immediate
>> suggestions welcome.
>
> Hi Marius, I've just found that you pushed this patch but didn't close
> this "bug thread" (or whatever it should be called).  Was it intentional?

Oops, didn't realize the two patches were in separate bugs. Closing this
one too.

Still waiting for feedback about extracting version information, though.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.