GNU bug report logs - #26702
[PATCH 1/2] gnu: Add font-cns11643

Previous Next

Full log

Message #20 received at 26702 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>,
 26702 <at> debbugs.gnu.org
Subject: Re: bug#26702: [PATCH 1/2] gnu: Add font-cns11643
Date: Thu, 04 May 2017 23:03:42 +0300

Marius Bakke (2017-04-30 17:10 +0200) wrote:

>> +    (outputs '("out" "tw-kai" "tw-sung"))
>> +    (build-system trivial-build-system)
>> +    (native-inputs
>> +     `(("unzip" ,unzip)))
>> +    (arguments
>> +     `(#:modules ((guix build utils))
>> +       #:builder
>> +       (begin
>> +         (use-modules (guix build utils))
>> +         (let* ((font-dir "/share/fonts/truetype/cns11643")
>> +                (out (string-append %output font-dir))
>
> I've changes this to use (assoc-ref outputs "out") instead of the
> magical %output.

I would leave the magical %output :-)  Besides (assoc-ref outputs "out")
wouldn't work here; you probably meant (assoc-ref %outputs "out").

Regarding “%output” vs “(assoc-ref %outputs "out")”: I always prefer the
former (Ludovic prefers the latter).  Why does “%output” exist anyway,
if not for using it?

-- 
Alex

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.