GNU bug report logs - #26669
[PATCH 1/7] gnu: Add cdrtools.

Previous Next

Package: guix-patches;

Reported by: Thomas Danckaert <post <at> thomasdanckaert.be>

Date: Wed, 26 Apr 2017 16:07:01 UTC

Severity: normal

Tags: patch

Done: Thomas Danckaert <post <at> thomasdanckaert.be>

Bug is archived. No further changes may be made.

Full log

Message #47 received at 26669 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Thomas Danckaert <thomas.danckaert <at> gmail.com>
Cc: Thomas Danckaert <post <at> thomasdanckaert.be>, 26669 <at> debbugs.gnu.org
Subject: Re: bug#26669: [PATCH 7/7] gnu: Add dvdstyler.
Date: Wed, 03 May 2017 15:04:47 +0200

Thomas Danckaert <thomas.danckaert <at> gmail.com> skribis:

> From: Thomas Danckaert <post <at> thomasdanckaert.be>
>
> * gnu/packages/cdrom.scm (dvdstyler): New variable.

[...]

> +    (arguments
> +     `(#:configure-flags (list (string-append "XMLTO="
> +                                              (assoc-ref %build-inputs "xmlto")
> +                                              "/bin/xmlto"
> +                                              " --searchpath "
> +                                              (assoc-ref %build-inputs "docbook-xsl")
> +                                              "/xml/xsl/docbook-xsl-1.79.1/htmlhelp:"
> +                                              (assoc-ref %build-inputs "docbook-xml")
> +                                              "/xml/dtd/docbook"))

I'd expect that adding libxml2 as an input would lead to the appropriate
definition of XML_CATALOG_FILES, and thus remove the need for these
#:configure-flags.  Could you try that?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'wrap-program
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (wrap-program (string-append (assoc-ref outputs "out") "/bin/dvdstyler")
> +               `("PATH" ":" prefix
> +                 (,(string-join
> +                    (map (lambda (in) (string-append (assoc-ref inputs in) "/bin"))
> +                                 '("cdrtools" "dvdauthor" "dvd+rw-tools" "ffmpeg"))
                            <-------'
Identation.  :-)

> +                    ":")))))))

Please return #t at the end of the phase.

> +    (license gpl2)))

GPLv2-only, right?

Otherwise LGTM, thanks!

Ludo’.
This bug report was last modified 8 years and 99 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.