GNU bug report logs - #26670
[PATCH] gnu: Add mdbtools.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26670 in the body.
You can then email your comments to 26670 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: Add mdbtools.
Date: Wed, 26 Apr 2017 22:11:49 +0530

* gnu/packages/databases.scm (mdbtools): New variable.
---
 gnu/packages/databases.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index e32bcfa66..bed8719d9 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2016 Andy Patterson <ajpatter <at> uwaterloo.ca>
 ;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2017 Thomas Danckaert <post <at> thomasdanckaert.be>
+;;; Copyright © 2017 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -52,6 +53,7 @@
   #:use-module (gnu packages jemalloc)
   #:use-module (gnu packages language)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages man)
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages parallel)
   #:use-module (gnu packages pcre)
@@ -1469,3 +1471,42 @@ for ODBC.")
 
 (define-public python2-pyodbc-c
   (package-with-python2 python-pyodbc-c))
+
+(define-public mdbtools
+  (package
+    (name "mdbtools")
+    (version "0.7.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/brianb/mdbtools/archive/"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "05hbmxcq173kzb899gdi3bz2qcc1vi3n1qbbkwpsvrq7ggf11wyw"))
+       (file-name (string-append name "-" version ".tar.gz"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("glib" ,glib)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("pkg-config" ,pkg-config)
+       ("txt2man" ,txt2man)
+       ("which" ,which)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'autoreconf
+           (lambda _
+             (zero? (system* "autoreconf" "-vfi")))))))
+    (home-page "https://github.com/mkleehammer/pyodbc")
+    (synopsis "Read Microsoft Access databases")
+    (description "MDB Tools is a set of tools and applications to read the
+proprietary MDB file format used in Microsoft's Access database package.  This
+includes programs to export schema and data from Microsoft's Access database
+file format to other databases such as MySQL, Oracle, Sybase, PostgreSQL,
+etc., and an SQL engine for performing simple SQL queries.")
+    (license (list license:lgpl2.0
+                   license:gpl2+))))
-- 
2.12.2

Message #8 received at 26670 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26670 <at> debbugs.gnu.org
Subject: Re: bug#26670: [PATCH] gnu: Add mdbtools.
Date: Wed, 26 Apr 2017 17:47:33 -0400

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/databases.scm (mdbtools): New variable.
> ---
>  gnu/packages/databases.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index e32bcfa66..bed8719d9 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -15,6 +15,7 @@
>  ;;; Copyright © 2016 Andy Patterson <ajpatter <at> uwaterloo.ca>
>  ;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
>  ;;; Copyright © 2017 Thomas Danckaert <post <at> thomasdanckaert.be>
> +;;; Copyright © 2017 Arun Isaac <arunisaac <at> systemreboot.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -52,6 +53,7 @@
>    #:use-module (gnu packages jemalloc)
>    #:use-module (gnu packages language)
>    #:use-module (gnu packages linux)
> +  #:use-module (gnu packages man)
>    #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages parallel)
>    #:use-module (gnu packages pcre)
> @@ -1469,3 +1471,42 @@ for ODBC.")
>  
>  (define-public python2-pyodbc-c
>    (package-with-python2 python-pyodbc-c))
> +
> +(define-public mdbtools
> +  (package
> +    (name "mdbtools")
> +    (version "0.7.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/brianb/mdbtools/archive/"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "05hbmxcq173kzb899gdi3bz2qcc1vi3n1qbbkwpsvrq7ggf11wyw"))
> +       (file-name (string-append name "-" version ".tar.gz"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("glib" ,glib)))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("pkg-config" ,pkg-config)
> +       ("txt2man" ,txt2man)
> +       ("which" ,which)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'autoreconf
> +           (lambda _
> +             (zero? (system* "autoreconf" "-vfi")))))))
> +    (home-page "https://github.com/mkleehammer/pyodbc")

I'm sure you meant to put https://github.com/brianb/mdbtools as the homepage?

> +    (synopsis "Read Microsoft Access databases")
> +    (description "MDB Tools is a set of tools and applications to read the
> +proprietary MDB file format used in Microsoft's Access database package.  This
> +includes programs to export schema and data from Microsoft's Access database
> +file format to other databases such as MySQL, Oracle, Sybase, PostgreSQL,
> +etc., and an SQL engine for performing simple SQL queries.")
> +    (license (list license:lgpl2.0
> +                   license:gpl2+))))

Also be sure to fix up the commit message so it doesn't have the bug
number and such things in it. Otherwise LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 26670-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26670-done <at> debbugs.gnu.org
Subject: Re: bug#26670: [PATCH] gnu: Add mdbtools.
Date: Thu, 27 Apr 2017 10:18:35 +0530

Pushed with changes!

>> +    (home-page "https://github.com/mkleehammer/pyodbc")
>
> I'm sure you meant to put https://github.com/brianb/mdbtools as the homepage?

Oh, I copied the package definition from pyodbc and was editing it to
make it mdbtools. Forgot to change the home-page! :-P Thanks for
spotting it!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.