GNU bug report logs - #26669
[PATCH 1/7] gnu: Add cdrtools.

Previous Next

Full log

Message #29 received at 26669 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Thomas Danckaert <thomas.danckaert <at> gmail.com>
Cc: Thomas Danckaert <post <at> thomasdanckaert.be>, 26669 <at> debbugs.gnu.org
Subject: Re: bug#26669: [PATCH 2/7] gnu: Add dvd+rw-tools.
Date: Wed, 26 Apr 2017 19:15:49 +0200

On Wed, 26 Apr 2017 18:30:33 +0200
Thomas Danckaert <thomas.danckaert <at> gmail.com> wrote:

> +           (lambda*  (#:key inputs #:allow-other-keys)
> +             ;; We use sed --in-place because substitute* cannot handle the
> +             ;; character encoding used by growisofs.c.
> +             (system* "sed" "-i" "-e"
> +                      (string-append
> +                       "s,\"mkisofs\","
> +                       "\"" (assoc-ref inputs "cdrtools") "/bin/mkisofs\",")
> +                      "growisofs.c")
> +             #t)))))

Maybe rather use

  (zero? (system* ...))

instead of

  (system* ...)
  #t

Otherwise LGTM!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.