GNU bug report logs - #26669
[PATCH 1/7] gnu: Add cdrtools.

Previous Next

Full log

Message #26 received at 26669 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: 26669 <at> debbugs.gnu.org
Subject: Re: bug#26669: [PATCH 1/7] gnu: Add cdrtools.
Date: Wed, 26 Apr 2017 18:59:53 +0200

Hi Thomas,

Thanks for the patches !

Without going into details, it seems to me that you have indentation
issues in this serie.

> +(define-public cdrtools
> +  (package

From here indentation is broken.

> +   (name "cdrtools")
> +   (version "3.01")
> +   (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "mirror://sourceforge/cdrtools/cdrtools-" version ".tar.bz2"))
> +             (sha256
> +              (base32
> +               "03w6ypsmwwy4d7vh6zgwpc60v541vc5ywp8bdb758hbc4yv2wa7d"))
> +             (patches (search-patches "cdrtools-3.01-mkisofs-isoinfo.patch"))))
> +   (build-system gnu-build-system)
> +   (inputs
> +    `(("linux-headers" ,linux-libre-headers)))
> +   (native-inputs
> +    `(("coreutils" ,coreutils)))
> +   (arguments
> +    `(#:phases (modify-phases %standard-phases
> +                 (delete 'configure)
> +                 (add-before 'build 'set-linux-headers
> +                   (lambda _
> +                     (substitute* "autoconf/configure"
> +                       (("/usr/src/linux")
> +                        (assoc-ref %build-inputs "linux-headers")))
> +                     #t))
> +                 (add-before 'build 'substitute-dirs
> +                   (lambda _
> +                     (substitute* (append (find-files "DEFAULTS" "^Defaults\\.")
> +                                          (find-files "DEFAULTS_ENG" "^Defaults\\.")

Please keep all lines in *.scm files to 80 columns or less.

> +                                          (find-files "TEMPLATES" "^Defaults\\."))
> +                       (("/opt/schily") (assoc-ref %outputs "out")))
> +                     #t))

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.