GNU bug report logs - #26623
24.5; bad variable name: `inside-post-command-hook'

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 26623 <at> debbugs.gnu.org
Subject: bug#26623: 24.5; bad variable name: `inside-post-command-hook'
Date: Wed, 26 Apr 2017 08:35:31 +0300

> Date: Sun, 23 Apr 2017 10:00:52 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> This variable's name should not end in `-hook', because that means,
> by convention, that this is a hook variable, which it is not.

No, it's the other way around: a hook variable should have its name
end in "-hook", but not every symbol whose name ends in "-hook" is a
hook variable.

I think the name of this variable speaks very clearly for its purpose,
and see no reason for such formalism in this case.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.