GNU bug report logs - #26622
[PATCH] Add freexl

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26622 in the body.
You can then email your comments to 26622 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add freexl
Date: Sun, 23 Apr 2017 18:36:38 +0200

[Message part 1 (text/plain, inline)]

Another xls files reading library.

The home page of Freexl says

FreeXL is licensed under the MPL tri-license terms; you are free to choose
the best-fit license between:

the MPL 1.1
the GPL v2.0 or any subsequent version
the LGPL v2.1 or any subsequent version

I'm not sure what this means for Guix

Thanks

[Message part 2 (text/html, inline)]

[0001-gnu-Add-freexl.patch (text/x-patch, attachment)]

Message #8 received at 26622 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Catonano <catonano <at> gmail.com>
Cc: 26622 <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Sun, 23 Apr 2017 16:32:57 -0400

[Message part 1 (text/plain, inline)]

Catonano <catonano <at> gmail.com> writes:

> Another xls files reading library.
>
> The home page of Freexl says
>
> FreeXL is licensed under the MPL tri-license terms; you are free to choose the best-fit license
> between:
>
> the MPL 1.1
> the GPL v2.0 or any subsequent version
> the LGPL v2.1 or any subsequent version
>
> I'm not sure what this means for Guix
>
> Thanks
>

Just picking one should be fine. I believe that's what we do for GNU
IceCat, another piece of software under a similar tri-license. I'll
defer to someone else's better judgement though.

> From d5f10229fb928f63404c6097c60e09f2c2a5b1bb Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <catonano <at> gmail.com>
> Date: Sun, 23 Apr 2017 18:24:39 +0200
> Subject: [PATCH 1/1] gnu: Add freexl
>
> * gnu/packages/xml.scm (freexl): New variable.
> ---
>  gnu/packages/xml.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index 7460b5d85..02ae00514 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -1122,3 +1122,23 @@ files.  It is designed to be fast and to handle large input files.")
>       "libxls is a C library which can read Excel (xls) files since Excel 97 (the BIFF8 format).
>  libxls cannot write Excel files.")
>      (license license:bsd-2)))
> +
> +(define-public freexl
> +  (package
> +    (name "freexl")
> +    (version "1.0.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.gaia-gis.it/gaia-sins/"
> +                                  name  "-"
> +                                  version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "17a0yrjb0gln7819j0vp7y25imhvwpil2b0rm44mwgzml0a4i6mk"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://www.gaia-gis.it/fossil/freexl/index")
> +    (synopsis "Read Excel files")
> +    (description
> +     "FreeXL is an open source library to extract valid data
> +from within an Excel (.xls) spreadsheet.")
> +    (license license:gpl2+)))

The package builds and lints fine for me!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26622 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26622 <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Sun, 23 Apr 2017 22:52:11 +0200

[Message part 1 (text/plain, inline)]

2017-04-23 22:32 GMT+02:00 Kei Kebreau <kei <at> openmailbox.org>:

>
> Just picking one should be fine. I believe that's what we do for GNU
> IceCat, another piece of software under a similar tri-license. I'll
> defer to someone else's better judgement though.
>

[...]


> The package builds and lints fine for me!
>

Thank you, Kei

[Message part 2 (text/html, inline)]

Message #14 received at 26622 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>, Catonano <catonano <at> gmail.com>
Cc: 26622 <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Mon, 24 Apr 2017 16:30:23 +0200

[Message part 1 (text/plain, inline)]

Kei Kebreau <kei <at> openmailbox.org> writes:

> Catonano <catonano <at> gmail.com> writes:
>
>> Another xls files reading library.
>>
>> The home page of Freexl says
>>
>> FreeXL is licensed under the MPL tri-license terms; you are free to choose the best-fit license
>> between:
>>
>> the MPL 1.1
>> the GPL v2.0 or any subsequent version
>> the LGPL v2.1 or any subsequent version
>>
>> I'm not sure what this means for Guix
>>
>> Thanks
>>
>
> Just picking one should be fine. I believe that's what we do for GNU
> IceCat, another piece of software under a similar tri-license. I'll
> defer to someone else's better judgement though.

Usually we list all of them. See e.g. "libcmis" or "python2-pycairo". I
don't think we should hide this fact from the end user.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Catonano <catonano <at> gmail.com>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Tue, 25 Apr 2017 22:16:18 +0200

Catonano <catonano <at> gmail.com> writes:

> Another xls files reading library.
>
> The home page of Freexl says
>
> FreeXL is licensed under the MPL tri-license terms; you are free to choose
> the best-fit license between:
>
> the MPL 1.1
> the GPL v2.0 or any subsequent version
> the LGPL v2.1 or any subsequent version
>
> I'm not sure what this means for Guix

This means that we write something like this:

    ;; Any of these licenses may be chosen.
    (license (list license:mpl1.1
                   license:gpl2+
                   license:lgpl2.1+))

> Subject: [PATCH 1/1] gnu: Add freexl
>
> * gnu/packages/xml.scm (freexl): New variable.
> ---
>  gnu/packages/xml.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index 7460b5d85..02ae00514 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -1122,3 +1122,23 @@ files.  It is designed to be fast and to handle large input files.")
>       "libxls is a C library which can read Excel (xls) files since Excel 97 (the BIFF8 format).
>  libxls cannot write Excel files.")
>      (license license:bsd-2)))
> +
> +(define-public freexl
> +  (package
> +    (name "freexl")
> +    (version "1.0.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.gaia-gis.it/gaia-sins/"
> +                                  name  "-"
> +                                  version ".tar.gz"))

I’d join these two lines.

> +              (sha256
> +               (base32
> +                "17a0yrjb0gln7819j0vp7y25imhvwpil2b0rm44mwgzml0a4i6mk"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://www.gaia-gis.it/fossil/freexl/index")
> +    (synopsis "Read Excel files")
> +    (description
> +     "FreeXL is an open source library to extract valid data
> +from within an Excel (.xls) spreadsheet.")

Please don’t use the term “open source”; besides, all software in Guix
is free software anyway.  Just “FreeXL is a C library to extract …” is
sufficient.

Pushed with these changes to master with commit 623fb4d16.

Thanks!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #22 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Tue, 25 Apr 2017 22:33:30 +0200

[Message part 1 (text/plain, inline)]

2017-04-25 22:16 GMT+02:00 Ricardo Wurmus <rekado <at> elephly.net>:

>
> Catonano <catonano <at> gmail.com> writes:
>
>
> Pushed with these changes to master with commit 623fb4d16.
>
> Thanks!
>

Well, thanks to you, Ricardo !

[Message part 2 (text/html, inline)]

Message #25 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Tue, 25 Apr 2017 22:41:49 +0200

[Message part 1 (text/plain, inline)]

Ehm,

the author is "Catonano" rather than "humanitiesNerd"
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=623fb4d1629adfa97e3fe412d394ca0490742f29

Did I mess up my email settings ?

Should I update any email mapping now ?

[Message part 2 (text/html, inline)]

Message #28 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Catonano <catonano <at> gmail.com>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Wed, 26 Apr 2017 08:45:22 +0200

Catonano <catonano <at> gmail.com> writes:

> Ehm,
>
> the author is "Catonano" rather than "humanitiesNerd"
> http://git.savannah.gnu.org/cgit/guix.git/commit/?id=623fb4d1629adfa97e3fe412d394ca0490742f29

Oh, I’m sorry.

> Did I mess up my email settings ?

No, I copied the attribution line from another file that you had
contributed to.  Should we replace all “humanitiesNerd” with “Catonano”?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #31 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Wed, 26 Apr 2017 09:52:15 +0200

[Message part 1 (text/plain, inline)]

2017-04-26 8:45 GMT+02:00 Ricardo Wurmus <rekado <at> elephly.net>:

>
> Catonano <catonano <at> gmail.com> writes:
>
> > Ehm,
> >
> > the author is "Catonano" rather than "humanitiesNerd"
> > http://git.savannah.gnu.org/cgit/guix.git/commit/?id=
> 623fb4d1629adfa97e3fe412d394ca0490742f29
>
> Oh, I’m sorry.
>
> > Did I mess up my email settings ?
>
> No, I copied the attribution line from another file that you had
> contributed to.


Ah, so I messed up a copyright attribution. I apologize, it slipped :-/



> Should we replace all “humanitiesNerd” with “Catonano”?
>

You know what ? We could take this opportunity to switch all my
contributions to my real name, rather than this silly nickname

We could replace all the occurrences of "humanitiesNerd" with "Adriano
Peluso"

Should I send a patch, for this ?

[Message part 2 (text/html, inline)]

Message #34 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Catonano <catonano <at> gmail.com>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Thu, 27 Apr 2017 12:54:13 +0200

Catonano <catonano <at> gmail.com> writes:

> 2017-04-26 8:45 GMT+02:00 Ricardo Wurmus <rekado <at> elephly.net>:
>> Should we replace all “humanitiesNerd” with “Catonano”?
>>
>
> You know what ? We could take this opportunity to switch all my
> contributions to my real name, rather than this silly nickname
>
> We could replace all the occurrences of "humanitiesNerd" with "Adriano
> Peluso"
>
> Should I send a patch, for this ?

Yes, it’s best for you to send a patch.  I’ll apply it.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #37 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Fri, 28 Apr 2017 18:40:24 +0200

[Message part 1 (text/plain, inline)]

2017-04-27 12:54 GMT+02:00 Ricardo Wurmus <rekado <at> elephly.net


> > Should I send a patch, for this ?
>
> Yes, it’s best for you to send a patch.  I’ll apply it.
>
>
Ok, so: here it is
I hope it's ok
Thank you !

[Message part 2 (text/html, inline)]

[0001-fixed-my-own-name-in-copyright-attribtions.patch (text/x-patch, attachment)]

Message #40 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Sat, 29 Apr 2017 19:58:10 +0200

[Message part 1 (text/plain, inline)]

2017-04-28 18:40 GMT+02:00 Catonano <catonano <at> gmail.com>:

> 2017-04-27 12:54 GMT+02:00 Ricardo Wurmus <rekado <at> elephly.net
>
>
>> > Should I send a patch, for this ?
>>
>> Yes, it’s best for you to send a patch.  I’ll apply it.
>>
>>
> Ok, so: here it is
> I hope it's ok
> Thank you !
>


Wait ! This patch is missing one file ! 😯

I'll send a new one in a while !

[Message part 2 (text/html, inline)]

Message #43 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Sat, 29 Apr 2017 20:02:23 +0200

[Message part 1 (text/plain, inline)]

Ok, her is the new one

It contains them all, this time

2017-04-29 19:58 GMT+02:00 Catonano <catonano <at> gmail.com>:

>
>
> 2017-04-28 18:40 GMT+02:00 Catonano <catonano <at> gmail.com>:
>
>> 2017-04-27 12:54 GMT+02:00 Ricardo Wurmus <rekado <at> elephly.net
>>
>>
>>> > Should I send a patch, for this ?
>>>
>>> Yes, it’s best for you to send a patch.  I’ll apply it.
>>>
>>>
>> Ok, so: here it is
>> I hope it's ok
>> Thank you !
>>
>
>
> Wait ! This patch is missing one file ! 😯
>
> I'll send a new one in a while !
>
>

[Message part 2 (text/html, inline)]

[0001-fixed-my-own-name-in-copyright-attribtions.patch (text/x-patch, attachment)]

Message #46 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Catonano <catonano <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Sun, 7 May 2017 20:24:51 -0400

[Message part 1 (text/plain, inline)]

On Sat, Apr 29, 2017 at 08:02:23PM +0200, Catonano wrote:
> From 2ca26fd7b797e9890045fb15cb249f68f44a26ed Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <catonano <at> gmail.com>
> Date: Fri, 28 Apr 2017 18:34:56 +0200
> Subject: [PATCH 1/1] fixed my own name in copyright attribtions
> 
> * gnu/packages/emacs.scm: fixed te copyright line about myself
> * gnu/packages/perl.scl: idem
> * gnu/packkages/python.scm: idem
> * gnu/packkages/xml.scm: idem

Thanks! I pushed it as f9f67fcb0f198e95cff5a14ad332bccc2ffc3221.

Unfortunately, after I pushed it, I noticed that I made a mistake when
rewriting your name in the "Author" field of the Git commit. I'm very
sorry that I misspelled your name!

By the way, the Git "Author" field corresponds to the "From" field in
your message:

> From 2ca26fd7b797e9890045fb15cb249f68f44a26ed Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <catonano <at> gmail.com>
> Date: Fri, 28 Apr 2017 18:34:56 +0200
> Subject: [PATCH 1/1] fixed my own name in copyright attribtions

So, I manually changed it like this:

$ git commit --amend --author=...

And that's when I made the mistake :(

[signature.asc (application/pgp-signature, inline)]

Message #49 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Mon, 8 May 2017 06:04:38 +0200

[Message part 1 (text/plain, inline)]

2017-05-08 2:24 GMT+02:00 Leo Famulari <leo <at> famulari.name>:

> On Sat, Apr 29, 2017 at 08:02:23PM +0200, Catonano wrote:
> > From 2ca26fd7b797e9890045fb15cb249f68f44a26ed Mon Sep 17 00:00:00 2001
> > From: humanitiesNerd <catonano <at> gmail.com>
> > Date: Fri, 28 Apr 2017 18:34:56 +0200
> > Subject: [PATCH 1/1] fixed my own name in copyright attribtions
> >
> > * gnu/packages/emacs.scm: fixed te copyright line about myself
> > * gnu/packages/perl.scl: idem
> > * gnu/packkages/python.scm: idem
> > * gnu/packkages/xml.scm: idem
>
> Thanks! I pushed it as f9f67fcb0f198e95cff5a14ad332bccc2ffc3221.
>
> Unfortunately, after I pushed it, I noticed that I made a mistake when
> rewriting your name in the "Author" field of the Git commit. I'm very
> sorry that I misspelled your name!
>
> By the way, the Git "Author" field corresponds to the "From" field in
> your message:
>
> > From 2ca26fd7b797e9890045fb15cb249f68f44a26ed Mon Sep 17 00:00:00 2001
> > From: humanitiesNerd <catonano <at> gmail.com>
> > Date: Fri, 28 Apr 2017 18:34:56 +0200
> > Subject: [PATCH 1/1] fixed my own name in copyright attribtions
>
> So, I manually changed it like this:
>
> $ git commit --amend --author=...
>
> And that's when I made the mistake :(
>

Leo, it's ok, don't sweat it !

The git log search for "catonano" returns a mixture of "humanitiesNerd",
"Catonano" and "Adriana Peluso" now 😁

This might console you: this happened to me in high school. They kept
messing up my name on the official documents, especially documents
reporting my final grade results at the end of each year

There must be something that triggers some cognitive slope in my name. Who
knows

Thank you both !

P.S. there's a patch bundle of mine pending, it's about Tryton, I'd LOVE of
someone could review it !

Thanks !

[Message part 2 (text/html, inline)]

Message #52 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Catonano <catonano <at> gmail.com>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Mon, 8 May 2017 13:58:05 -0400

[Message part 1 (text/plain, inline)]

On Mon, May 08, 2017 at 06:04:38AM +0200, Catonano wrote:
> Leo, it's ok, don't sweat it !
> 
> The git log search for "catonano" returns a mixture of "humanitiesNerd",
> "Catonano" and "Adriana Peluso" now 😁
> 
> This might console you: this happened to me in high school. They kept
> messing up my name on the official documents, especially documents
> reporting my final grade results at the end of each year
> 
> There must be something that triggers some cognitive slope in my name. Who
> knows
> 
> Thank you both !

Alright, we'll get it right soon enough :)

> P.S. there's a patch bundle of mine pending, it's about Tryton, I'd LOVE of
> someone could review it !

Arun is reviewing it, please poke me if it needs more attention :)

[signature.asc (application/pgp-signature, inline)]

Message #55 received at 26622-done <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Tue, 9 May 2017 18:46:05 +0200

[Message part 1 (text/plain, inline)]

2017-05-08 19:58 GMT+02:00 Leo Famulari <leo <at> famulari.name>:

>
> > P.S. there's a patch bundle of mine pending, it's about Tryton, I'd LOVE
> of
> > someone could review it !
>
> Arun is reviewing it, please poke me if it needs more attention :)
>

I will !

Thanks !

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.