GNU bug report logs - #26622
[PATCH] Add freexl

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26622: closed ([PATCH] Add freexl)
Date: Tue, 25 Apr 2017 20:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 25 Apr 2017 22:16:18 +0200
with message-id <87vapsqm3x.fsf <at> elephly.net>
and subject line Re: bug#26622: [PATCH] Add freexl
has caused the debbugs.gnu.org bug report #26622,
regarding [PATCH] Add freexl
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26622: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26622
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Catonano <catonano <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add freexl
Date: Sun, 23 Apr 2017 18:36:38 +0200

[Message part 3 (text/plain, inline)]

Another xls files reading library.

The home page of Freexl says

FreeXL is licensed under the MPL tri-license terms; you are free to choose
the best-fit license between:

the MPL 1.1
the GPL v2.0 or any subsequent version
the LGPL v2.1 or any subsequent version

I'm not sure what this means for Guix

Thanks

[Message part 4 (text/html, inline)]

[0001-gnu-Add-freexl.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Catonano <catonano <at> gmail.com>
Cc: 26622-done <at> debbugs.gnu.org
Subject: Re: bug#26622: [PATCH] Add freexl
Date: Tue, 25 Apr 2017 22:16:18 +0200

Catonano <catonano <at> gmail.com> writes:

> Another xls files reading library.
>
> The home page of Freexl says
>
> FreeXL is licensed under the MPL tri-license terms; you are free to choose
> the best-fit license between:
>
> the MPL 1.1
> the GPL v2.0 or any subsequent version
> the LGPL v2.1 or any subsequent version
>
> I'm not sure what this means for Guix

This means that we write something like this:

    ;; Any of these licenses may be chosen.
    (license (list license:mpl1.1
                   license:gpl2+
                   license:lgpl2.1+))

> Subject: [PATCH 1/1] gnu: Add freexl
>
> * gnu/packages/xml.scm (freexl): New variable.
> ---
>  gnu/packages/xml.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index 7460b5d85..02ae00514 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -1122,3 +1122,23 @@ files.  It is designed to be fast and to handle large input files.")
>       "libxls is a C library which can read Excel (xls) files since Excel 97 (the BIFF8 format).
>  libxls cannot write Excel files.")
>      (license license:bsd-2)))
> +
> +(define-public freexl
> +  (package
> +    (name "freexl")
> +    (version "1.0.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.gaia-gis.it/gaia-sins/"
> +                                  name  "-"
> +                                  version ".tar.gz"))

I’d join these two lines.

> +              (sha256
> +               (base32
> +                "17a0yrjb0gln7819j0vp7y25imhvwpil2b0rm44mwgzml0a4i6mk"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://www.gaia-gis.it/fossil/freexl/index")
> +    (synopsis "Read Excel files")
> +    (description
> +     "FreeXL is an open source library to extract valid data
> +from within an Excel (.xls) spreadsheet.")

Please don’t use the term “open source”; besides, all software in Guix
is free software anyway.  Just “FreeXL is a C library to extract …” is
sufficient.

Pushed with these changes to master with commit 623fb4d16.

Thanks!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.