GNU bug report logs - #26595
lugaru

Previous Next

Full log

Message #23 received at 26595 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>, 26595 <at> debbugs.gnu.org
Subject: Re: bug#26595: lugaru
Date: Sun, 30 Apr 2017 16:26:33 +0200

[Message part 1 (text/plain, inline)]

Julien Lepiller <julien <at> lepiller.eu> writes:

> Le Sun, 30 Apr 2017 16:04:10 +0200,
> Marius Bakke <mbakke <at> fastmail.com> a écrit :
>
>> Julien Lepiller <julien <at> lepiller.eu> writes:
>> 
>> > * gnu/packages/games.scm (lugaru): New variable.  
>> 
>> [...]
>> 
>> > +    (arguments
>> > +     `(#:configure-flags
>> > +       (list "-DSYSTEM_INSTALL=ON")
>> > +       #:tests? #f))  
>> 
>> Please specify whether there are no tests, or they need something not
>> available in the build environment, missing dependencies etc.
>> 
>> > +    (native-inputs
>> > +     `(("pkg-config" ,pkg-config)))
>> > +    (inputs
>> > +     `(("sdl2" ,sdl2)
>> > +       ("glu" ,glu)
>> > +       ("libjpeg" ,libjpeg-turbo)
>> > +       ("libpng" ,libpng)
>> > +       ("openal" ,openal)
>> > +       ("vorbis" ,libvorbis)
>> > +       ("zlib" ,zlib)))
>> > +    (home-page "https://osslugaru.gitlab.io")
>> > +    (synopsis "Cross-platform third-person action game")
>> > +    (description "The main character, Turner, is an
>> > anthropomorphic rebel bunny +rabbit with impressive combat skills.
>> > In his quest to find those responsible +for slaughtering his
>> > village, he uncovers a far-reaching conspiracy involving +the
>> > corrupt leaders of the rabbit republic and the starving wolves from
>> > a +nearby den.  Turner takes it upon himself to fight against their
>> > plot and save +his fellow rabbits from slavery.")
>> > +    (license (list license:gpl2+ license:cc-by-sa3.0))))  
>> 
>> We usually add comments about what is covered by which license as
>> well. In this case it's a safe guess that assets are CC-BY-SA, but
>> it's nice to have it explicit regardless. Other than that looks good!
>
> Arg, I sent the old patch. Here is the new one.

D'oh. Looks good! :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.