GNU bug report logs - #26595
lugaru

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26595 in the body.
You can then email your comments to 26595 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: lugaru
Date: Fri, 21 Apr 2017 21:33:57 +0200

[Message part 1 (text/plain, inline)]

Hi,

here is a patch to add a new game, lugaru.

[0001-gnu-Add-lugaru.patch (text/x-patch, attachment)]

Message #8 received at 26595 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 26595 <at> debbugs.gnu.org
Subject: Re: bug#26595: lugaru
Date: Fri, 21 Apr 2017 17:16:58 -0400

[Message part 1 (text/plain, inline)]

Julien Lepiller <julien <at> lepiller.eu> writes:

> Hi,
>
> here is a patch to add a new game, lugaru.

LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26595 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 26595 <at> debbugs.gnu.org, kei <at> openmailbox.org
Subject: Re: bug#26595: lugaru
Date: Tue, 25 Apr 2017 22:18:59 +0200

Hi Julien,

thanks for one more game!

> Subject: [PATCH] gnu: Add lugaru.
>
> * gnu/packages/games.scm (lugaru): New variable.
> ---
>  gnu/packages/games.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 8ff5958d1..b66988967 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -3808,3 +3808,39 @@ utter witty remarks about their surroundings, the various inhabitants of their
>  underwater realm quarrel among themselves or comment on the efforts of your
>  fish.  The whole game is accompanied by quiet, comforting music.")
>      (license license:gpl2+)))
> +
> +(define-public lugaru
> +  (package
> +    (name "lugaru")
> +    (version "1.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://bitbucket.org/osslugaru/lugaru/downloads/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "15zgcshy22q51rm72zi6y9z7qlgnz5iw3gczjdlir4bqmxy4gspk"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (list "-DSYSTEM_INSTALL=ON")
> +       #:tests? #f))

Please add a comment to explain why the tests are disabled.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("sdl2" ,sdl2)
> +       ("glu" ,glu)
> +       ("libjpeg" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("openal" ,openal)
> +       ("vorbis" ,libvorbis)
> +       ("zlib" ,zlib)))
> +    (home-page "https://osslugaru.gitlab.io")
> +    (synopsis "Cross-platform third-person action game")
> +    (description "The main character, Turner, is an anthropomorphic rebel bunny
> +rabbit with impressive combat skills.  In his quest to find those responsible
> +for slaughtering his village, he uncovers a far-reaching conspiracy involving
> +the corrupt leaders of the rabbit republic and the starving wolves from a
> +nearby den.  Turner takes it upon himself to fight against their plot and save
> +his fellow rabbits from slavery.")

It would be good to start the description with a short description that
this is a game.

> +    (license (list license:gpl2+ license:cc-by-sa3.0))))

What does this list mean?  Please add a comment.

Could you please send an updated patch?  It’s good to push with these
changes.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #14 received at 26595 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 26595 <at> debbugs.gnu.org
Subject: Re: bug#26595: lugaru
Date: Sun, 30 Apr 2017 14:45:17 +0200

[Message part 1 (text/plain, inline)]

Hi, here is an updated patch.

[0001-gnu-Add-lugaru.patch (text/x-patch, attachment)]

Message #17 received at 26595 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>, 26595 <at> debbugs.gnu.org
Subject: Re: bug#26595: lugaru
Date: Sun, 30 Apr 2017 16:04:10 +0200

[Message part 1 (text/plain, inline)]

Julien Lepiller <julien <at> lepiller.eu> writes:

> * gnu/packages/games.scm (lugaru): New variable.

[...]

> +    (arguments
> +     `(#:configure-flags
> +       (list "-DSYSTEM_INSTALL=ON")
> +       #:tests? #f))

Please specify whether there are no tests, or they need something not
available in the build environment, missing dependencies etc.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("sdl2" ,sdl2)
> +       ("glu" ,glu)
> +       ("libjpeg" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("openal" ,openal)
> +       ("vorbis" ,libvorbis)
> +       ("zlib" ,zlib)))
> +    (home-page "https://osslugaru.gitlab.io")
> +    (synopsis "Cross-platform third-person action game")
> +    (description "The main character, Turner, is an anthropomorphic rebel bunny
> +rabbit with impressive combat skills.  In his quest to find those responsible
> +for slaughtering his village, he uncovers a far-reaching conspiracy involving
> +the corrupt leaders of the rabbit republic and the starving wolves from a
> +nearby den.  Turner takes it upon himself to fight against their plot and save
> +his fellow rabbits from slavery.")
> +    (license (list license:gpl2+ license:cc-by-sa3.0))))

We usually add comments about what is covered by which license as well.
In this case it's a safe guess that assets are CC-BY-SA, but it's nice
to have it explicit regardless. Other than that looks good!

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 26595 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 26595 <at> debbugs.gnu.org
Subject: Re: bug#26595: lugaru
Date: Sun, 30 Apr 2017 16:07:27 +0200

[Message part 1 (text/plain, inline)]

Le Sun, 30 Apr 2017 16:04:10 +0200,
Marius Bakke <mbakke <at> fastmail.com> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > * gnu/packages/games.scm (lugaru): New variable.  
> 
> [...]
> 
> > +    (arguments
> > +     `(#:configure-flags
> > +       (list "-DSYSTEM_INSTALL=ON")
> > +       #:tests? #f))  
> 
> Please specify whether there are no tests, or they need something not
> available in the build environment, missing dependencies etc.
> 
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("sdl2" ,sdl2)
> > +       ("glu" ,glu)
> > +       ("libjpeg" ,libjpeg-turbo)
> > +       ("libpng" ,libpng)
> > +       ("openal" ,openal)
> > +       ("vorbis" ,libvorbis)
> > +       ("zlib" ,zlib)))
> > +    (home-page "https://osslugaru.gitlab.io")
> > +    (synopsis "Cross-platform third-person action game")
> > +    (description "The main character, Turner, is an
> > anthropomorphic rebel bunny +rabbit with impressive combat skills.
> > In his quest to find those responsible +for slaughtering his
> > village, he uncovers a far-reaching conspiracy involving +the
> > corrupt leaders of the rabbit republic and the starving wolves from
> > a +nearby den.  Turner takes it upon himself to fight against their
> > plot and save +his fellow rabbits from slavery.")
> > +    (license (list license:gpl2+ license:cc-by-sa3.0))))  
> 
> We usually add comments about what is covered by which license as
> well. In this case it's a safe guess that assets are CC-BY-SA, but
> it's nice to have it explicit regardless. Other than that looks good!

Arg, I sent the old patch. Here is the new one.

[0001-gnu-Add-lugaru.patch (text/x-patch, attachment)]

Message #23 received at 26595 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>, 26595 <at> debbugs.gnu.org
Subject: Re: bug#26595: lugaru
Date: Sun, 30 Apr 2017 16:26:33 +0200

[Message part 1 (text/plain, inline)]

Julien Lepiller <julien <at> lepiller.eu> writes:

> Le Sun, 30 Apr 2017 16:04:10 +0200,
> Marius Bakke <mbakke <at> fastmail.com> a écrit :
>
>> Julien Lepiller <julien <at> lepiller.eu> writes:
>> 
>> > * gnu/packages/games.scm (lugaru): New variable.  
>> 
>> [...]
>> 
>> > +    (arguments
>> > +     `(#:configure-flags
>> > +       (list "-DSYSTEM_INSTALL=ON")
>> > +       #:tests? #f))  
>> 
>> Please specify whether there are no tests, or they need something not
>> available in the build environment, missing dependencies etc.
>> 
>> > +    (native-inputs
>> > +     `(("pkg-config" ,pkg-config)))
>> > +    (inputs
>> > +     `(("sdl2" ,sdl2)
>> > +       ("glu" ,glu)
>> > +       ("libjpeg" ,libjpeg-turbo)
>> > +       ("libpng" ,libpng)
>> > +       ("openal" ,openal)
>> > +       ("vorbis" ,libvorbis)
>> > +       ("zlib" ,zlib)))
>> > +    (home-page "https://osslugaru.gitlab.io")
>> > +    (synopsis "Cross-platform third-person action game")
>> > +    (description "The main character, Turner, is an
>> > anthropomorphic rebel bunny +rabbit with impressive combat skills.
>> > In his quest to find those responsible +for slaughtering his
>> > village, he uncovers a far-reaching conspiracy involving +the
>> > corrupt leaders of the rabbit republic and the starving wolves from
>> > a +nearby den.  Turner takes it upon himself to fight against their
>> > plot and save +his fellow rabbits from slavery.")
>> > +    (license (list license:gpl2+ license:cc-by-sa3.0))))  
>> 
>> We usually add comments about what is covered by which license as
>> well. In this case it's a safe guess that assets are CC-BY-SA, but
>> it's nice to have it explicit regardless. Other than that looks good!
>
> Arg, I sent the old patch. Here is the new one.

D'oh. Looks good! :)

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 26595-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 26595-done <at> debbugs.gnu.org
Date: Sat, 6 May 2017 10:20:28 +0200

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.