GNU bug report logs - #26582
[PATCH] gnu: pcre: Fix Check for Hurd systems.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26582 in the body.
You can then email your comments to 26582 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: Manolis Ragkousis <manolis837 <at> gmail.com>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Thu, 20 Apr 2017 14:31:51 -0500

[Message part 1 (text/plain, inline)]

Hi,
> Also this
> 
> >   ,@(if (hurd-triplet? ((or %current-system
> >                             %current-target-system)))
> 
> should be this
> 
> >   ,@(if (hurd-triplet? (or (%current-system)
> >                            (%current-target-system)))
> 

Fixed!

> Btw trying to build it with `./pre-inst-env guix build
> --target=i586-pc-gnu pcre' fails with
> 
> ** Cannot --enable-pcregrep-libz because zlib.h was not found
> 
> Maybe the inputs should become native-inputs?

I moved zlib and readline to 'native-inputs'.
Finally './pre-inst-env guix build pcre --target=i586-pc-gnu' built  
successfully.

[0001-gnu-pcre-Fix-Check-for-Hurd-systems.patch (text/x-patch, attachment)]

Message #8 received at 26582 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: rennes <rennes <at> openmailbox.org>
Cc: 26582 <at> debbugs.gnu.org, Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Re: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Thu, 20 Apr 2017 23:27:29 +0200

rennes <rennes <at> openmailbox.org> skribis:

> Hi,
>> Also this
>> 
>> >   ,@(if (hurd-triplet? ((or %current-system
>> >                             %current-target-system)))
>> 
>> should be this
>> 
>> >   ,@(if (hurd-triplet? (or (%current-system)
>> >                            (%current-target-system)))
>> 
>
> Fixed!
>
>> Btw trying to build it with `./pre-inst-env guix build
>> --target=i586-pc-gnu pcre' fails with
>> 
>> ** Cannot --enable-pcregrep-libz because zlib.h was not found
>> 
>> Maybe the inputs should become native-inputs?
>
> I moved zlib and readline to 'native-inputs'.

Are you sure they need to be native inputs?  Both are libraries, so I
imagine they’re used at run time, not at build time; they should be
inputs, in this case.

Thoughts?

Ludo’.

Message #11 received at 26582 <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26582 <at> debbugs.gnu.org, Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Re: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Thu, 20 Apr 2017 21:38:44 -0500

Hello Ludovic,

On 04/20/2017 04:27:29 PM, Ludovic Courtès wrote:

> >> Btw trying to build it with `./pre-inst-env guix build
> >> --target=i586-pc-gnu pcre' fails with
> >>
> >> ** Cannot --enable-pcregrep-libz because zlib.h was not found
> >>
> >> Maybe the inputs should become native-inputs?
> >
> > I moved zlib and readline to 'native-inputs'.
> 
> Are you sure they need to be native inputs?  Both are libraries, so I
> imagine they’re used at run time, not at build time; they should be
> inputs, in this case.
> 

I see the new 'replace `configure' does not detects the inputs, I will  
continue to test!.

Message #16 received at 26582 <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26582 <at> debbugs.gnu.org, Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Re: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Fri, 21 Apr 2017 21:40:03 -0500

[Message part 1 (text/plain, inline)]

Hello,

On 04/20/2017 04:27:29 PM, Ludovic Courtès wrote:
> >
> > I moved zlib and readline to 'native-inputs'.
> 
> Are you sure they need to be native inputs?  Both are libraries, so I
> imagine they’re used at run time, not at build time; they should be
> inputs, in this case.
> 
I added system types: "--build=" and "--host=" to 'configure'. Now  
detects correctly the inputs.

Built successfully on Linux x86_64, GNU/Hurd and cross-compiling with  
target 'i586-pc-gnu'.
Thanks for the guide

[0001-gnu-pcre-Fix-Check-for-Hurd-systems.patch (text/x-patch, attachment)]

Message #19 received at 26582 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: rennes <rennes <at> openmailbox.org>
Cc: 26582 <at> debbugs.gnu.org, Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Re: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Sun, 23 Apr 2017 00:13:15 +0200

Hi rennes,

rennes <rennes <at> openmailbox.org> skribis:

> On 04/20/2017 04:27:29 PM, Ludovic Courtès wrote:
>> >
>> > I moved zlib and readline to 'native-inputs'.
>> 
>> Are you sure they need to be native inputs?  Both are libraries, so I
>> imagine they’re used at run time, not at build time; they should be
>> inputs, in this case.
>> 
> I added system types: "--build=" and "--host=" to 'configure'. Now  
> detects correctly the inputs.
>
> Built successfully on Linux x86_64, GNU/Hurd and cross-compiling with  
> target 'i586-pc-gnu'.
> Thanks for the guide
>
> From 05f159e343173708b85c5e45b6cfe64e3939c68d Mon Sep 17 00:00:00 2001
> From: rennes <rennes <at> openmailbox.org>
> Date: Fri, 21 Apr 2017 21:22:08 -0500
> Subject: [PATCH] gnu: pcre: Fix Check for Hurd systems.
>
> * gnu/packages/pcre.scm (pcre)[arguments]: Add "--disable-stack-for-recursion".	

The patch does more than that.  :-)

> +      #:phases
> +      (modify-phases %standard-phases
> +        (replace 'configure
> +                 (lambda* (#:key outputs build target #:allow-other-keys)
> +                   (let* ((out (assoc-ref outputs "out"))
> +                          (bin (assoc-ref outputs "bin"))
> +                          (doc (assoc-ref outputs "doc")))
> +                     (setenv "CONFIG_SHELL" (which "bash"))
> +                     (zero?
> +                      (system* "./configure"
> +                               (string-append "--prefix=" out)
> +                               (string-append "--bindir=" bin)
> +                               (string-append "--docdir=" doc)
> +                               (string-append "--build=" build)
> +                               (string-append "--host=" (or target build))

I would expect the ‘configure’ phase in (guix build gnu-build-system) to
already pass those flags, no?  (If that is the case we could keep
#:configure-flags instead of replacing the ‘configure’ phase.)

> +                               ;; On GNU/Hurd systems FAIL 'RunTest' with 'segmentation
> +                               ;; fault' in Check phase, to pass the test we can disable
> +                               ;; "--enable-jit" or set "--disable-stack-for-recursion"
> +                               ;; argument.
> +                               ,@(if (hurd-triplet? (or (%current-system)
> +                                                        ( %current-target-system)))
> +                                     '("--disable-stack-for-recursion")
> +                                     '())))))))))

This part looks OK to me (even better if you have a pointer to an
upstream bug report or discussion.)

Thanks!

Luodo’.

Message #22 received at 26582 <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26582 <at> debbugs.gnu.org, Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Re: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Sat, 29 Apr 2017 17:25:46 -0500

Hello Ludovic,
> 
> I would expect the ‘configure’ phase in (guix build gnu-build-system)  
> to
> already pass those flags, no?  (If that is the case we could keep
> #:configure-flags instead of replacing the ‘configure’ phase.)
> 

I am a little confused!
I am replacing the Configure phase to set  
"--disable-stack-for-recursion", which only applies to Hurd.

Or is there another way to do it, without replacing Configure?

Message #25 received at 26582 <at> debbugs.gnu.org (full text, mbox):

From: rennes <rennes <at> openmailbox.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26582 <at> debbugs.gnu.org, Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Re: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Mon, 01 May 2017 08:34:00 -0500

Hello Ludovic,
On 04/29/2017 05:25:46 PM, rennes wrote:
> Hello Ludovic,
>> 
>> I would expect the ‘configure’ phase in (guix build  
>> gnu-build-system) to
>> already pass those flags, no?  (If that is the case we could keep
>> #:configure-flags instead of replacing the ‘configure’ phase.)
>> 
> 
> I am a little confused!
> I am replacing the Configure phase to set  
> "--disable-stack-for-recursion", which only applies to Hurd.
> 
> Or is there another way to do it, without replacing Configure?

Please ignore this last message, we find a way to solve it !.

Message #30 received at 26582-done <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: 26582-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: pcre: Fix Check for Hurd systems.
Date: Wed, 13 Feb 2019 13:58:55 +0200

I think this issue is no longer applicable.

I am closing the issue.

Manolis

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.