GNU bug report logs - #26546
[PATCH] gnu: Add ponymix

Previous Next

Full log

Message #10 received at 26546-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 26546-done <at> debbugs.gnu.org
Subject: Re: bug#26546: [PATCH] gnu: Add ponymix
Date: Mon, 17 Apr 2017 16:39:43 -0400

[Message part 1 (text/plain, inline)]

On Mon, Apr 17, 2017 at 09:41:22PM +0200, Stefan Reichör wrote:
> From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <stefan <at> xsteve.at>
> Date: Mon, 17 Apr 2017 21:35:33 +0200
> Subject: [PATCH] gnu: Add ponymix.
> 
> * gnu/packages/pulseaudio.scm (ponymix): New variable.

Thanks! Pushed as 05bdb5e64dea826552510cfeba8c63bcf487dcad with the
following changes:

> +             (uri (string-append "https://github.com/falconindy/ponymix/"
> +                                 "archive/" version ".tar.gz"))

To satisfy `guix lint`, I used (file-name) to make sure the source
tarball included the name of the package.

> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "Makefile"
> +                  (("/usr") "")))))

Since origin snippets affect what you get from `guix build --source`, we
reserve them for fixing serious bugs and software freedom issues.
Guix-specific changes like this one are done in build phases, which
don't affect the source tarball. So, I moved this substitution into a
'patch-paths' phase.

> +    (synopsis "CLI PulseAudio volume control")
> +    (description
> +     "PulseAudio Volume Control for the CLI. In addition it is possible
> +to use named sources and sinks.")

I made some stylistic changes here.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.