GNU bug report logs - #26546
[PATCH] gnu: Add ponymix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26546 in the body.
You can then email your comments to 26546 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add ponymix
Date: Mon, 17 Apr 2017 21:41:22 +0200

[0001-gnu-Add-ponymix.patch (text/x-diff, inline)]

From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
From: Stefan Reichoer <stefan <at> xsteve.at>
Date: Mon, 17 Apr 2017 21:35:33 +0200
Subject: [PATCH] gnu: Add ponymix.

* gnu/packages/pulseaudio.scm (ponymix): New variable.
---
 gnu/packages/pulseaudio.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index 71fcc3f..c0602c3 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
+;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -247,3 +248,37 @@ sound server.")
 graphical user interface to connect to a PulseAudio server and
 easily control the volume of all clients, sinks, etc.")
     (license l:gpl2+)))
+
+(define-public ponymix
+  (package
+    (name "ponymix")
+    (version "5")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "https://github.com/falconindy/ponymix/"
+                                 "archive/" version ".tar.gz"))
+             (sha256
+              (base32
+               "1c0ch98zry3c4ixywwynjid1n1nh4xl4l1p548giq2w3zwflaghn"))
+              (modules '((guix build utils)))
+              (snippet
+               '(substitute* "Makefile"
+                  (("/usr") "")))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ; There is no test suite.
+       #:make-flags (let ((out (assoc-ref %outputs "out")))
+                      (list (string-append "DESTDIR=" out)))
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)))) ; There's no configure phase.
+    (inputs
+     `(("pulseaudio" ,pulseaudio)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/falconindy/ponymix")
+    (synopsis "CLI PulseAudio volume control")
+    (description
+     "PulseAudio Volume Control for the CLI. In addition it is possible
+to use named sources and sinks.")
+    (license l:expat)))
-- 
2.7.4

Message #10 received at 26546-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 26546-done <at> debbugs.gnu.org
Subject: Re: bug#26546: [PATCH] gnu: Add ponymix
Date: Mon, 17 Apr 2017 16:39:43 -0400

[Message part 1 (text/plain, inline)]

On Mon, Apr 17, 2017 at 09:41:22PM +0200, Stefan Reichör wrote:
> From c0e4e33ba755803324e4ce8fbddb80e540d753af Mon Sep 17 00:00:00 2001
> From: Stefan Reichoer <stefan <at> xsteve.at>
> Date: Mon, 17 Apr 2017 21:35:33 +0200
> Subject: [PATCH] gnu: Add ponymix.
> 
> * gnu/packages/pulseaudio.scm (ponymix): New variable.

Thanks! Pushed as 05bdb5e64dea826552510cfeba8c63bcf487dcad with the
following changes:

> +             (uri (string-append "https://github.com/falconindy/ponymix/"
> +                                 "archive/" version ".tar.gz"))

To satisfy `guix lint`, I used (file-name) to make sure the source
tarball included the name of the package.

> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "Makefile"
> +                  (("/usr") "")))))

Since origin snippets affect what you get from `guix build --source`, we
reserve them for fixing serious bugs and software freedom issues.
Guix-specific changes like this one are done in build phases, which
don't affect the source tarball. So, I moved this substitution into a
'patch-paths' phase.

> +    (synopsis "CLI PulseAudio volume control")
> +    (description
> +     "PulseAudio Volume Control for the CLI. In addition it is possible
> +to use named sources and sinks.")

I made some stylistic changes here.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.