GNU bug report logs - #26495
[PATCH] cargo-build-system: Remove store reference.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: bug#26495: closed (Re: bug#26495: [PATCH] cargo-build-system:
 Remove store reference.)
Date: Fri, 14 Apr 2017 10:24:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#26495: [PATCH] cargo-build-system: Remove store reference.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26495 <at> debbugs.gnu.org.

-- 
26495: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26495
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26495-done <at> debbugs.gnu.org
Subject: Re: bug#26495: [PATCH] cargo-build-system: Remove store reference.
Date: Fri, 14 Apr 2017 12:23:22 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * guix/build/cargo-build-system.scm (generate-checksums): Remove store
>   reference from comment. This comment was matching
>   assert-no-store-file-names regexp in Makefile.am.
>   Also, edit procedure docstring to precise that DIR-NAME is a store
>   directory.

Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] cargo-build-system: Remove store reference.
Date: Fri, 14 Apr 2017 12:12:56 +0200

* guix/build/cargo-build-system.scm (generate-checksums): Remove store
  reference from comment. This comment was matching
  assert-no-store-file-names regexp in Makefile.am.
  Also, edit procedure docstring to precise that DIR-NAME is a store
  directory.
---
 guix/build/cargo-build-system.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm
index f11d85874..139b40321 100644
--- a/guix/build/cargo-build-system.scm
+++ b/guix/build/cargo-build-system.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 David Craven <david <at> craven.ch>
+;;; Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -116,12 +117,12 @@ directory = '" port)
       (close-pipe port)
       result)))
 
-;; Example dir-name: "/gnu/store/hwlr49riz3la33m6in2n898ly045ylld-rust-rand-0.3.15".
 (define (generate-checksums dir-name src-name)
-  "Given DIR-NAME, checksum all the files in it one by one and put the
-   result into the file \".cargo-checksum.json\" in the same directory.
-   Also includes the checksum of an extra file SRC-NAME as if it was
-   part of the directory DIR-NAME with name \"package\"."
+  "Given DIR-NAME, a store directory, checksum all the files in it one
+by one and put the result into the file \".cargo-checksum.json\" in
+the same directory.  Also includes the checksum of an extra file
+SRC-NAME as if it was part of the directory DIR-NAME with name
+\"package\"."
   (let* ((file-names (find-files dir-name "."))
          (dir-prefix-name (string-append dir-name "/"))
          (dir-prefix-name-len (string-length dir-prefix-name))
-- 
2.12.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.