GNU bug report logs - #26496
[PATCH] build: Stop building gnu/build/svg.scm.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26496 in the body.
You can then email your comments to 26496 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] build: Stop building gnu/build/svg.scm.
Date: Fri, 14 Apr 2017 12:14:51 +0200

* Makefile.am (EXTRA_DIST): Add gnu/build/svg.scm.
* gnu/local.mk (GNU_SYSTEM_MODULES): Remove gnu/build/svg.scm.

It fixes the following build warnings:

gnu/build/svg.scm:36:12: warning: possibly unbound variable `cairo-create'
gnu/build/svg.scm:36:26: warning: possibly unbound variable `cairo-image-surface-create'
gnu/build/svg.scm:38:4: warning: possibly unbound variable `cairo-scale'
gnu/build/svg.scm:39:4: warning: possibly unbound variable `cairo-set-source-surface'
---
 Makefile.am  | 2 ++
 gnu/local.mk | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 99b455605..c9671e2d1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -4,6 +4,7 @@
 # Copyright © 2015, 2017 Alex Kost <alezost <at> gmail.com>
 # Copyright © 2016 Mathieu Lirzin <mthl <at> gnu.org>
 # Copyright © 2016, 2017 Mark H Weaver <mhw <at> netris.org>
+# Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
 #
 # This file is part of GNU Guix.
 #
@@ -394,6 +395,7 @@ EXTRA_DIST =						\
   TODO							\
   CODE-OF-CONDUCT					\
   .dir-locals.el					\
+  gnu/build/svg.scm					\
   build-aux/build-self.scm				\
   build-aux/compile-all.scm				\
   build-aux/hydra/evaluate.scm				\
diff --git a/gnu/local.mk b/gnu/local.mk
index 9385b3df9..e5973ab0d 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -459,7 +459,6 @@ GNU_SYSTEM_MODULES =				\
   %D%/build/linux-modules.scm			\
   %D%/build/marionette.scm			\
   %D%/build/shepherd.scm			\
-  %D%/build/svg.scm				\
   %D%/build/vm.scm				\
 						\
   %D%/tests.scm					\
-- 
2.12.2

Message #10 received at 26496-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26496-done <at> debbugs.gnu.org
Subject: Re: bug#26496: [PATCH] build: Stop building gnu/build/svg.scm.
Date: Fri, 14 Apr 2017 12:23:57 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * Makefile.am (EXTRA_DIST): Add gnu/build/svg.scm.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Remove gnu/build/svg.scm.
>
> It fixes the following build warnings:
>
> gnu/build/svg.scm:36:12: warning: possibly unbound variable `cairo-create'
> gnu/build/svg.scm:36:26: warning: possibly unbound variable `cairo-image-surface-create'
> gnu/build/svg.scm:38:4: warning: possibly unbound variable `cairo-scale'
> gnu/build/svg.scm:39:4: warning: possibly unbound variable `cairo-set-source-surface'

Applied, thanks!

Ludo'.

Message #13 received at 26496-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26496-done <at> debbugs.gnu.org
Subject: Re: bug#26496: [PATCH] build: Stop building gnu/build/svg.scm.
Date: Fri, 14 Apr 2017 15:17:28 +0200

> Applied, thanks!

Guix build is almost warning free !

The only remaining warnings are the consequence of using make-page-map
from (charting) in guix/scripts/size.scm, any thoughs ?

Thanks,

Mathieu

Message #16 received at 26496-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26496-done <at> debbugs.gnu.org
Subject: Re: bug#26496: [PATCH] build: Stop building gnu/build/svg.scm.
Date: Fri, 14 Apr 2017 17:17:06 +0200

Hi!

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> The only remaining warnings are the consequence of using make-page-map
> from (charting) in guix/scripts/size.scm, any thoughs ?

I don’t think we can change that one: the idea is that this feature is
available when Guile-Charting is available, is missing otherwise.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.