GNU bug report logs - #26488
[PATCH] gnu: Add crawl.

Previous Next

Full log

Message #35 received at 26488 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: nee <nee <at> cock.li>
Cc: 26488 <at> debbugs.gnu.org
Subject: Re: bug#26488: [PATCH] gnu: Add crawl.
Date: Wed, 19 Apr 2017 11:41:34 +0530

> Thank you very much, for your intensive help with cleaning up this package!

No problem! That's what I'm here for... :-) And, thank you for your
patience with all my corrections!

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'check)
> +         ;; Test cases require the source to be rebuild with the -DDEBUG define.
> +         ;; Do 'check before 'build to avoid a 3rd build on make install.
> +         (add-before 'build 'check
> +           (lambda* (#:key inputs outputs make-flags
> +                     parallel-build? parallel-tests? #:allow-other-keys)

Since you are not using the parallel-build? and parallel-tests? keyword
arguments anymore, why keep them in the argument list?

> +             (zero? (apply system* "make" "debug" "test"
> +                           (cons (format #f "-j~d" (parallel-job-count))
> +                                 make-flags))))))))

As noted earlier, only the last argument of apply needs to be a
list. So, this can be shortened to something like:

(zero? (apply system* "make" (format #f "-j~d"
(parallel-job-count)) "debug" "test" make-flags))

Everything else LGTM! Only the graphical build remains now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.