GNU bug report logs - #26487
Add antlr3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26487 in the body.
You can then email your comments to 26487 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: Add antlr3
Date: Thu, 13 Apr 2017 22:46:13 +0200

[Message part 1 (text/plain, inline)]

Hi, here are patches to add antlr3, a parser generator.

* 0001-guix-ant-build-system-Add-src-dir-parameter.patch: adds a
  #:src-dir parameter to the ant-build-system, to change the source
  directory and possibly specify more than one directory.
* 0002-gnu-Add-antlr2.patch: Adds antlr2, an older version of antlr,
  that is required by antlr3 to generate some of its source files, and
  because parts of it is used by antlr3 (such as the CommonTree class).
* 0003-gnu-Add-stringtemplate3.patch: Adds stringtemplate3, a runtime
  requirement of antlr3. It is a library to generate strings using
  templates.
* 0004-gnu-Add-antlr3-and-stringtemplate4.patch: a big patch that adds
  antlr3 and stringtemplate4 (ST4). ST4 is a newer version of ST3, is a
  runtime dependency of antlr3 and needs antlr3 to generate some of its
  source files. antlr3 depends on ST4 too. I didn't find a way to split
  this patch further.

I wanted to package antlr4, but I'm still working on its dependencies
(antlr3 is one of them).

[0001-guix-ant-build-system-Add-src-dir-parameter.patch (text/x-patch, attachment)]

[0002-gnu-Add-antlr2.patch (text/x-patch, attachment)]

[0003-gnu-Add-stringtemplate3.patch (text/x-patch, attachment)]

[0004-gnu-Add-antlr3-and-stringtemplate4.patch (text/x-patch, attachment)]

Message #8 received at 26487 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 26487 <at> debbugs.gnu.org
Subject: Re: bug#26487: Add antlr3
Date: Sat, 15 Apr 2017 15:59:17 -0400

[Message part 1 (text/plain, inline)]

Julien Lepiller <julien <at> lepiller.eu> writes:

> Hi, here are patches to add antlr3, a parser generator.
>
> * 0001-guix-ant-build-system-Add-src-dir-parameter.patch: adds a
>   #:src-dir parameter to the ant-build-system, to change the source
>   directory and possibly specify more than one directory.
> * 0002-gnu-Add-antlr2.patch: Adds antlr2, an older version of antlr,
>   that is required by antlr3 to generate some of its source files, and
>   because parts of it is used by antlr3 (such as the CommonTree class).
> * 0003-gnu-Add-stringtemplate3.patch: Adds stringtemplate3, a runtime
>   requirement of antlr3. It is a library to generate strings using
>   templates.
> * 0004-gnu-Add-antlr3-and-stringtemplate4.patch: a big patch that adds
>   antlr3 and stringtemplate4 (ST4). ST4 is a newer version of ST3, is a
>   runtime dependency of antlr3 and needs antlr3 to generate some of its
>   source files. antlr3 depends on ST4 too. I didn't find a way to split
>   this patch further.
>
> I wanted to package antlr4, but I'm still working on its dependencies
> (antlr3 is one of them).

Everything looks good except for the antlr2 jar file, where the
timestamps inside the jar file differ. Is there a way to fix this that
you are aware of?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26487 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 26487 <at> debbugs.gnu.org
Subject: Re: bug#26487: Add antlr3
Date: Mon, 17 Apr 2017 15:03:53 +0200

[Message part 1 (text/plain, inline)]

Le Sat, 15 Apr 2017 15:59:17 -0400,
Kei Kebreau <kei <at> openmailbox.org> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > Hi, here are patches to add antlr3, a parser generator.
> >
> > * 0001-guix-ant-build-system-Add-src-dir-parameter.patch: adds a
> >   #:src-dir parameter to the ant-build-system, to change the source
> >   directory and possibly specify more than one directory.
> > * 0002-gnu-Add-antlr2.patch: Adds antlr2, an older version of antlr,
> >   that is required by antlr3 to generate some of its source files,
> > and because parts of it is used by antlr3 (such as the CommonTree
> > class).
> > * 0003-gnu-Add-stringtemplate3.patch: Adds stringtemplate3, a
> > runtime requirement of antlr3. It is a library to generate strings
> > using templates.
> > * 0004-gnu-Add-antlr3-and-stringtemplate4.patch: a big patch that
> > adds antlr3 and stringtemplate4 (ST4). ST4 is a newer version of
> > ST3, is a runtime dependency of antlr3 and needs antlr3 to generate
> > some of its source files. antlr3 depends on ST4 too. I didn't find
> > a way to split this patch further.
> >
> > I wanted to package antlr4, but I'm still working on its
> > dependencies (antlr3 is one of them).  
> 
> Everything looks good except for the antlr2 jar file, where the
> timestamps inside the jar file differ. Is there a way to fix this that
> you are aware of?

Hi, I fixed the reproducibility issue by copying part of the
ant-build-system in antlr2's recipe.

[0001-guix-ant-build-system-Add-src-dir-parameter.patch (text/x-patch, attachment)]

[0002-gnu-Add-antlr2.patch (text/x-patch, attachment)]

[0003-gnu-Add-stringtemplate3.patch (text/x-patch, attachment)]

[0004-gnu-Add-antlr3-and-stringtemplate4.patch (text/x-patch, attachment)]

Message #14 received at 26487 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 26487 <at> debbugs.gnu.org
Subject: Re: bug#26487: Add antlr3
Date: Mon, 08 May 2017 22:16:58 +0200

Hello!

Julien Lepiller <julien <at> lepiller.eu> skribis:

> Hi, I fixed the reproducibility issue by copying part of the
> ant-build-system in antlr2's recipe.
>
> From bc2eaf6e11cea60169f16c35ca052a67f83990af Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien <at> lepiller.eu>
> Date: Thu, 13 Apr 2017 20:18:15 +0200
> Subject: [PATCH 1/4] guix: ant-build-system: Add src-dir parameter.
>
> * guix/build-system/ant.scm (ant-build): Add src-dir parameter.
> * guix/build/ant-build-system.scm (configure): Add src-dir parameter.
> (default-build.xml): Use it.
> * doc/guix.texi: Document it.

[...]

> --- a/guix/build-system/ant.scm
> +++ b/guix/build-system/ant.scm
> @@ -98,6 +98,7 @@
>                      (make-flags ''())
>                      (build-target "jar")
>                      (jar-name #f)
> +                    (src-dir "src")

The general guideline (info "(guix) Formatting Code") is to use full
words as identifiers.  Could you change ‘src-dir’ to ‘source-directory’?
(In the code and .texi.)

Kei already OKayed the remaining patches and they look good to me too.

Thanks!

Ludo’.

Message #19 received at 26487-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 26487-done <at> debbugs.gnu.org
Subject: Re: bug#26487: Add antlr3
Date: Mon, 15 May 2017 23:21:25 +0200

Hi Julien,

thank you for tackling antlr!

I saw that the patches have already been pushed, but here are a couple
of comments anyway.

* Please end all phases and snippets with “#t” or use (zero? …) when
  the last thing is “system*”.

* All Java packages should be prefixed with “java-”.

* Please capitalise “Java” in descriptions.

* When disabling tests, please always explain why.

* Instead of copying from the ant-build-system you can reference build
  phases directly.

* Please use “with-directory-excursion” instead of multiple calls to
  “chdir” when possible.

* Please put comments before package variants that use a seemingly
  arbitrary version or configuration.

I’m going to make a couple of changes to your packages in the coming
days as follow-up commits to address these issues.

Thanks again!

(Since the patches have been pushed already, I’m closing this bug.)

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.