GNU bug report logs - #26420
Add emacs-use-package

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26420 <at> debbugs.gnu.org
Subject: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Mon, 10 Apr 2017 14:43:54 +0200

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         ;; tests fail in this release
>>> +         (add-before 'install 'check
>>> +           (lambda _
>>> +             (zero? (system* "emacs" "--batch" "-L" "."
>>> +                             "-l" "use-package-tests.el"
>>> +                             "-f" "ert-run-tests-batch-and-exit"))
>>> +             #t)))))
>>
>> Please remove #t as it would hide a failure of the “emacs --batch”
>> command above.
>
> As noted in the comment, the tests fail in this release. I have put the
> #t there to make the package build succeed. In the upstream git
> checkout, tests pass. So, in the next release, tests should pass. When
> updating the package, the #t should be removed. Is this ok? Shall I
> leave the #t there?

Oh sure.  Maybe move the comment closer to #t and, if you have the
reference of the upstream fix, you can put it there.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.