GNU bug report logs - #26420
Add emacs-use-package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26420 in the body.
You can then email your comments to 26420 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Subject: Add emacs-use-package
Date: Sun, 09 Apr 2017 22:18:12 +0530

Patches for adding emacs-use-package and its dependency emacs-diminish
coming through...

Message #8 received at 26420 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26420 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 1/2] gnu: Add emacs-diminish.
Date: Sun,  9 Apr 2017 22:27:02 +0530

* gnu/packages/emacs.scm (emacs-diminish): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cc14fd228..e3fe5e51e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4081,3 +4081,24 @@ single-long-line paragraphs get word-wrapped in a way similar to what
 you'd get with @kbd{M-q} using @code{adaptive-fill-mode}, but without
 actually changing the buffer's text.")
     (license license:gpl3+)))
+
+(define-public emacs-diminish
+  (package
+    (name "emacs-diminish")
+    (version "0.45")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/myrjola/diminish.el/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0i3629sv5cfrrb00hcnmaqzgs8mk36yasc1ax3ry1ga09nr6rkj9"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/myrjola/diminish.el")
+    (synopsis "Diminish minor modes with no modeline display")
+    (description "@code{emacs-diminish} implements hiding or
+abbreviation of the mode line displays (lighters) of minor modes.")
+    (license license:gpl2+)))
-- 
2.12.2

Message #11 received at 26420 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26420 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Sun,  9 Apr 2017 22:27:03 +0530

* gnu/packages/emacs.scm (emacs-use-package): New variable.
---
 gnu/packages/emacs.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e3fe5e51e..4a77723b3 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4102,3 +4102,37 @@ actually changing the buffer's text.")
     (description "@code{emacs-diminish} implements hiding or
 abbreviation of the mode line displays (lighters) of minor modes.")
     (license license:gpl2+)))
+
+(define-public emacs-use-package
+  (package
+    (name "emacs-use-package")
+    (version "2.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/jwiegley/use-package/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0x4h136jb3imyli6zsh7dyzjrra6pv0v6b0yk94jdng3rdfcmsf5"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-diminish" ,emacs-diminish)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; tests fail in this release
+         (add-before 'install 'check
+           (lambda _
+             (zero? (system* "emacs" "--batch" "-L" "."
+                             "-l" "use-package-tests.el"
+                             "-f" "ert-run-tests-batch-and-exit"))
+             #t)))))
+    (home-page "https://github.com/jwiegley/use-package")
+    (synopsis "Declaration for simplifying your .emacs")
+    (description "The use-package macro allows you to isolate package
+configuration in your .emacs file in a way that is both
+performance-oriented and tidy.")
+    (license license:gpl2+)))
-- 
2.12.2

Message #14 received at 26420 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26420 <at> debbugs.gnu.org
Subject: Re: bug#26420: [PATCH 1/2] gnu: Add emacs-diminish.
Date: Mon, 10 Apr 2017 11:09:39 +0200

Hi Arun,

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> * gnu/packages/emacs.scm (emacs-diminish): New variable.

LGTM, please push!

Ludo’.

Message #17 received at 26420 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26420 <at> debbugs.gnu.org
Subject: Re: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Mon, 10 Apr 2017 11:10:47 +0200

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> * gnu/packages/emacs.scm (emacs-use-package): New variable.

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; tests fail in this release
> +         (add-before 'install 'check
> +           (lambda _
> +             (zero? (system* "emacs" "--batch" "-L" "."
> +                             "-l" "use-package-tests.el"
> +                             "-f" "ert-run-tests-batch-and-exit"))
> +             #t)))))

Please remove #t as it would hide a failure of the “emacs --batch”
command above.

> +    (home-page "https://github.com/jwiegley/use-package")
> +    (synopsis "Declaration for simplifying your .emacs")
> +    (description "The use-package macro allows you to isolate package
> +configuration in your .emacs file in a way that is both
> +performance-oriented and tidy.")

@file{.emacs} in the synopsis and description.

OK to push with these changes, thank you!

Ludo’.

Message #20 received at 26420 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26420 <at> debbugs.gnu.org
Subject: Re: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Mon, 10 Apr 2017 15:01:14 +0530

>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         ;; tests fail in this release
>> +         (add-before 'install 'check
>> +           (lambda _
>> +             (zero? (system* "emacs" "--batch" "-L" "."
>> +                             "-l" "use-package-tests.el"
>> +                             "-f" "ert-run-tests-batch-and-exit"))
>> +             #t)))))
>
> Please remove #t as it would hide a failure of the “emacs --batch”
> command above.

As noted in the comment, the tests fail in this release. I have put the
#t there to make the package build succeed. In the upstream git
checkout, tests pass. So, in the next release, tests should pass. When
updating the package, the #t should be removed. Is this ok? Shall I
leave the #t there?

> @file{.emacs} in the synopsis and description.

Will do.

Message #23 received at 26420 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26420 <at> debbugs.gnu.org
Subject: Re: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Mon, 10 Apr 2017 14:43:54 +0200

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         ;; tests fail in this release
>>> +         (add-before 'install 'check
>>> +           (lambda _
>>> +             (zero? (system* "emacs" "--batch" "-L" "."
>>> +                             "-l" "use-package-tests.el"
>>> +                             "-f" "ert-run-tests-batch-and-exit"))
>>> +             #t)))))
>>
>> Please remove #t as it would hide a failure of the “emacs --batch”
>> command above.
>
> As noted in the comment, the tests fail in this release. I have put the
> #t there to make the package build succeed. In the upstream git
> checkout, tests pass. So, in the next release, tests should pass. When
> updating the package, the #t should be removed. Is this ok? Shall I
> leave the #t there?

Oh sure.  Maybe move the comment closer to #t and, if you have the
reference of the upstream fix, you can put it there.

Thanks,
Ludo’.

Message #26 received at 26420 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26420 <at> debbugs.gnu.org
Subject: Re: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Tue, 11 Apr 2017 01:11:02 +0530

Pushed with changes!

Message #31 received at 26420-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26420-done <at> debbugs.gnu.org
Subject: Re: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Tue, 11 Apr 2017 01:13:58 +0530

Closing bug...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.