GNU bug report logs - #26341
[PATCH] build: vm: Add missing module.

Previous Next

Package: guix-patches;

Reported by: Mathieu Othacehe <m.othacehe <at> gmail.com>

Date: Sun, 2 Apr 2017 15:03:01 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26341 <at> debbugs.gnu.org
Subject: bug#26341: [PATCH 1/5] build: syscalls: Add reboot.
Date: Mon, 10 Apr 2017 15:18:30 +0200
Hey Ludo,

> The problem is that we cannot #:replace unconditionally (when not using
> the patched Guile, there’s nothing to replace¹).

Yes I was relying on #:replace ability to just export the symbol if
there's nothing to replace (as explained in your note¹).

>
> WDYT?

Anyway, your macro seems a nicer way than dealing with export/replace.
I gave it a try and everything still seems warning free.

My only concern is that it won't be obvious for people who want to use
reboot or mount or any other syscall that they have to use (guix build
syscalls) because the #:export list won't contain those syscalls.

Maybe a big explanation on top of the file would be enough ?

Thanks,

Mathieu




This bug report was last modified 8 years and 44 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.