GNU bug report logs - #2631
get-free-disk-space when home dir also doesn't exist

Previous Next

Package: emacs;

Reported by: Kevin Ryde <user42 <at> zip.com.au>

Date: Tue, 10 Mar 2009 22:30:03 UTC

Severity: normal

Tags: patch

Merged with 3911

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 2631 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Tue, 10 Mar 2009 22:10:13 -0400
> *** files.el	11 Mar 2009 08:46:04 +1100	1.1038
> --- files.el	11 Mar 2009 09:14:14 +1100	
> ***************
> *** 5336,5345 ****
>         (save-match-data
>   	(with-temp-buffer
>   	  (when (and directory-free-space-program
> ! 		     (eq 0 (call-process directory-free-space-program
> ! 					 nil t nil
> ! 					 directory-free-space-args
> ! 					 dir)))
>   	    ;; Usual format is a header line followed by a line of
>   	    ;; numbers.
>   	    (goto-char (point-min))
> --- 5336,5346 ----
>         (save-match-data
>   	(with-temp-buffer
>   	  (when (and directory-free-space-program
> !                      (let ((default-directory "/"))
> !                        (eq 0 (call-process directory-free-space-program
> !                                            nil t nil
> !                                            directory-free-space-args
> !                                            dir))))
>   	    ;; Usual format is a header line followed by a line of
>   	    ;; numbers.
>   	    (goto-char (point-min))

That would probably work OK, but why not bind default-directory to dir?
And even use process-file, while we're at it, so it has a chance to work
on Tramp.


        Stefan






This bug report was last modified 14 years and 84 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.