GNU bug report logs - #26160
[PATCH] gnu: Add deutex.

Previous Next

Full log

Message #8 received at 26160 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26160 <at> debbugs.gnu.org
Subject: Re: bug#26160: [PATCH] gnu: Add deutex.
Date: Sun, 19 Mar 2017 18:39:22 -0400

[Message part 1 (text/plain, inline)]

On Sat, Mar 18, 2017 at 04:24:48PM -0400, Kei Kebreau wrote:
> gnu/packages/game-development.scm (deutex): New variable.

> +        ;; "make install" is broken for this package.

It's helpful to say how it's broken. That will make it easier to know
if `make install` is fixed in future versions of DeuTex.

> +        (replace 'install
> +                 (lambda* (#:key outputs #:allow-other-keys)
> +                   (let* ((out (assoc-ref %outputs "out"))
> +                          (bin (string-append out "/bin"))
> +                          (share (string-append out "/share")))
> +                     (mkdir-p bin)

This procedure is redundant; (install-file) will create the directory.

Otherwise, LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.