GNU bug report logs - #26160
[PATCH] gnu: Add deutex.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26160 in the body.
You can then email your comments to 26160 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: Add deutex.
Date: Sat, 18 Mar 2017 16:24:48 -0400

gnu/packages/game-development.scm (deutex): New variable.
---
 gnu/packages/game-development.scm | 48 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 908ce4834..74cac0be9 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -5,7 +5,7 @@
 ;;; Copyright © 2015 Alex Kost <alezost <at> gmail.com>
 ;;; Copyright © 2015, 2016 David Thompson <davet <at> gnu.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
-;;; Copyright © 2016 Kei Kebreau <kei <at> openmailbox.org>
+;;; Copyright © 2016, 2017 Kei Kebreau <kei <at> openmailbox.org>
 ;;; Copyright © 2016 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2016 Julian Graham <joolean <at> gmail.com>
 ;;;
@@ -95,6 +95,52 @@
 is used in some video games and movies.")
     (license license:zlib)))
 
+(define-public deutex
+  (package
+   (name "deutex")
+   (version "4.4.902")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "https://github.com/Doom-Utils/" name
+                                "/archive/v" version ".tar.gz"))
+            (file-name (string-append name "-" version ".tar.gz"))
+            (sha256
+             (base32
+              "0rwz1yzgd539x4h25kzhar4q02xyxjwfrcpz4m8ixi312a82p7cn"))))
+   (build-system gnu-build-system)
+   (arguments
+    '(#:tests? #f ; no check target
+      #:phases
+      (modify-phases %standard-phases
+        ;; The provided configure script takes a restricted number of arguments.
+        (replace 'configure
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (zero? (system* "./configure" "--prefix"
+                                   (assoc-ref %outputs "out")))))
+        ;; "make install" is broken for this package.
+        (replace 'install
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (let* ((out (assoc-ref %outputs "out"))
+                          (bin (string-append out "/bin"))
+                          (share (string-append out "/share")))
+                     (mkdir-p bin)
+                     (install-file "deusf" bin)
+                     (install-file "deutex" bin)
+                     (install-file "deutex.6" (string-append share "/man/man6")))
+                   #t)))))
+   (home-page "https://github.com/Doom-Utils/deutex")
+   (synopsis "WAD file composer for Doom and related games")
+   (description
+    "DeuTex is a wad composer for Doom, Heretic, Hexen and Strife. It can be
+used to extract the lumps of a wad and save them as individual files.
+Conversely, it can also build a wad from separate files.  When extracting a
+lump to a file, it does not just copy the raw data, it converts it to an
+appropriate format (such as PPM for graphics, Sun audio for samples, etc.).
+Conversely, when it reads files for inclusion in pwads, it does the necessary
+conversions (for example, from PPM to Doom picture format).  In addition,
+DeuTex has functions such as merging wads, etc.")
+   (license license:gpl2+)))
+
 (define-public gzochi
   (package
     (name "gzochi")
-- 
2.12.0

Message #8 received at 26160 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26160 <at> debbugs.gnu.org
Subject: Re: bug#26160: [PATCH] gnu: Add deutex.
Date: Sun, 19 Mar 2017 18:39:22 -0400

[Message part 1 (text/plain, inline)]

On Sat, Mar 18, 2017 at 04:24:48PM -0400, Kei Kebreau wrote:
> gnu/packages/game-development.scm (deutex): New variable.

> +        ;; "make install" is broken for this package.

It's helpful to say how it's broken. That will make it easier to know
if `make install` is fixed in future versions of DeuTex.

> +        (replace 'install
> +                 (lambda* (#:key outputs #:allow-other-keys)
> +                   (let* ((out (assoc-ref %outputs "out"))
> +                          (bin (string-append out "/bin"))
> +                          (share (string-append out "/share")))
> +                     (mkdir-p bin)

This procedure is redundant; (install-file) will create the directory.

Otherwise, LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 26160-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 26160-done <at> debbugs.gnu.org
Subject: Re: bug#26160: [PATCH] gnu: Add deutex.
Date: Sun, 19 Mar 2017 21:48:40 -0400

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Sat, Mar 18, 2017 at 04:24:48PM -0400, Kei Kebreau wrote:
>> gnu/packages/game-development.scm (deutex): New variable.
>
>> +        ;; "make install" is broken for this package.
>
> It's helpful to say how it's broken. That will make it easier to know
> if `make install` is fixed in future versions of DeuTex.
>

A copy of the updated explanation:

"make install" is broken for this package.
Notably, the binaries overrwrite one another upon installation as
they are all installed to the "bin" file in the output directory,
and the manual page fails to install because the directory for the
manual page is not created.

>> +        (replace 'install
>> +                 (lambda* (#:key outputs #:allow-other-keys)
>> +                   (let* ((out (assoc-ref %outputs "out"))
>> +                          (bin (string-append out "/bin"))
>> +                          (share (string-append out "/share")))
>> +                     (mkdir-p bin)
>
> This procedure is redundant; (install-file) will create the directory.
>

Redundant procedure removed.

> Otherwise, LGTM.

Pushed to master as 1a0c4437abbe3a1dd9622cc8a7926b9add74bf79. Thanks for
the review.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.