GNU bug report logs - #26072
[PATCH 35/35] gnu: Add r-seurat.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26072 in the body.
You can then email your comments to 26072 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
To: Raoul Bonnal <ilpuccio.febo <at> gmail.com>, guix-devel <at> gnu.org,
 guix-patches <at> gnu.org
Subject: Re: [PATCH 35/35] gnu: Add r-seurat.
Date: Sun, 12 Mar 2017 21:42:58 +1000

Hi Raoul,

On 20/01/17 04:55, Raoul Bonnal wrote:
> +
> +(define-public r-seurat
> +  (let ((commit "e1eae2da82ada2211e84fbc471615e8d3921b539"))
> +    (package
> +      (name "r-seurat")
> +      (version (string-append "1.4." (string-take commit 7)))
Apologies for the long delay on getting these recipes reviewed. I've 
pushed the rest of them to master now after some minor changes, patch 
reordering and updating, except for this final one.

Seurat seems to have it's last release as v1.4.0, and the usual approach 
would be to package that release. Is there some reason why a specific 
commit was used?

Thanks, ben.

Message #10 received at 26072-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
Cc: guix-devel <at> gnu.org, 26072-done <at> debbugs.gnu.org, ilpuccio.febo <at> gmail.com
Subject: Re: bug#26072: [PATCH 35/35] gnu: Add r-seurat.
Date: Thu, 16 Mar 2017 14:07:39 +0100

> Seurat seems to have it's last release as v1.4.0, and the usual
> approach would be to package that release. Is there some reason why a
> specific commit was used?

The latest version is 1.4.0.12, which appears to be 8 commits after the
commit selected for this patch.  The downloadable archive, however, does
not contain the sources.

The source archive for version 1.4.0 is from Oct 4, 2016.  The selected
commit probably was the latest version at the time.

I’ll add a comment to the top of this package expression and update the
commit to fccb77d, which is equivalent to the binary release 1.4.0.12.

Thanks for the patches, and thank you Ben for the review! 

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #13 received at 26072-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ben Woodcroft <b.woodcroft <at> uq.edu.au>
Cc: guix-devel <at> gnu.org, 26072-done <at> debbugs.gnu.org, ilpuccio.febo <at> gmail.com
Subject: Re: bug#26072: [PATCH 35/35] gnu: Add r-seurat.
Date: Thu, 16 Mar 2017 15:14:18 +0100

Ricardo Wurmus <rekado <at> elephly.net> writes:

> I’ll add a comment to the top of this package expression and update the
> commit to fccb77d, which is equivalent to the binary release 1.4.0.12.

I also deleted the bundled jar and added a build phase to build it from
source.  It’s now in master: 2441c284140ddbd354b61c9d1606af1357f95c1f.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.