GNU bug report logs - #26068
[PATCH] bug in generator function with pcase

Previous Next

Full log

View this message in rfc822 format

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: Mark Oteiza <mvoteiza <at> udel.edu>, 26068 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#26068: [PATCH] bug in generator function with pcase
Date: Sat, 1 Apr 2017 15:44:16 +0200

[Message part 1 (text/plain, inline)]

Attached is the testcase from the bug as a patch. It might be best to
reformulate it without `pcase' though, to avoid depending on its
implementation details.

The testcase fails before the patch, passes now. So, I don't know
anything about `cl-flet', but the patch was not without reasons.

Paul

On 1 April 2017 at 15:08, Tino Calancha <tino.calancha <at> gmail.com> wrote:
> Paul Pogonyshev <pogonyshev <at> gmail.com> writes:
>
>> To reproduce:
>>
>> (iter-next (funcall (iter-lambda () (pcase (list 1 2)
>>                                       (`(,a ,b) (iter-yield (+ a b)))))))
>>
>> Patch is attached. I have no idea if it affects something else, but
>> matching symbols with `eq' on their names (`eq' on strings?!) seems
>> outright wrong to me.
> It looks also weird to me.  It seems written on purpose in order to
> not expand fuction names in `cl-symbol-macrolet'.
>
> Stefan has added a new test 2 days ago which fails after your
> patch:
> * test/lisp/emacs-lisp/cl-lib-tests.el (cl-lib-symbol-macrolet)

[pcase-generator-test.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.