GNU bug report logs - #26069
[PATCH 0/2] Add shellcheck and its dependencies.

Previous Next

Package: guix-patches;

Reported by: Danny Milosavljevic <dannym <at> scratchpost.org>

Date: Sun, 12 Mar 2017 09:03:01 UTC

Severity: normal

Tags: patch

Done: Danny Milosavljevic <dannym <at> scratchpost.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26069 in the body.
You can then email your comments to 26069 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#26069; Package guix-patches. (Sun, 12 Mar 2017 09:03:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 12 Mar 2017 09:03:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH 0/2] Add shellcheck and its dependencies.
Date: Sun, 12 Mar 2017 10:02:31 +0100
Danny Milosavljevic (2):
  gnu: Add ghc-json.
  gnu: Add shellcheck.

 gnu/packages/haskell.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)





Information forwarded to guix-patches <at> gnu.org:
bug#26069; Package guix-patches. (Sun, 12 Mar 2017 09:05:02 GMT) Full text and rfc822 format available.

Message #8 received at 26069 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 26069 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH 1/2] gnu: Add ghc-json.
Date: Sun, 12 Mar 2017 10:04:28 +0100
* gnu/packages/haskell.scm (ghc-json): New variable.
---
 gnu/packages/haskell.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 2415881e8..ce37f63f9 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -8212,4 +8212,31 @@ handler built in.")
 handled safely, this is what you're left with.")
     (license license:isc)))
 
+(define-public ghc-json
+  (package
+    (name "ghc-json")
+    (version "0.9.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://hackage.haskell.org/package/json/"
+                           "json-" version ".tar.gz"))
+       (sha256
+        (base32
+         "18l5027vc68hnnxrxlnyl59vkkg95a92m1zzms0dqiby2r6pxdcn"))))
+    (build-system haskell-build-system)
+    (inputs
+     `(("ghc-syb" ,ghc-syb)
+       ("ghc-mtl" ,ghc-mtl)
+       ("ghc-text" ,ghc-text)
+       ("ghc-parsec" ,ghc-parsec)))
+    (home-page "http://hackage.haskell.org/package/json")
+    (synopsis "Serializes Haskell data to and from JSON")
+    (description "This package provides a parser and pretty printer for
+converting between Haskell values and JSON.
+JSON (JavaScript Object Notation) is a lightweight data-interchange format.
+It is based on a subset of the JavaScript Programming Language, Standard
+ECMA-262 3rd Edition - December 1999.")
+    (license license:bsd-3)))
+
 ;;; haskell.scm ends here




Information forwarded to guix-patches <at> gnu.org:
bug#26069; Package guix-patches. (Sun, 12 Mar 2017 09:05:02 GMT) Full text and rfc822 format available.

Message #11 received at 26069 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 26069 <at> debbugs.gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH 2/2] gnu: Add shellcheck.
Date: Sun, 12 Mar 2017 10:04:29 +0100
* gnu/packages/haskell.scm (shellcheck): New variable.
---
 gnu/packages/haskell.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index ce37f63f9..62bae9d81 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -8239,4 +8239,39 @@ It is based on a subset of the JavaScript Programming Language, Standard
 ECMA-262 3rd Edition - December 1999.")
     (license license:bsd-3)))
 
+(define-public shellcheck
+  (package
+    (name "shellcheck")
+    (version "0.4.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/koalaman/shellcheck/archive/"
+                           "v" version ".tar.gz"))
+       (sha256
+        (base32
+         "14r84fcn28rin339avlvca5g0kz832f01x8dpmwb5ql8mbc4rlxr"))
+       (file-name (string-append name "-" version ".tar.gz"))))
+    (build-system haskell-build-system)
+    (inputs
+     `(("ghc-quickcheck" ,ghc-quickcheck)
+       ("ghc-json" ,ghc-json)
+       ("ghc-mtl" ,ghc-mtl)
+       ("ghc-parsec" ,ghc-parsec)
+       ("ghc-regex-tdfa" ,ghc-regex-tdfa)))
+    (home-page "https://github.com/koalaman/shellcheck")
+    (synopsis "Static analysis for shell scripts")
+    (description "@code{shellcheck} provides static analysis for bash and sh shell
+scripts.  It gives warnings and suggestions in order to:
+
+@enumerate
+@item Point out and clarify typical beginner's syntax issues that cause
+a shell to give cryptic error messages.
+@item Point out and clarify typical intermediate level semantic problems
+that cause a shell to behave strangely and counter-intuitively.
+@item Point out subtle caveats, corner cases and pitfalls that may cause an
+advanced user's otherwise working script to fail under future circumstances.
+@end enumerate")
+    (license license:gpl3+)))
+
 ;;; haskell.scm ends here




Information forwarded to guix-patches <at> gnu.org:
bug#26069; Package guix-patches. (Sun, 12 Mar 2017 17:48:02 GMT) Full text and rfc822 format available.

Message #14 received at 26069 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>, 26069 <at> debbugs.gnu.org
Subject: Re: bug#26069: [PATCH 1/2] gnu: Add ghc-json.
Date: Sun, 12 Mar 2017 18:47:15 +0100
[Message part 1 (text/plain, inline)]
Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> * gnu/packages/haskell.scm (ghc-json): New variable.
> ---
>  gnu/packages/haskell.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 2415881e8..ce37f63f9 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -8212,4 +8212,31 @@ handler built in.")
>  handled safely, this is what you're left with.")
>      (license license:isc)))
>  
> +(define-public ghc-json
> +  (package
> +    (name "ghc-json")
> +    (version "0.9.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://hackage.haskell.org/package/json/"
> +                           "json-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "18l5027vc68hnnxrxlnyl59vkkg95a92m1zzms0dqiby2r6pxdcn"))))
> +    (build-system haskell-build-system)
> +    (inputs
> +     `(("ghc-syb" ,ghc-syb)
> +       ("ghc-mtl" ,ghc-mtl)
> +       ("ghc-text" ,ghc-text)
> +       ("ghc-parsec" ,ghc-parsec)))
> +    (home-page "http://hackage.haskell.org/package/json")
> +    (synopsis "Serializes Haskell data to and from JSON")
> +    (description "This package provides a parser and pretty printer for
> +converting between Haskell values and JSON.
> +JSON (JavaScript Object Notation) is a lightweight data-interchange format.
> +It is based on a subset of the JavaScript Programming Language, Standard
> +ECMA-262 3rd Edition - December 1999.")

The second sentence can be left off IMO. Otherwise LGTM.

> +    (license license:bsd-3)))
> +
>  ;;; haskell.scm ends here
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#26069; Package guix-patches. (Sun, 12 Mar 2017 17:50:02 GMT) Full text and rfc822 format available.

Message #17 received at 26069 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Danny Milosavljevic <dannym <at> scratchpost.org>, 26069 <at> debbugs.gnu.org
Subject: Re: bug#26069: [PATCH 2/2] gnu: Add shellcheck.
Date: Sun, 12 Mar 2017 18:49:11 +0100
[Message part 1 (text/plain, inline)]
Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> * gnu/packages/haskell.scm (shellcheck): New variable.
> ---
>  gnu/packages/haskell.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index ce37f63f9..62bae9d81 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -8239,4 +8239,39 @@ It is based on a subset of the JavaScript Programming Language, Standard
>  ECMA-262 3rd Edition - December 1999.")
>      (license license:bsd-3)))
>  
> +(define-public shellcheck
> +  (package
> +    (name "shellcheck")
> +    (version "0.4.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/koalaman/shellcheck/archive/"
> +                           "v" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "14r84fcn28rin339avlvca5g0kz832f01x8dpmwb5ql8mbc4rlxr"))
> +       (file-name (string-append name "-" version ".tar.gz"))))
> +    (build-system haskell-build-system)
> +    (inputs
> +     `(("ghc-quickcheck" ,ghc-quickcheck)
> +       ("ghc-json" ,ghc-json)
> +       ("ghc-mtl" ,ghc-mtl)
> +       ("ghc-parsec" ,ghc-parsec)
> +       ("ghc-regex-tdfa" ,ghc-regex-tdfa)))
> +    (home-page "https://github.com/koalaman/shellcheck")
> +    (synopsis "Static analysis for shell scripts")
> +    (description "@code{shellcheck} provides static analysis for bash and sh shell

@command{bash} (and sh)

Looks good elsewise, seems like a nice tool! :)

> +scripts.  It gives warnings and suggestions in order to:
> +
> +@enumerate
> +@item Point out and clarify typical beginner's syntax issues that cause
> +a shell to give cryptic error messages.
> +@item Point out and clarify typical intermediate level semantic problems
> +that cause a shell to behave strangely and counter-intuitively.
> +@item Point out subtle caveats, corner cases and pitfalls that may cause an
> +advanced user's otherwise working script to fail under future circumstances.
> +@end enumerate")
> +    (license license:gpl3+)))
> +
>  ;;; haskell.scm ends here
[signature.asc (application/pgp-signature, inline)]

Reply sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
You have taken responsibility. (Sat, 25 Mar 2017 14:04:02 GMT) Full text and rfc822 format available.

Notification sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
bug acknowledged by developer. (Sat, 25 Mar 2017 14:04:02 GMT) Full text and rfc822 format available.

Message #22 received at 26069-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 26069-done <at> debbugs.gnu.org
Subject: Shellcheck pushed to master
Date: Sat, 25 Mar 2017 15:03:28 +0100
Shellcheck pushed to master, commits 6f8016f4d8a84739ffdc7338bb1bbac5179e3ae3 (ghc-json) and 7e58cbbb39ea5efc890c84b9e42144117af0748d (shellcheck).




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 23 Apr 2017 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 110 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.