GNU bug report logs - #26009
libpng-apng

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ng0 <contact.ng0 <at> cryptolab.net>
Subject: bug#26009: closed (Re: bug#26009: libpng-apng)
Date: Thu, 23 Mar 2017 11:34:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#26009: libpng-apng

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26009 <at> debbugs.gnu.org.

-- 
26009: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26009
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 26009-done <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Thu, 23 Mar 2017 11:36:05 +0000

Kei Kebreau transcribed 3.1K bytes:
> ng0 <contact.ng0 <at> cryptolab.net> writes:
> 
> > Kei Kebreau transcribed 1.3K bytes:
> >> ludo <at> gnu.org (Ludovic Courtès) writes:
> >> 
> >> > Good morning!
> >> >
> >> 
> >> Howdy! :-)
> >> 
> >> > Kei Kebreau <kei <at> openmailbox.org> skribis:
> >> >
> >> >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001
> >> >> From: ng0 <ng0 <at> libertad.pw>
> >> >> Date: Tue, 10 Jan 2017 20:49:30 +0000
> >> >> Subject: [PATCH] gnu: Add libpng-apng.
> >> >> To: guix-patches <at> gnu.org
> >> >>
> >> >> * gnu/packages/image.scm (libpng-apng): New variable.
> >> >>
> >> >> Signed-off-by: Kei Kebreau <kei <at> openmailbox.org>
> >> >
> >> > [...]
> >> >
> >> >> +         (add-before 'configure 'no-checks
> >> >> +           (lambda _
> >> >> +             (substitute* "Makefile.in"
> >> >> +               (("^scripts/symbols.chk") "")
> >> >> +               (("check: scripts/symbols.chk") ""))
> >> >> +             (zero? (system* "libtool"))
> >> >> +             #t)))))
> >> >
> >> > Do you really want to run ‘libtool’ here?  I think that doesn’t have any
> >> > effect:
> >> >
> >> > $ libtool
> >> > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]...
> >> > Try 'libtool --help' for more information.
> >> > libtool:   error: you must specify a MODE
> >> >
> >> 
> >> ng0 had some adjustments to make to the patch for sending it upstream,
> >> so I'm waiting for a response. Perhaps removing this libtool execution
> >> is one of them.
> >
> > On the one hand I wanted to check on this, but on the other hand it
> > looks like you have already solved most or all of the problems?
> > I decided to take an almost-vacation for 3 weeks, just plan and document
> > and maybe add some thoughts to patches which are open, minimal work.
> > If it looks good for you and it works, please gp ahead (and add the
> > Co-authored-by line).
> >
> > Thanks for your fixes on this :)
> >
> 
> You're welcome. Thanks to Ludovic as well for pointing out the
> replacement issue.
> 
> >> > If there’s nothing else blocking this patch, I think you can go ahead.
> >> >
> >> > Thanks,
> >> > Ludo’.
> >> 
> >> Thank you. I'll push it when I get the okay from ng0.
> 
> Pushed to master!

Thanks. closed

[Message part 3 (message/rfc822, inline)]

From: ng0 <contact.ng0 <at> cryptolab.net>
To: guix-patches <at> gnu.org
Subject: libpng-apng
Date: Tue, 7 Mar 2017 12:19:31 +0000

[Message part 4 (text/plain, inline)]

This adds `libpng-apng'. I had this in the dependency graph of palemoon,
a webbrowser I stopped to work on because of license/trademark/legal
insecurities.

libpng-apng can be used to unbundle it from icecat. Despite the comment
in gnu/packages/gnuzilla.scm: This is a real, maintained software which
bases on top of libpng and tracks its releases.

When libpng is updated, this package needs to be updated aswell as soon
as the updated release of the patch is out.

I have appended the last version I packaged as a git format-patch file.

In the description the 2 occurences of APGN (Animated Portable Network Graphics)
could be written with the @defn{} of texinfo I think,
and the synopsis could be changed to just "Animated Portable Network
Graphics library". I think back then I just copied upstrema in text.

Should anyone be interested to finish the work on the webbrowser, the
repository with the branch is available at request.

[0001-gnu-Add-libpng-apng.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.