GNU bug report logs - #26009
libpng-apng

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26009 in the body.
You can then email your comments to 26009 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: guix-patches <at> gnu.org
Subject: libpng-apng
Date: Tue, 7 Mar 2017 12:19:31 +0000

[Message part 1 (text/plain, inline)]

This adds `libpng-apng'. I had this in the dependency graph of palemoon,
a webbrowser I stopped to work on because of license/trademark/legal
insecurities.

libpng-apng can be used to unbundle it from icecat. Despite the comment
in gnu/packages/gnuzilla.scm: This is a real, maintained software which
bases on top of libpng and tracks its releases.

When libpng is updated, this package needs to be updated aswell as soon
as the updated release of the patch is out.

I have appended the last version I packaged as a git format-patch file.

In the description the 2 occurences of APGN (Animated Portable Network Graphics)
could be written with the @defn{} of texinfo I think,
and the synopsis could be changed to just "Animated Portable Network
Graphics library". I think back then I just copied upstrema in text.

Should anyone be interested to finish the work on the webbrowser, the
repository with the branch is available at request.

[0001-gnu-Add-libpng-apng.patch (text/plain, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Sun, 12 Mar 2017 22:02:04 -0400

[Message part 1 (text/plain, inline)]

ng0 <contact.ng0 <at> cryptolab.net> writes:

> This adds `libpng-apng'. I had this in the dependency graph of palemoon,
> a webbrowser I stopped to work on because of license/trademark/legal
> insecurities.
>
> libpng-apng can be used to unbundle it from icecat. Despite the comment
> in gnu/packages/gnuzilla.scm: This is a real, maintained software which
> bases on top of libpng and tracks its releases.
>
> When libpng is updated, this package needs to be updated aswell as soon
> as the updated release of the patch is out.
>
> I have appended the last version I packaged as a git format-patch file.
>
> In the description the 2 occurences of APGN (Animated Portable Network Graphics)
> could be written with the @defn{} of texinfo I think,
> and the synopsis could be changed to just "Animated Portable Network
> Graphics library". I think back then I just copied upstrema in text.
>
> Should anyone be interested to finish the work on the webbrowser, the
> repository with the branch is available at request.

For whatever reason, I can't get Guix to recognize libpng-apng as a
package seperate from libpng (i.e. "guix build libpng-apng" returns a
vanilla libpng directory). Do you have any idea why this is?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Mon, 13 Mar 2017 11:04:32 +0000

Kei Kebreau transcribed 2.1K bytes:
> ng0 <contact.ng0 <at> cryptolab.net> writes:
> 
> > This adds `libpng-apng'. I had this in the dependency graph of palemoon,
> > a webbrowser I stopped to work on because of license/trademark/legal
> > insecurities.
> >
> > libpng-apng can be used to unbundle it from icecat. Despite the comment
> > in gnu/packages/gnuzilla.scm: This is a real, maintained software which
> > bases on top of libpng and tracks its releases.
> >
> > When libpng is updated, this package needs to be updated aswell as soon
> > as the updated release of the patch is out.
> >
> > I have appended the last version I packaged as a git format-patch file.
> >
> > In the description the 2 occurences of APGN (Animated Portable Network Graphics)
> > could be written with the @defn{} of texinfo I think,
> > and the synopsis could be changed to just "Animated Portable Network
> > Graphics library". I think back then I just copied upstrema in text.
> >
> > Should anyone be interested to finish the work on the webbrowser, the
> > repository with the branch is available at request.
> 
> For whatever reason, I can't get Guix to recognize libpng-apng as a
> package seperate from libpng (i.e. "guix build libpng-apng" returns a
> vanilla libpng directory). Do you have any idea why this is?

Interesting. For the process of building palemoon it worked.
I'll look into this as soon as I can, thanks for your feedback.

Message #14 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Mon, 13 Mar 2017 14:07:03 +0100

Kei Kebreau <kei <at> openmailbox.org> skribis:

> For whatever reason, I can't get Guix to recognize libpng-apng as a
> package seperate from libpng (i.e. "guix build libpng-apng" returns a
> vanilla libpng directory). Do you have any idea why this is?

This is because libpng in current master has a ‘replacement’ field, and
since libpng-apng inherits from libpng, it also gets that replacement.

The fix is to write:

  (define-public libpng-apng
     (package
       (inherit libpng)
       (replacement #f)   ;libpng’s replacement doesn’t apply here
       …))

That said, please make sure the security issues fixed in ‘libpng/fixed’
are also fixed in libpng-apng!

Thanks,
Ludo’.

Message #17 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26009 <at> debbugs.gnu.org, Kei Kebreau <kei <at> openmailbox.org>
Subject: Re: bug#26009: libpng-apng
Date: Mon, 13 Mar 2017 14:23:59 +0000

Ludovic Courtès transcribed 0.7K bytes:
> Kei Kebreau <kei <at> openmailbox.org> skribis:
> 
> > For whatever reason, I can't get Guix to recognize libpng-apng as a
> > package seperate from libpng (i.e. "guix build libpng-apng" returns a
> > vanilla libpng directory). Do you have any idea why this is?
> 
> This is because libpng in current master has a ‘replacement’ field, and
> since libpng-apng inherits from libpng, it also gets that replacement.
> 
> The fix is to write:
> 
>   (define-public libpng-apng
>      (package
>        (inherit libpng)
>        (replacement #f)   ;libpng’s replacement doesn’t apply here
>        …))

Thanks.

> 
> That said, please make sure the security issues fixed in ‘libpng/fixed’
> are also fixed in libpng-apng!
> 
> Thanks,
> Ludo’.
> 

Do you have any advice how this could be achieved?

Message #20 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Mon, 13 Mar 2017 14:25:23 +0100

ng0 <contact.ng0 <at> cryptolab.net> skribis:

>> That said, please make sure the security issues fixed in ‘libpng/fixed’
>> are also fixed in libpng-apng!

[...]

> Do you have any advice how this could be achieved?

I’d check whether libpng-CVE-2016-10087.patch applies to libpng-apng
(it’s the patch that ‘libpng/fixed’ applies.)

Going forward, if the code bases are similar enough, we may have to add
a (cpe-name . "libpng") property to libpng-apng so that ‘guix lint -c
cve’ would report libpng’s vulnerabilities.

HTH!

Ludo’.

Message #23 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Tue, 14 Mar 2017 13:24:22 -0400

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> ng0 <contact.ng0 <at> cryptolab.net> skribis:
>
>>> That said, please make sure the security issues fixed in ‘libpng/fixed’
>>> are also fixed in libpng-apng!
>
> [...]
>
>> Do you have any advice how this could be achieved?
>
> I’d check whether libpng-CVE-2016-10087.patch applies to libpng-apng
> (it’s the patch that ‘libpng/fixed’ applies.)
>
> Going forward, if the code bases are similar enough, we may have to add
> a (cpe-name . "libpng") property to libpng-apng so that ‘guix lint -c
> cve’ would report libpng’s vulnerabilities.
>
> HTH!
>
> Ludo’.

Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now
the only issues are the CVE patch name not beginning with "libpng-apng"
and the sourceforge URL using "*.sourceforge.net/project" instead of
"*.sourceforge.net/projects" (this detail leads to a 404 Error while linting).

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Tue, 14 Mar 2017 21:08:46 +0100

Kei Kebreau <kei <at> openmailbox.org> skribis:

> Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now
> the only issues are the CVE patch name not beginning with
> "libpng-apng"

You can ignore this warning from ‘guix lint’.

> and the sourceforge URL using "*.sourceforge.net/project" instead of
> "*.sourceforge.net/projects" (this detail leads to a 404 Error while
> linting).

Can’t you change the URL as done in
998ac26a1e4f025ac75147c3497453615bb32d40?

HTH!

Ludo’.

Message #29 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Tue, 14 Mar 2017 19:22:39 -0400

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kei <at> openmailbox.org> skribis:
>
>> Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now
>> the only issues are the CVE patch name not beginning with
>> "libpng-apng"
>
> You can ignore this warning from ‘guix lint’.
>
>> and the sourceforge URL using "*.sourceforge.net/project" instead of
>> "*.sourceforge.net/projects" (this detail leads to a 404 Error while
>> linting).
>
> Can’t you change the URL as done in
> 998ac26a1e4f025ac75147c3497453615bb32d40?

Yes, but libpng is already using a "mirror://sourceforge" URL. Also, the
URL turned out not to be the actual issue. The real issue is that
version 1.6.25 of libpng isn't present at either of the given source
locations. I guess Guix has been using a local copy from my store or a
cache tarball to build libpng-apng from source!

>
> HTH!
>
> Ludo’.

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Wed, 15 Mar 2017 10:46:39 +0000

Kei Kebreau transcribed 1.9K bytes:
> ludo <at> gnu.org (Ludovic Courtès) writes:
> 
> > Kei Kebreau <kei <at> openmailbox.org> skribis:
> >
> >> Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now
> >> the only issues are the CVE patch name not beginning with
> >> "libpng-apng"
> >
> > You can ignore this warning from ‘guix lint’.
> >
> >> and the sourceforge URL using "*.sourceforge.net/project" instead of
> >> "*.sourceforge.net/projects" (this detail leads to a 404 Error while
> >> linting).
> >
> > Can’t you change the URL as done in
> > 998ac26a1e4f025ac75147c3497453615bb32d40?
> 
> Yes, but libpng is already using a "mirror://sourceforge" URL. Also, the
> URL turned out not to be the actual issue. The real issue is that
> version 1.6.25 of libpng isn't present at either of the given source
> locations. I guess Guix has been using a local copy from my store or a
> cache tarball to build libpng-apng from source!

Can you share your additions to my patch? I'd like to apply last fixes
and send a new version.
When I packaged it, mirror:// did not work (or at least I assumed so,
this was the second reason for my mirror addition patch), so I used the
full url.

> >
> > HTH!
> >
> > Ludo’.

Message #35 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Wed, 15 Mar 2017 09:46:57 -0400

[Message part 1 (text/plain, inline)]

ng0 <contact.ng0 <at> cryptolab.net> writes:

> Kei Kebreau transcribed 1.9K bytes:
>> ludo <at> gnu.org (Ludovic Courtès) writes:
>> 
>> > Kei Kebreau <kei <at> openmailbox.org> skribis:
>> >
>> >> Those tips helped quite a bit! Libpng-apng now builds reproducibly. Now
>> >> the only issues are the CVE patch name not beginning with
>> >> "libpng-apng"
>> >
>> > You can ignore this warning from ‘guix lint’.
>> >
>> >> and the sourceforge URL using "*.sourceforge.net/project" instead of
>> >> "*.sourceforge.net/projects" (this detail leads to a 404 Error while
>> >> linting).
>> >
>> > Can’t you change the URL as done in
>> > 998ac26a1e4f025ac75147c3497453615bb32d40?
>> 
>> Yes, but libpng is already using a "mirror://sourceforge" URL. Also, the
>> URL turned out not to be the actual issue. The real issue is that
>> version 1.6.25 of libpng isn't present at either of the given source
>> locations. I guess Guix has been using a local copy from my store or a
>> cache tarball to build libpng-apng from source!
>
> Can you share your additions to my patch? I'd like to apply last fixes
> and send a new version.
> When I packaged it, mirror:// did not work (or at least I assumed so,
> this was the second reason for my mirror addition patch), so I used the
> full url.
>

Sure thing! See the attached file.

>> >
>> > HTH!
>> >
>> > Ludo’.

[0001-gnu-Add-libpng-apng.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #38 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Thu, 16 Mar 2017 09:02:51 +0100

Good morning!

Kei Kebreau <kei <at> openmailbox.org> skribis:

> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> libertad.pw>
> Date: Tue, 10 Jan 2017 20:49:30 +0000
> Subject: [PATCH] gnu: Add libpng-apng.
> To: guix-patches <at> gnu.org
>
> * gnu/packages/image.scm (libpng-apng): New variable.
>
> Signed-off-by: Kei Kebreau <kei <at> openmailbox.org>

[...]

> +         (add-before 'configure 'no-checks
> +           (lambda _
> +             (substitute* "Makefile.in"
> +               (("^scripts/symbols.chk") "")
> +               (("check: scripts/symbols.chk") ""))
> +             (zero? (system* "libtool"))
> +             #t)))))

Do you really want to run ‘libtool’ here?  I think that doesn’t have any
effect:

--8<---------------cut here---------------start------------->8---
$ libtool
Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]...
Try 'libtool --help' for more information.
libtool:   error: you must specify a MODE
--8<---------------cut here---------------end--------------->8---

If there’s nothing else blocking this patch, I think you can go ahead.

Thanks,
Ludo’.

Message #41 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: contact.ng0 <at> cryptolab.net, 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Thu, 16 Mar 2017 14:39:16 -0400

ludo <at> gnu.org (Ludovic Courtès) writes:

> Good morning!
>

Howdy! :-)

> Kei Kebreau <kei <at> openmailbox.org> skribis:
>
>> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0 <at> libertad.pw>
>> Date: Tue, 10 Jan 2017 20:49:30 +0000
>> Subject: [PATCH] gnu: Add libpng-apng.
>> To: guix-patches <at> gnu.org
>>
>> * gnu/packages/image.scm (libpng-apng): New variable.
>>
>> Signed-off-by: Kei Kebreau <kei <at> openmailbox.org>
>
> [...]
>
>> +         (add-before 'configure 'no-checks
>> +           (lambda _
>> +             (substitute* "Makefile.in"
>> +               (("^scripts/symbols.chk") "")
>> +               (("check: scripts/symbols.chk") ""))
>> +             (zero? (system* "libtool"))
>> +             #t)))))
>
> Do you really want to run ‘libtool’ here?  I think that doesn’t have any
> effect:
>
> $ libtool
> Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]...
> Try 'libtool --help' for more information.
> libtool:   error: you must specify a MODE
>

ng0 had some adjustments to make to the patch for sending it upstream,
so I'm waiting for a response. Perhaps removing this libtool execution
is one of them.

> If there’s nothing else blocking this patch, I think you can go ahead.
>
> Thanks,
> Ludo’.

Thank you. I'll push it when I get the okay from ng0.

Message #44 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Thu, 16 Mar 2017 20:58:34 +0000

Kei Kebreau transcribed 1.3K bytes:
> ludo <at> gnu.org (Ludovic Courtès) writes:
> 
> > Good morning!
> >
> 
> Howdy! :-)
> 
> > Kei Kebreau <kei <at> openmailbox.org> skribis:
> >
> >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001
> >> From: ng0 <ng0 <at> libertad.pw>
> >> Date: Tue, 10 Jan 2017 20:49:30 +0000
> >> Subject: [PATCH] gnu: Add libpng-apng.
> >> To: guix-patches <at> gnu.org
> >>
> >> * gnu/packages/image.scm (libpng-apng): New variable.
> >>
> >> Signed-off-by: Kei Kebreau <kei <at> openmailbox.org>
> >
> > [...]
> >
> >> +         (add-before 'configure 'no-checks
> >> +           (lambda _
> >> +             (substitute* "Makefile.in"
> >> +               (("^scripts/symbols.chk") "")
> >> +               (("check: scripts/symbols.chk") ""))
> >> +             (zero? (system* "libtool"))
> >> +             #t)))))
> >
> > Do you really want to run ‘libtool’ here?  I think that doesn’t have any
> > effect:
> >
> > $ libtool
> > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]...
> > Try 'libtool --help' for more information.
> > libtool:   error: you must specify a MODE
> >
> 
> ng0 had some adjustments to make to the patch for sending it upstream,
> so I'm waiting for a response. Perhaps removing this libtool execution
> is one of them.

On the one hand I wanted to check on this, but on the other hand it
looks like you have already solved most or all of the problems?
I decided to take an almost-vacation for 3 weeks, just plan and document
and maybe add some thoughts to patches which are open, minimal work.
If it looks good for you and it works, please gp ahead (and add the
Co-authored-by line).

Thanks for your fixes on this :)

> > If there’s nothing else blocking this patch, I think you can go ahead.
> >
> > Thanks,
> > Ludo’.
> 
> Thank you. I'll push it when I get the okay from ng0.

Message #47 received at 26009 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26009 <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Fri, 17 Mar 2017 11:37:59 -0400

[Message part 1 (text/plain, inline)]

ng0 <contact.ng0 <at> cryptolab.net> writes:

> Kei Kebreau transcribed 1.3K bytes:
>> ludo <at> gnu.org (Ludovic Courtès) writes:
>> 
>> > Good morning!
>> >
>> 
>> Howdy! :-)
>> 
>> > Kei Kebreau <kei <at> openmailbox.org> skribis:
>> >
>> >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001
>> >> From: ng0 <ng0 <at> libertad.pw>
>> >> Date: Tue, 10 Jan 2017 20:49:30 +0000
>> >> Subject: [PATCH] gnu: Add libpng-apng.
>> >> To: guix-patches <at> gnu.org
>> >>
>> >> * gnu/packages/image.scm (libpng-apng): New variable.
>> >>
>> >> Signed-off-by: Kei Kebreau <kei <at> openmailbox.org>
>> >
>> > [...]
>> >
>> >> +         (add-before 'configure 'no-checks
>> >> +           (lambda _
>> >> +             (substitute* "Makefile.in"
>> >> +               (("^scripts/symbols.chk") "")
>> >> +               (("check: scripts/symbols.chk") ""))
>> >> +             (zero? (system* "libtool"))
>> >> +             #t)))))
>> >
>> > Do you really want to run ‘libtool’ here?  I think that doesn’t have any
>> > effect:
>> >
>> > $ libtool
>> > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]...
>> > Try 'libtool --help' for more information.
>> > libtool:   error: you must specify a MODE
>> >
>> 
>> ng0 had some adjustments to make to the patch for sending it upstream,
>> so I'm waiting for a response. Perhaps removing this libtool execution
>> is one of them.
>
> On the one hand I wanted to check on this, but on the other hand it
> looks like you have already solved most or all of the problems?
> I decided to take an almost-vacation for 3 weeks, just plan and document
> and maybe add some thoughts to patches which are open, minimal work.
> If it looks good for you and it works, please gp ahead (and add the
> Co-authored-by line).
>
> Thanks for your fixes on this :)
>

You're welcome. Thanks to Ludovic as well for pointing out the
replacement issue.

>> > If there’s nothing else blocking this patch, I think you can go ahead.
>> >
>> > Thanks,
>> > Ludo’.
>> 
>> Thank you. I'll push it when I get the okay from ng0.

Pushed to master!

[signature.asc (application/pgp-signature, inline)]

Message #52 received at 26009-done <at> debbugs.gnu.org (full text, mbox):

From: ng0 <contact.ng0 <at> cryptolab.net>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 26009-done <at> debbugs.gnu.org
Subject: Re: bug#26009: libpng-apng
Date: Thu, 23 Mar 2017 11:36:05 +0000

Kei Kebreau transcribed 3.1K bytes:
> ng0 <contact.ng0 <at> cryptolab.net> writes:
> 
> > Kei Kebreau transcribed 1.3K bytes:
> >> ludo <at> gnu.org (Ludovic Courtès) writes:
> >> 
> >> > Good morning!
> >> >
> >> 
> >> Howdy! :-)
> >> 
> >> > Kei Kebreau <kei <at> openmailbox.org> skribis:
> >> >
> >> >> From 76e4bec9f8313adc6a78d3ae571ccea489c97848 Mon Sep 17 00:00:00 2001
> >> >> From: ng0 <ng0 <at> libertad.pw>
> >> >> Date: Tue, 10 Jan 2017 20:49:30 +0000
> >> >> Subject: [PATCH] gnu: Add libpng-apng.
> >> >> To: guix-patches <at> gnu.org
> >> >>
> >> >> * gnu/packages/image.scm (libpng-apng): New variable.
> >> >>
> >> >> Signed-off-by: Kei Kebreau <kei <at> openmailbox.org>
> >> >
> >> > [...]
> >> >
> >> >> +         (add-before 'configure 'no-checks
> >> >> +           (lambda _
> >> >> +             (substitute* "Makefile.in"
> >> >> +               (("^scripts/symbols.chk") "")
> >> >> +               (("check: scripts/symbols.chk") ""))
> >> >> +             (zero? (system* "libtool"))
> >> >> +             #t)))))
> >> >
> >> > Do you really want to run ‘libtool’ here?  I think that doesn’t have any
> >> > effect:
> >> >
> >> > $ libtool
> >> > Usage: /home/ludo/.guix-profile/bin/libtool [OPTION]... [MODE-ARG]...
> >> > Try 'libtool --help' for more information.
> >> > libtool:   error: you must specify a MODE
> >> >
> >> 
> >> ng0 had some adjustments to make to the patch for sending it upstream,
> >> so I'm waiting for a response. Perhaps removing this libtool execution
> >> is one of them.
> >
> > On the one hand I wanted to check on this, but on the other hand it
> > looks like you have already solved most or all of the problems?
> > I decided to take an almost-vacation for 3 weeks, just plan and document
> > and maybe add some thoughts to patches which are open, minimal work.
> > If it looks good for you and it works, please gp ahead (and add the
> > Co-authored-by line).
> >
> > Thanks for your fixes on this :)
> >
> 
> You're welcome. Thanks to Ludovic as well for pointing out the
> replacement issue.
> 
> >> > If there’s nothing else blocking this patch, I think you can go ahead.
> >> >
> >> > Thanks,
> >> > Ludo’.
> >> 
> >> Thank you. I'll push it when I get the okay from ng0.
> 
> Pushed to master!

Thanks. closed

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.