GNU bug report logs - #25927
[PATCH] gnu: Add lensfun.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25927 in the body.
You can then email your comments to 25927 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add lensfun.
Date: Thu, 02 Mar 2017 01:01:54 +0100

Dear Guix,

This patch adds another dependency of Darktable.

Kind regards,
Roel Janssen

>From 1fd5a91ac943bce920f829c69623cc96b54003cd Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel <at> gnu.org>
Date: Thu, 2 Mar 2017 00:53:28 +0100
Subject: [PATCH] gnu: Add lensfun.

* gnu/packages/photo.scm (lensfun): New variable.
---
 gnu/packages/photo.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index ce71d2a44..e5209b2bb 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2015 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2015 Andreas Enge <andreas <at> enge.fr>
 ;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
+;;; Copyright © 2017 Roel Janssen <roel <at> gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33,6 +34,7 @@
   #:use-module (gnu packages compression)
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages gl)
+  #:use-module (gnu packages glib) 
   #:use-module (gnu packages graphics)
   #:use-module (gnu packages image)
   #:use-module (gnu packages imagemagick)
@@ -263,3 +265,38 @@ overlapping images, as well as some command line tools.")
 multi-resolution spline.  Enfuse merges different exposures of the same
 scene to produce an image that looks much like a tone-mapped image.")
     (license license:gpl2+)))
+
+(define-public lensfun
+  (package
+    (name "lensfun")
+    (version "0.3.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://sourceforge/lensfun/"
+                    version "/lensfun-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0cfk8jjhs9nbfjfdy98plrj9ayi59aph0nx6ppslgjhlcvacm2xf"))))
+    (build-system cmake-build-system)
+    (arguments `(#:tests? #f)) ; There are no tests to run.
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib" ,glib)))
+    (home-page "https://sourceforge.net/projects/lensfun/")
+    (synopsis "Library to correct optical lens defects with a lens database")
+    (description "Digital photographs are not ideal.  Of course, the better is
+your camera, the better the results will be, but in any case if you look
+carefully at shots taken even by the most expensive cameras equipped with the
+most expensive lenses you will see various artifacts.  It is very hard to make
+ideal cameras, because there are a lot of factors that affect the final image
+quality, and at some point camera and lens designers have to trade one factor
+for another to achieve the optimal image quality, within the given design
+restrictions and budget.  But we all want ideal shots, don't we?  So that's
+what's Lensfun is all about: rectifying the defects introduced by your
+photographic equipment.")
+    ;; The libraries are licensed under the LGPL3, the programs are
+    ;; licensed GPL3, and the database is license CC-BY-SA 3.0.  See the
+    ;; README.md file for this clarification.
+    (license (list license:lgpl3 license:gpl3 license:cc-by-sa3.0))))
-- 
2.11.0

Message #8 received at 25927 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 25927 <at> debbugs.gnu.org
Subject: Re: bug#25927: [PATCH] gnu: Add lensfun.
Date: Wed, 08 Mar 2017 14:48:53 +0100

Hi Roel,

Roel Janssen <roel <at> gnu.org> skribis:

>>>From 1fd5a91ac943bce920f829c69623cc96b54003cd Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Thu, 2 Mar 2017 00:53:28 +0100
> Subject: [PATCH] gnu: Add lensfun.
>
> * gnu/packages/photo.scm (lensfun): New variable.

[...]

> +    ;; The libraries are licensed under the LGPL3, the programs are
> +    ;; licensed GPL3, and the database is license CC-BY-SA 3.0.  See the
> +    ;; README.md file for this clarification.
> +    (license (list license:lgpl3 license:gpl3 license:cc-by-sa3.0))))

Please double-check whether it’s version-3-only or
version-3-or-any-later-version.

Otherwise LGTM, thanks!

Ludo’.

Message #11 received at 25927 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 25927 <at> debbugs.gnu.org
Subject: Re: bug#25927: [PATCH] gnu: Add lensfun.
Date: Wed, 08 Mar 2017 23:50:55 +0100

Ludovic Courtès writes:

> Hi Roel,
>
> Roel Janssen <roel <at> gnu.org> skribis:
>
>>>>From 1fd5a91ac943bce920f829c69623cc96b54003cd Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Thu, 2 Mar 2017 00:53:28 +0100
>> Subject: [PATCH] gnu: Add lensfun.
>>
>> * gnu/packages/photo.scm (lensfun): New variable.
>
> [...]
>
>> +    ;; The libraries are licensed under the LGPL3, the programs are
>> +    ;; licensed GPL3, and the database is license CC-BY-SA 3.0.  See the
>> +    ;; README.md file for this clarification.
>> +    (license (list license:lgpl3 license:gpl3 license:cc-by-sa3.0))))
>
> Please double-check whether it’s version-3-only or
> version-3-or-any-later-version.
>
> Otherwise LGTM, thanks!
>
> Ludo’.

I double checked the licenses and they clearly state LGPL version 3, GPL
version 3 and CC-BY-SA.  I cannot interpreter that as "or later".

I pushed it.  How do I close this ticket?

Kind regards,
Roel Janssen

Message #16 received at 25927-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Roel Janssen <roel <at> gnu.org>
Cc: 25927-done <at> debbugs.gnu.org
Subject: Re: bug#25927: [PATCH] gnu: Add lensfun.
Date: Wed, 8 Mar 2017 18:24:26 -0500

On Wed, Mar 08, 2017 at 11:50:55PM +0100, Roel Janssen wrote:
> I pushed it.  How do I close this ticket?

You can close bugs on debbugs by sending a message to
<NNN-done <at> debbugs.gnu.org>, where NNN is the number of the bug.

Message #19 received at 25927-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 25927-done <at> debbugs.gnu.org
Subject: Re: bug#25927: [PATCH] gnu: Add lensfun.
Date: Thu, 09 Mar 2017 11:49:59 +0100

Roel Janssen <roel <at> gnu.org> skribis:

> Ludovic Courtès writes:
>
>> Hi Roel,
>>
>> Roel Janssen <roel <at> gnu.org> skribis:
>>
>>>>>From 1fd5a91ac943bce920f829c69623cc96b54003cd Mon Sep 17 00:00:00 2001
>>> From: Roel Janssen <roel <at> gnu.org>
>>> Date: Thu, 2 Mar 2017 00:53:28 +0100
>>> Subject: [PATCH] gnu: Add lensfun.
>>>
>>> * gnu/packages/photo.scm (lensfun): New variable.
>>
>> [...]
>>
>>> +    ;; The libraries are licensed under the LGPL3, the programs are
>>> +    ;; licensed GPL3, and the database is license CC-BY-SA 3.0.  See the
>>> +    ;; README.md file for this clarification.
>>> +    (license (list license:lgpl3 license:gpl3 license:cc-by-sa3.0))))
>>
>> Please double-check whether it’s version-3-only or
>> version-3-or-any-later-version.
>>
>> Otherwise LGTM, thanks!
>>
>> Ludo’.
>
> I double checked the licenses and they clearly state LGPL version 3, GPL
> version 3 and CC-BY-SA.  I cannot interpreter that as "or later".

So file headers explicitly have the license text without the “or any
later version” wording, right?  (Remember that “or any later version” is
the default in the absence of explicit version specifications.)

> I pushed it.  How do I close this ticket?

Just email 25927-done, like this.  :-)

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.