GNU bug report logs - #25926
[PATCH] gnu: pugixml: Build relocatable library.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25926 in the body.
You can then email your comments to 25926 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: pugixml: Build relocatable library.
Date: Thu, 02 Mar 2017 01:00:35 +0100

Dear Guix,

This patch modifies the recipe for pugixml to build a relocatable
library.  This fixes a compilation issue with Darktable.

Kind regards,
Roel Janssen

>From 559b2c399f63beafe2d930cf75a71b7d575443cd Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel <at> gnu.org>
Date: Thu, 2 Mar 2017 00:44:36 +0100
Subject: [PATCH] gnu: pugixml: Build relocatable library.

* gnu/packages/xml.scm (pugixml): Add "-shared -fPIC" to ensure
  the library is relocatable.
---
 gnu/packages/xml.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index b91471690..30f49a8bd 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -752,7 +752,9 @@ the form of functions.")
         "0fcgggry5x5bn0zhb09ij9hb0p45nb0sv0d9fw3cm1cf62hp9n80"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #f))                    ; no tests
+     `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-shared -fPIC"
+                           "-DCMAKE_C_FLAGS=-shared -fPIC")
+       #:tests? #f))                    ; no tests
     (home-page "http://pugixml.org")
     (synopsis "Light-weight, simple and fast XML parser for C++ with XPath support")
     (description
-- 
2.11.0

Message #8 received at 25926 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Roel Janssen <roel <at> gnu.org>
Cc: 25926 <at> debbugs.gnu.org
Subject: Re: bug#25926: [PATCH] gnu: pugixml: Build relocatable library.
Date: Sat, 04 Mar 2017 17:26:07 -0500

[Message part 1 (text/plain, inline)]

Roel Janssen <roel <at> gnu.org> writes:

> Dear Guix,
>
> This patch modifies the recipe for pugixml to build a relocatable
> library.  This fixes a compilation issue with Darktable.
>
> Kind regards,
> Roel Janssen
>
>>>From 559b2c399f63beafe2d930cf75a71b7d575443cd Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Thu, 2 Mar 2017 00:44:36 +0100
> Subject: [PATCH] gnu: pugixml: Build relocatable library.
>
> * gnu/packages/xml.scm (pugixml): Add "-shared -fPIC" to ensure
>   the library is relocatable.
> ---
>  gnu/packages/xml.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index b91471690..30f49a8bd 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -752,7 +752,9 @@ the form of functions.")
>          "0fcgggry5x5bn0zhb09ij9hb0p45nb0sv0d9fw3cm1cf62hp9n80"))))
>      (build-system cmake-build-system)
>      (arguments
> -     `(#:tests? #f))                    ; no tests
> +     `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-shared -fPIC"
> +                           "-DCMAKE_C_FLAGS=-shared -fPIC")
> +       #:tests? #f))                    ; no tests
>      (home-page "http://pugixml.org")
>      (synopsis "Light-weight, simple and fast XML parser for C++ with XPath support")
>      (description

LGTM. Pushed to master as 52c14bb6ec6fbd532b1e03a512d133e2499186b9.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 25926 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Kei Kebreau <kei <at> openmailbox.org>, 25926-done <at> debbugs.gnu.org
Cc: Roel Janssen <roel <at> gnu.org>, 25926 <at> debbugs.gnu.org
Subject: Re: bug#25926: [PATCH] gnu: pugixml: Build relocatable library.
Date: Sun, 5 Mar 2017 00:03:20 +0100

[Message part 1 (text/plain, inline)]

2017-03-04 23:26 GMT+01:00 Kei Kebreau <kei <at> openmailbox.org>:

> Roel Janssen <roel <at> gnu.org> writes:
>
> > Dear Guix,
> >
> > This patch modifies the recipe for pugixml to build a relocatable
> > library.  This fixes a compilation issue with Darktable.
> >
> > Kind regards,
> > Roel Janssen
> >
> >>>From 559b2c399f63beafe2d930cf75a71b7d575443cd Mon Sep 17 00:00:00 2001
> > From: Roel Janssen <roel <at> gnu.org>
> > Date: Thu, 2 Mar 2017 00:44:36 +0100
> > Subject: [PATCH] gnu: pugixml: Build relocatable library.
> >
> > * gnu/packages/xml.scm (pugixml): Add "-shared -fPIC" to ensure
> >   the library is relocatable.
> > ---
> >  gnu/packages/xml.scm | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> > index b91471690..30f49a8bd 100644
> > --- a/gnu/packages/xml.scm
> > +++ b/gnu/packages/xml.scm
> > @@ -752,7 +752,9 @@ the form of functions.")
> >          "0fcgggry5x5bn0zhb09ij9hb0p45nb0sv0d9fw3cm1cf62hp9n80"))))
> >      (build-system cmake-build-system)
> >      (arguments
> > -     `(#:tests? #f))                    ; no tests
> > +     `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-shared -fPIC"
> > +                           "-DCMAKE_C_FLAGS=-shared -fPIC")
> > +       #:tests? #f))                    ; no tests
> >      (home-page "http://pugixml.org")
> >      (synopsis "Light-weight, simple and fast XML parser for C++ with
> XPath support")
> >      (description
>
> LGTM. Pushed to master as 52c14bb6ec6fbd532b1e03a512d133e2499186b9.
>


so this is done too, right ?

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.