GNU bug report logs - #25923
pkgsrc patches: improve mkostemp support

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Thomas Klausner <tk <at> giga.or.at>
Subject: bug#25923: closed (Re: bug#25923: pkgsrc patches: improve
 mkostemp support)
Date: Tue, 14 Mar 2017 11:33:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#25923: pkgsrc patches: improve mkostemp support

which was filed against the guile package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 25923 <at> debbugs.gnu.org.

-- 
25923: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25923
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andy Wingo <wingo <at> pobox.com>
To: Thomas Klausner <tk <at> giga.or.at>
Cc: 25923-done <at> debbugs.gnu.org, Greg Troxel <gdt <at> lexort.com>
Subject: Re: bug#25923: pkgsrc patches: improve mkostemp support
Date: Tue, 14 Mar 2017 12:32:02 +0100

On Wed 01 Mar 2017 21:29, Thomas Klausner <tk <at> giga.or.at> writes:

> --- libguile/filesys.c.orig	2016-12-15 00:03:33.000000000 +0000
> +++ libguile/filesys.c
> @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1
>        mode_bits = scm_i_mode_bits (mode);
>      }
>  
> +#ifdef __APPLE__
> +  /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */
> +  open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC;
> +#endif
> +#ifdef __NetBSD__
> +  /* Restrict to list of flags documented in man page. */
> +  open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC;
> +#endif
> +
>    SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags));
>    if (rv == -1)
>      SCM_SYSERROR;

I believe this was fixed in 2.1.6 as well so you can drop this one too.

Cheers,

Andy

[Message part 3 (message/rfc822, inline)]

From: Thomas Klausner <tk <at> giga.or.at>
To: bug-guile <at> gnu.org
Cc: Greg Troxel <gdt <at> lexort.com>
Subject: pkgsrc patches: improve mkostemp support
Date: Wed, 1 Mar 2017 21:29:26 +0100

[Message part 4 (text/plain, inline)]

And the final pkgsrc patch tries to use only the flags for mkostemp
that are supported on the operating system, in particular for Darwin
and NetBSD.

Please merge this one as well.

Thanks,
 Thomas

[patch-libguile_filesys.c (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.