GNU bug report logs - #25923
pkgsrc patches: improve mkostemp support

Previous Next

Package: guile;

Reported by: Thomas Klausner <tk <at> giga.or.at>

Date: Wed, 1 Mar 2017 20:30:02 UTC

Severity: normal

Done: Andy Wingo <wingo <at> pobox.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25923 in the body.
You can then email your comments to 25923 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guile <at> gnu.org:
bug#25923; Package guile. (Wed, 01 Mar 2017 20:30:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Thomas Klausner <tk <at> giga.or.at>:
New bug report received and forwarded. Copy sent to bug-guile <at> gnu.org. (Wed, 01 Mar 2017 20:30:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Klausner <tk <at> giga.or.at>
To: bug-guile <at> gnu.org
Cc: Greg Troxel <gdt <at> lexort.com>
Subject: pkgsrc patches: improve mkostemp support
Date: Wed, 1 Mar 2017 21:29:26 +0100

[Message part 1 (text/plain, inline)]
And the final pkgsrc patch tries to use only the flags for mkostemp
that are supported on the operating system, in particular for Darwin
and NetBSD.

Please merge this one as well.

Thanks,
 Thomas

[patch-libguile_filesys.c (text/plain, attachment)]
Reply sent to Andy Wingo <wingo <at> pobox.com>:
You have taken responsibility. (Tue, 14 Mar 2017 11:33:02 GMT) Full text and rfc822 format available.
Notification sent to Thomas Klausner <tk <at> giga.or.at>:
bug acknowledged by developer. (Tue, 14 Mar 2017 11:33:02 GMT) Full text and rfc822 format available.

Message #10 received at 25923-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: Thomas Klausner <tk <at> giga.or.at>
Cc: 25923-done <at> debbugs.gnu.org, Greg Troxel <gdt <at> lexort.com>
Subject: Re: bug#25923: pkgsrc patches: improve mkostemp support
Date: Tue, 14 Mar 2017 12:32:02 +0100

On Wed 01 Mar 2017 21:29, Thomas Klausner <tk <at> giga.or.at> writes:

> --- libguile/filesys.c.orig	2016-12-15 00:03:33.000000000 +0000
> +++ libguile/filesys.c
> @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1
>        mode_bits = scm_i_mode_bits (mode);
>      }
>  
> +#ifdef __APPLE__
> +  /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */
> +  open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC;
> +#endif
> +#ifdef __NetBSD__
> +  /* Restrict to list of flags documented in man page. */
> +  open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC;
> +#endif
> +
>    SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags));
>    if (rv == -1)
>      SCM_SYSERROR;

I believe this was fixed in 2.1.6 as well so you can drop this one too.

Cheers,

Andy
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 12 Apr 2017 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 131 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.