GNU bug report logs - #25918
[PATCH 1/3] gnu: Add libmesode.

Previous Next

Full log

Message #8 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mekeor Melire <mekeor.melire <at> gmail.com>
Cc: 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Thu, 02 Mar 2017 10:13:51 +0100

Hi Mekeor,

thanks for the patch!

This is almost ready to push, and I could make the needed changes
myself, but maybe you’d like to handle them yourself.

>>From aff05409f65025c007d7a50f5d4e90b301ce3b18 Mon Sep 17 00:00:00 2001
> From: Mekeor Melire <mekeor.melire <at> gmail.com>
> Date: Wed, 1 Mar 2017 20:08:04 +0100
> Subject: [PATCH 1/3] gnu: Add libmesode.
>
> * gnu/packages/messaging.scm (libmesode): New variable.
> ---

[…]

> +(define-public libmesode
> +  (package
> +    (name "libmesode")
> +    (version "0.9.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/boothj5/libmesode/archive/"
> +                                  version ".tar.gz")

Please add a “file-name” expression here to give the archive a proper
name in the store.  We do this for all tarballs that don’t include the
name of the package.

> +              (sha256
> +               (base32
> +                "0iaj56fkd5bjvqpvq3324ni895rmbj1akbfqipjydnghfwaym4z6"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda _
> +             (zero? (system* "./bootstrap.sh")))))))
> +    (inputs
> +     `(("expat" ,expat)
> +       ("openssl" ,openssl)))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "A simple, lightweight C library for writing XMPP
> clients")

Please remove the “A” from the beginning.  (I think “guix lint” also
complains about it.)

> +    (description "Libmesode is a fork of libstrophe for use with Profanity
> +XMPP Client. In particular, libmesode provides extra TLS functionality such as
> +manual SSL certificate verification.")

Please separate sentences with two spaces.

> +    (home-page "https://github.com/boothj5/libmesode")
> +    (license (list license:gpl3+ license:x11))))

Please add a comment that explains what this list means.

Could you send an updated patch as a response to this email please?

~~ Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.