GNU bug report logs - #25918
[PATCH 1/3] gnu: Add libmesode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25918 in the body.
You can then email your comments to 25918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mekeor Melire <mekeor.melire <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/3] gnu: Add libmesode.
Date: Wed, 01 Mar 2017 20:23:52 +0100

From aff05409f65025c007d7a50f5d4e90b301ce3b18 Mon Sep 17 00:00:00 2001
From: Mekeor Melire <mekeor.melire <at> gmail.com>
Date: Wed, 1 Mar 2017 20:08:04 +0100
Subject: [PATCH 1/3] gnu: Add libmesode.

* gnu/packages/messaging.scm (libmesode): New variable.
---
 gnu/packages/messaging.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 0ffc031c8..b3d988be7 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2016, 2017 <contact.ng0 <at> cryptolab.net>
 ;;; Copyright © 2016 Andy Patterson <ajpatter <at> uwaterloo.ca>
 ;;; Copyright © 2016, 2017 Clément Lassieur <clement <at> lassieur.org>
+;;; Copyright © 2017 Mekeor Melire <mekeor.melire <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1222,4 +1223,37 @@ is also scriptable and extensible via Guile.")
     (home-page "https://www.gnu.org/software/freetalk")
     (license license:gpl3+)))
 
+(define-public libmesode
+  (package
+    (name "libmesode")
+    (version "0.9.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/boothj5/libmesode/archive/"
+                                  version ".tar.gz")
+              (sha256
+               (base32
+                "0iaj56fkd5bjvqpvq3324ni895rmbj1akbfqipjydnghfwaym4z6"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'bootstrap
+           (lambda _
+             (zero? (system* "./bootstrap.sh")))))))
+    (inputs
+     `(("expat" ,expat)
+       ("openssl" ,openssl)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("pkg-config" ,pkg-config)))
+    (synopsis "A simple, lightweight C library for writing XMPP clients")
+    (description "Libmesode is a fork of libstrophe for use with Profanity
+XMPP Client. In particular, libmesode provides extra TLS functionality such as
+manual SSL certificate verification.")
+    (home-page "https://github.com/boothj5/libmesode")
+    (license (list license:gpl3+ license:x11))))
+
 ;;; messaging.scm ends here
-- 
2.11.0

Message #8 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mekeor Melire <mekeor.melire <at> gmail.com>
Cc: 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Thu, 02 Mar 2017 10:13:51 +0100

Hi Mekeor,

thanks for the patch!

This is almost ready to push, and I could make the needed changes
myself, but maybe you’d like to handle them yourself.

>>From aff05409f65025c007d7a50f5d4e90b301ce3b18 Mon Sep 17 00:00:00 2001
> From: Mekeor Melire <mekeor.melire <at> gmail.com>
> Date: Wed, 1 Mar 2017 20:08:04 +0100
> Subject: [PATCH 1/3] gnu: Add libmesode.
>
> * gnu/packages/messaging.scm (libmesode): New variable.
> ---

[…]

> +(define-public libmesode
> +  (package
> +    (name "libmesode")
> +    (version "0.9.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/boothj5/libmesode/archive/"
> +                                  version ".tar.gz")

Please add a “file-name” expression here to give the archive a proper
name in the store.  We do this for all tarballs that don’t include the
name of the package.

> +              (sha256
> +               (base32
> +                "0iaj56fkd5bjvqpvq3324ni895rmbj1akbfqipjydnghfwaym4z6"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda _
> +             (zero? (system* "./bootstrap.sh")))))))
> +    (inputs
> +     `(("expat" ,expat)
> +       ("openssl" ,openssl)))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "A simple, lightweight C library for writing XMPP
> clients")

Please remove the “A” from the beginning.  (I think “guix lint” also
complains about it.)

> +    (description "Libmesode is a fork of libstrophe for use with Profanity
> +XMPP Client. In particular, libmesode provides extra TLS functionality such as
> +manual SSL certificate verification.")

Please separate sentences with two spaces.

> +    (home-page "https://github.com/boothj5/libmesode")
> +    (license (list license:gpl3+ license:x11))))

Please add a comment that explains what this list means.

Could you send an updated patch as a response to this email please?

~~ Ricardo

Message #11 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Mekeor Melire <mekeor.melire <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Mekeor Melire <mekeor.melire <at> gmail.com>, 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Thu, 02 Mar 2017 23:46:26 +0100

[0001-gnu-Add-libmesode.patch (text/plain, attachment)]

[0002-gnu-Add-libstrophe.patch (text/plain, attachment)]

[0003-gnu-Add-profanity.patch (text/plain, attachment)]

[Message part 4 (text/plain, inline)]

Hi Guix,
hi Ricardo.


Ricardo Wurmus <rekado <at> elephly.net> writes:

> This is almost ready to push, and I could make the needed changes
> myself, but maybe you’d like to handle them yourself.

Sure. :)

> Please add a “file-name” expression here to give the archive a proper
> name in the store.  We do this for all tarballs that don’t include the
> name of the package.

Done.

> Please remove the “A” from the beginning.  (I think “guix lint” also
> complains about it.)

Done. It's unfortunate that “guix lint” doesn't have a “-f” option so
that I could do “guix lint -f gnu/packages/messaging.scm” or so.

(My packaging work-flow is quite uncomfortable. I'm packaging in an my
custom GUIX_PACKAGE_PATH; and then I copy the snippets into my local
guix-repo. I wonder how your workflow looks like.)

> Please separate sentences with two spaces.

Done.

> Please add a comment that explains what this list means.

Done.

> Could you send an updated patch as a response to this email please?

Doing so.

I hope it's fine for you that I'm *attaching* the patches instead of
putting them *inline* because there are three separate patches. (I hope
the attachments reach you because I'm still unconversant with my new
mail client (mu4e).)

Was it a good idea to separate the patches, actually?


--
luv
mekeor

EDD3 DFFA 76F6 11C0 145F 9A99 AC85 BAD8 A2F8 C868

Message #14 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mekeor Melire <mekeor.melire <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Thu, 2 Mar 2017 18:03:01 -0500

On Thu, Mar 02, 2017 at 11:46:26PM +0100, Mekeor Melire wrote:
> (My packaging work-flow is quite uncomfortable. I'm packaging in an my
> custom GUIX_PACKAGE_PATH; and then I copy the snippets into my local
> guix-repo. I wonder how your workflow looks like.)

Why not do the work directly in a branch of your clone of the Guix git
repo?

Message #17 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mekeor Melire <mekeor.melire <at> gmail.com>
Cc: 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Fri, 03 Mar 2017 00:11:03 +0100

Mekeor Melire <mekeor.melire <at> gmail.com> writes:

> Done. It's unfortunate that “guix lint” doesn't have a “-f” option so
> that I could do “guix lint -f gnu/packages/messaging.scm” or so.
>
> (My packaging work-flow is quite uncomfortable. I'm packaging in an my
> custom GUIX_PACKAGE_PATH; and then I copy the snippets into my local
> guix-repo. I wonder how your workflow looks like.)

Like Leo I recommend that you work on a git checkout of Guix instead of
using GUIX_PACKAGE_PATH.  The latter is for users of packages that
probably won’t end up in Guix.  It’s not suited for development.

> I hope it's fine for you that I'm *attaching* the patches instead of
> putting them *inline* because there are three separate patches. (I hope
> the attachments reach you because I'm still unconversant with my new
> mail client (mu4e).)

I’m using mu4e as well.  Attaching the patches is fine (looks like you
attached them twice: inline and as an attachment).

> Was it a good idea to separate the patches, actually?

You can send them in separate emails.  Many of us use git send-email (in
this case we would instruct “git send-email” to reply to this thread),
which can be a little tricky to set up.

I’m going to take a look at your patches tomorrow.

~~ Ricardo

Message #20 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Mekeor Melire <mekeor.melire <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Mekeor Melire <mekeor.melire <at> gmail.com>, 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Fri, 03 Mar 2017 00:58:19 +0100

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Like Leo I recommend that you work on a git checkout of Guix instead of
> using GUIX_PACKAGE_PATH.  The latter is for users of packages that
> probably won’t end up in Guix.  It’s not suited for development.

Ah, and then you use `guix package -f gnu/packages/messaging.scm` to
test the package definition, right? I see, that's cool.

> You can send them in separate emails.  Many of us use git send-email (in
> this case we would instruct “git send-email” to reply to this thread),
> which can be a little tricky to set up.

(AFAICT, there is no `git-send-mail` package for Guix but I wouldn't use
it anyway.)

--
mekeor ~ EDD3 DFFA 76F6 11C0 145F 9A99 AC85 BAD8 A2F8 C868

Message #23 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Mekeor Melire <mekeor.melire <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Fri, 3 Mar 2017 01:36:54 +0100

[Message part 1 (text/plain, inline)]

2017-03-03 0:58 GMT+01:00 Mekeor Melire <mekeor.melire <at> gmail.com>:

>
> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
> > Like Leo I recommend that you work on a git checkout of Guix instead of
> > using GUIX_PACKAGE_PATH.  The latter is for users of packages that
> > probably won’t end up in Guix.  It’s not suited for development.
>
> Ah, and then you use `guix package -f gnu/packages/messaging.scm` to
> test the package definition, right? I see, that's cool.
>

Maybe ;-)

Say you have edited gnu/packages/messaging.scm and you added "my-package"
Then you would do

./pre-inst-env guix build my-package
./pre-inst-env guix lint my-package

you can even install it

./pre-inst-env guix package -i my-package



>
> > You can send them in separate emails.  Many of us use git send-email (in
> > this case we would instruct “git send-email” to reply to this thread),
> > which can be a little tricky to set up.
>
> (AFAICT, there is no `git-send-mail` package for Guix but I wouldn't use
> it anyway.)
>

It's not a standalone package, it's one of the outputs of the git package.

You can see it with this
guix package --list-available | grep send-email

Right, Ricardo ?

[Message part 2 (text/html, inline)]

Message #26 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Mekeor Melire <mekeor.melire <at> gmail.com>
To: Catonano <catonano <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>,
 Mekeor Melire <mekeor.melire <at> gmail.com>, 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Fri, 03 Mar 2017 01:52:03 +0100

Catonano <catonano <at> gmail.com> writes:

> 2017-03-03 0:58 GMT+01:00 Mekeor Melire <mekeor.melire <at> gmail.com>:
>
>> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
> Say you have edited gnu/packages/messaging.scm and you added "my-package"
> Then you would do
>
> ./pre-inst-env guix build my-package
> ./pre-inst-env guix lint my-package
>
> you can even install it
>
> ./pre-inst-env guix package -i my-package

Beautiful. Thank you.

>> > You can send them in separate emails.  Many of us use git send-email (in
>> > this case we would instruct “git send-email” to reply to this thread),
>> > which can be a little tricky to set up.
>>
>> (AFAICT, there is no `git-send-mail` package for Guix but I wouldn't use
>> it anyway.)
>
> It's not a standalone package, it's one of the outputs of the git package.

Well, I've got git installed but `git send-email` doesn't work:

  $ LANG=en_US git send-email
  git: 'send-email' is not a git command. See 'git --help'.

But in fact, I get an completion for `git send-email` in my shell, ZSH.
Maybe it doesn't work because I didn't configure it? I don't think so
because `git help send-email` doesn't work either, for me.

-- 
mekeor ~ EDD3 DFFA 76F6 11C0 145F 9A99 AC85 BAD8 A2F8 C868

Message #29 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Mekeor Melire <mekeor.melire <at> gmail.com>, Catonano <catonano <at> gmail.com>
Cc: 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Fri, 03 Mar 2017 02:05:20 +0100

[Message part 1 (text/plain, inline)]

Mekeor Melire <mekeor.melire <at> gmail.com> writes:

>>> > You can send them in separate emails.  Many of us use git send-email (in
>>> > this case we would instruct “git send-email” to reply to this thread),
>>> > which can be a little tricky to set up.
>>>
>>> (AFAICT, there is no `git-send-mail` package for Guix but I wouldn't use
>>> it anyway.)
>>
>> It's not a standalone package, it's one of the outputs of the git package.
>
> Well, I've got git installed but `git send-email` doesn't work:
>
>   $ LANG=en_US git send-email
>   git: 'send-email' is not a git command. See 'git --help'.
>
> But in fact, I get an completion for `git send-email` in my shell, ZSH.
> Maybe it doesn't work because I didn't configure it? I don't think so
> because `git help send-email` doesn't work either, for me.

As Catonano mentions, it's a separate output of the "git" package. See
available outputs with `guix package -s '^git$'`.

It can be installed with `guix package -i git:send-email`.

HTH!

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Mekeor Melire <mekeor.melire <at> gmail.com>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Tue, 14 Mar 2017 13:38:29 +0100

[Message part 1 (text/plain, inline)]

Mekeor,

sorry for the delay  in reviewing this patch. I'm afraid Ricardo forgot
this. Patches are becoming to many and reviewers are not increasing that
much, as far as I understand

But that's no problem, we can start reviewing on our own ;-)

2017-03-01 20:23 GMT+01:00 Mekeor Melire <mekeor.melire <at> gmail.com>:

>
> +(define-public libmesode
> +  (package
> +    (name "libmesode")
>
+    (version "0.9.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/boothj5/
> libmesode/archive/"
> +                                  version ".tar.gz")
>

I think there is a missing closing paren at the end of the "uri" field
descriptor.


> +              (sha256
> +               (base32
> +                "0iaj56fkd5bjvqpvq3324ni895rmbj
> 1akbfqipjydnghfwaym4z6"))))
>

Here, you could use a line like this
                      (file-name (string-append name "-" version
"-checkout"))

Otherwise the linter complains that this is missing. Like this

gnu/packages/messaging.scm:1230:12: libmesode <at> 0.9.1: the source file name
should contain the package name



> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda _
> +             (zero? (system* "./bootstrap.sh")))))))
> +    (inputs
> +     `(("expat" ,expat)
> +       ("openssl" ,openssl)))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("pkg-config" ,pkg-config)))
> +    (synopsis "A simple, lightweight C library for writing XMPP clients")
>

The linter complains that a synopsis shouldn't start with an article. Like
this

gnu/packages/messaging.scm:1252:14: libmesode <at> 0.9.1: no article allowed at
the beginning of the synopsis



> +    (description "Libmesode is a fork of libstrophe for use with Profanity
> +XMPP Client. In particular, libmesode provides extra TLS functionality
> such as
>

The linter complains that there should be 2 spaces after the dot. Like this

gnu/packages/messaging.scm:1253:17: libmesode <at> 0.9.1: sentences in
description should be followed by two spaces; possible infraction at 68


> +manual SSL certificate verification.")
> +    (home-page "https://github.com/boothj5/libmesode")
> +    (license (list license:gpl3+ license:x11))))
>


Further, guix size reports this

/gnu/store/50zvxq72sxcnx8vy7h4wijbfyixyhr0f-libmesode-0.9.1
67.8     0.3   0.4%
/gnu/store/liib5wid6rx9rkss78spc7wcqzwb1g2k-openssl-1.0.2j
66.9     5.9   8.8%
/gnu/store/ppk2n4xi6pzgchcfzl2p48yj7y4jvnjv-expat-2.2.0
61.6     0.6   0.9%
/gnu/store/cdi08kw7r6r684w8mk0xq0dkgpjhfpmd-gcc-4.9.4-lib           61.0
22.7  33.5%
/gnu/store/iwgi9001dmmihrjg4rqhd6pa6788prjw-glibc-2.24              38.3
36.8  54.3%
/gnu/store/rvgmixpmsq5lqr9qflhkm70kg7a4rys2-bash-static-4.4.0
1.4     1.4   2.1%

I'm ok with all these lines but the last one: bash static. I don't know
what libmesode does, but does a library need bash ?

I'd like other reviewers to chime in, here

Also I couldn't check whether the build is deteministic because I have
already built it and calling "build --rounds=2" again won't reiterate the
build process.
Please, help

There might be more observations, keep in mind that I'm not an expert
reviewer.

In the meantime I suggest you to take a look at the manual page about
submitting patches. That's where I took the bulleted list of checks and
suggestions that I made here.
So the next time you can do it yourself !
It's here
https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html#Submitting-Patches

Thanks for working on this !
Ciao

[Message part 2 (text/html, inline)]

Message #35 received at 25918 <at> debbugs.gnu.org (full text, mbox):

From: Catonano <catonano <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Mekeor Melire <mekeor.melire <at> gmail.com>, 25918 <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Tue, 14 Mar 2017 14:07:27 +0100

[Message part 1 (text/plain, inline)]

2017-03-02 10:13 GMT+01:00 Ricardo Wurmus <rekado <at> elephly.net>:

>
> Hi Mekeor,
>
> thanks for the patch!
>
> This is almost ready to push, and I could make the needed changes
> myself, but maybe you’d like to handle them yourself.
>

Oh gosh

this had been reviewed already :-/


>
> >>From aff05409f65025c007d7a50f5d4e90b301ce3b18 Mon Sep 17 00:00:00 2001
> > From: Mekeor Melire <mekeor.melire <at> gmail.com>
> > Date: Wed, 1 Mar 2017 20:08:04 +0100
> > Subject: [PATCH 1/3] gnu: Add libmesode.
> >
> > * gnu/packages/messaging.scm (libmesode): New variable.
> > ---
>
> […]
>
> > +(define-public libmesode
> > +  (package
> > +    (name "libmesode")
> > +    (version "0.9.1")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "https://github.com/boothj5/
> libmesode/archive/"
> > +                                  version ".tar.gz")
>
> Please add a “file-name” expression here to give the archive a proper
> name in the store.  We do this for all tarballs that don’t include the
> name of the package.
>
> > +              (sha256
> > +               (base32
> > +                "0iaj56fkd5bjvqpvq3324ni895rmbj
> 1akbfqipjydnghfwaym4z6"))))
> > +    (build-system gnu-build-system)
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (add-before 'configure 'bootstrap
> > +           (lambda _
> > +             (zero? (system* "./bootstrap.sh")))))))
> > +    (inputs
> > +     `(("expat" ,expat)
> > +       ("openssl" ,openssl)))
> > +    (native-inputs
> > +     `(("autoconf" ,autoconf)
> > +       ("automake" ,automake)
> > +       ("libtool" ,libtool)
> > +       ("pkg-config" ,pkg-config)))
> > +    (synopsis "A simple, lightweight C library for writing XMPP
> > clients")
>
> Please remove the “A” from the beginning.  (I think “guix lint” also
> complains about it.)
>
>

[Message part 2 (text/html, inline)]

Message #40 received at 25918-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Mekeor Melire <mekeor.melire <at> gmail.com>
Cc: 25918-done <at> debbugs.gnu.org
Subject: Re: bug#25918: [PATCH 1/3] gnu: Add libmesode.
Date: Wed, 15 Mar 2017 17:27:42 -0400

[Message part 1 (text/plain, inline)]

On Thu, Mar 02, 2017 at 11:46:26PM +0100, Mekeor Melire wrote:
> From f413c7ed74e30d73d9fe17f3b8cd3ef86842e22c Mon Sep 17 00:00:00 2001
> From: Mekeor Melire <mekeor.melire <at> gmail.com>
> Date: Thu, 2 Mar 2017 23:30:18 +0100
> Subject: [PATCH 1/3] gnu: Add libmesode.
> 
> * gnu/packages/messaging.scm (libmesode): New variable.

> From af0bcb551ca9a7b03df9442d2e6bf9c7a6d78b21 Mon Sep 17 00:00:00 2001
> From: Mekeor Melire <mekeor.melire <at> gmail.com>
> Date: Thu, 2 Mar 2017 23:31:09 +0100
> Subject: [PATCH 2/3] gnu: Add libstrophe.
> 
> * gnu/packages/messaging.scm (libstrophe): New variable.

> From 90a0cac4263416b01a66f2464208d09d444208f1 Mon Sep 17 00:00:00 2001
> From: Mekeor Melire <mekeor.melire <at> gmail.com>
> Date: Thu, 2 Mar 2017 23:31:50 +0100
> Subject: [PATCH 3/3] gnu: Add profanity.
> 
> * gnu/packages/messaging.scm (profanity): New variable.

Thanks! Pushed with minor edits to synopses, and I also used the package
version to construct profanity's source URL.

Sorry for the delay — I think we got side-tracked by discussion of our
development workflows :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.