GNU bug report logs - #25908
[PATCH, WIP] Add godot.

Previous Next

Full log

Message #17 received at 25908 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Christopher Allan Webber <cwebber <at> dustycloud.org>, 25908 <at> debbugs.gnu.org
Subject: Re: bug#25908: [PATCH, WIP] Add godot.
Date: Sat, 25 Mar 2017 13:28:38 -0400

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Kei,
>
> Kei Kebreau <kei <at> openmailbox.org> skribis:
>
>> Ah, the crucial clue! I replaced the above regexp with the following:
>>
>> (substitute* "SConstruct"
>>   (("env_base = Environment\\(tools=custom_tools\\)")
>>    "env_base = Environment(ENV=os.environ)"))
>>
>> Though I don't know what the meaning of "tools=custom_tools" is, this
>> substitution let me complete the build phase without an issue.
>
> In doubt, I’d keep “tools=custom_tools” in addition to
> “ENV=os.environ”.  :-)
>

Okay. I figured out how this works and kept both.

>> Just two other things:
>>
>> Throughout the build I saw "-Ithirdparty/glew" as a CFLAG. Is this
>> necessary for a successful build or can we use our own copy of glew?
>
> Maybe you could (delete-file-recursively "thirdparty") from the snippet
> to be sure.
>

It seems like these libraries will be quite difficult to unbundle. The
build system has targets that depend on files specifically found in the
"thirdparty" directory.

>> Is there a check target for this build system? If not we can just leave
>> a #:tests? #f with a note in the arguments section.
>
> AFAIK SCons does not standardize anything when it comes to running
> tests.  I think ‘scons --help’ lists all the supported targets, so you
> could check if there’s a “test” target or something like that.
>

There doesn't seem to be tests in the Godot's build system.

> HTH!
>
> Ludo’.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.