GNU bug report logs - #25854
26.0.50; tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ken Brown <kbrown <at> cornell.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#25854: closed (26.0.50; tramp-test19-directory-files-and-attributes
 fails on 32-bit Cygwin)
Date: Sat, 25 Feb 2017 15:20:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 25 Feb 2017 10:19:05 -0500
with message-id <5c8b0a42-e9f7-2163-b2e3-305eeeb6022b <at> cornell.edu>
and subject line Re: bug#25854: 26.0.50; tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin
has caused the debbugs.gnu.org bug report #25854,
regarding 26.0.50; tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
25854: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25854
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; tramp-test19-directory-files-and-attributes fails on 32-bit
 Cygwin
Date: Thu, 23 Feb 2017 18:19:50 -0500

Starting with commit 3a6df2d,
tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin.  The
reason is that inode numbers tend to be very large, on the order of
10^17, at least on my systems.  As a result, the "convert inode" code in
tramp-convert-file-attributes always falls back to tramp-get-inode.
Since this increments by 1 on every call, the file-attribute comparisons
in tramp-test19-directory-files-and-attributes always fail.

The significance of commit 3a6df2d is that it makes
tramp-get-remote-stat return a non-nil value, so that tramp uses 'stat'
for file attributes; this returns the true (large) inode number.  Prior
to that commit, tramp-get-remote-stat would always return nil, so that
the tramp-perl-file-attributes script would be used for file
attributes.  This script uses whatever inode number is returned by
Perl's version of 'stat', which is presumably some sort of 32-bit
truncation of the true inode number.

Although I'm seeing this on 32-bit Cygwin, it seems to me that it could
in principle happen on any 32-bit platform.

Ken




In GNU Emacs 26.0.50 (build 11, i686-pc-cygwin, GTK+ Version 3.18.9)
 of 2017-02-23 built on desktop-new
Repository revision: 16efea3a883ebf633946ee9b9d0681eb55437878
Windowing system distributor 'The Cygwin/X Project', version 11.0.11901000

[Message part 3 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 25854-done <at> debbugs.gnu.org
Subject: Re: bug#25854: 26.0.50; tramp-test19-directory-files-and-attributes
 fails on 32-bit Cygwin
Date: Sat, 25 Feb 2017 10:19:05 -0500

On 2/25/2017 9:05 AM, Michael Albinus wrote:
> I've pushed a patch to master, which should fix this. Could you, pls, check?

That fixes it.  Thanks.

I'm closing the bug.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.