GNU bug report logs - #25854
26.0.50; tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25854 in the body.
You can then email your comments to 25854 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; tramp-test19-directory-files-and-attributes fails on 32-bit
 Cygwin
Date: Thu, 23 Feb 2017 18:19:50 -0500

Starting with commit 3a6df2d,
tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin.  The
reason is that inode numbers tend to be very large, on the order of
10^17, at least on my systems.  As a result, the "convert inode" code in
tramp-convert-file-attributes always falls back to tramp-get-inode.
Since this increments by 1 on every call, the file-attribute comparisons
in tramp-test19-directory-files-and-attributes always fail.

The significance of commit 3a6df2d is that it makes
tramp-get-remote-stat return a non-nil value, so that tramp uses 'stat'
for file attributes; this returns the true (large) inode number.  Prior
to that commit, tramp-get-remote-stat would always return nil, so that
the tramp-perl-file-attributes script would be used for file
attributes.  This script uses whatever inode number is returned by
Perl's version of 'stat', which is presumably some sort of 32-bit
truncation of the true inode number.

Although I'm seeing this on 32-bit Cygwin, it seems to me that it could
in principle happen on any 32-bit platform.

Ken




In GNU Emacs 26.0.50 (build 11, i686-pc-cygwin, GTK+ Version 3.18.9)
 of 2017-02-23 built on desktop-new
Repository revision: 16efea3a883ebf633946ee9b9d0681eb55437878
Windowing system distributor 'The Cygwin/X Project', version 11.0.11901000

Message #8 received at 25854 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 25854 <at> debbugs.gnu.org
Subject: Re: bug#25854: 26.0.50;
 tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin
Date: Fri, 24 Feb 2017 09:55:33 +0200

> From: Ken Brown <kbrown <at> cornell.edu>
> Date: Thu, 23 Feb 2017 18:19:50 -0500
> 
> Starting with commit 3a6df2d,
> tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin.  The
> reason is that inode numbers tend to be very large, on the order of
> 10^17, at least on my systems.  As a result, the "convert inode" code in
> tramp-convert-file-attributes always falls back to tramp-get-inode.
> Since this increments by 1 on every call, the file-attribute comparisons
> in tramp-test19-directory-files-and-attributes always fail.
> 
> The significance of commit 3a6df2d is that it makes
> tramp-get-remote-stat return a non-nil value, so that tramp uses 'stat'
> for file attributes; this returns the true (large) inode number.  Prior
> to that commit, tramp-get-remote-stat would always return nil, so that
> the tramp-perl-file-attributes script would be used for file
> attributes.  This script uses whatever inode number is returned by
> Perl's version of 'stat', which is presumably some sort of 32-bit
> truncation of the true inode number.
> 
> Although I'm seeing this on 32-bit Cygwin, it seems to me that it could
> in principle happen on any 32-bit platform.

Would it work to convert the large inode values to a float?

Message #11 received at 25854 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: kbrown <at> cornell.edu, Michael Albinus <michael.albinus <at> gmx.de>
Cc: 25854 <at> debbugs.gnu.org
Subject: Re: bug#25854: 26.0.50;
 tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin
Date: Fri, 24 Feb 2017 09:59:23 +0200

> Date: Fri, 24 Feb 2017 09:55:33 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 25854 <at> debbugs.gnu.org
> 
> Would it work to convert the large inode values to a float?

Sorry, this would be sub-optimal.  Instead, how about using the same
format as file-attributes uses for large inode numbers?  Michael?

Message #14 received at 25854 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25854 <at> debbugs.gnu.org, kbrown <at> cornell.edu
Subject: Re: bug#25854: 26.0.50;
 tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin
Date: Fri, 24 Feb 2017 15:04:27 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> Sorry, this would be sub-optimal.  Instead, how about using the same
> format as file-attributes uses for large inode numbers?  Michael?

Tramp does something like this already, in
`tramp-do-file-attributes-with-ls'.

Ken, could you pls set `tramp-verbose' to 6, and rerun the test? With
the debug buffer as example, I will try to implement something similar
for your case.

Best regards, Michael.

Message #17 received at 25854 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 25854 <at> debbugs.gnu.org
Subject: Re: bug#25854: 26.0.50; tramp-test19-directory-files-and-attributes
 fails on 32-bit Cygwin
Date: Fri, 24 Feb 2017 09:49:09 -0500

[Message part 1 (text/plain, inline)]

On 2/24/2017 9:04 AM, Michael Albinus wrote:
> Ken, could you pls set `tramp-verbose' to 6, and rerun the test? With
> the debug buffer as example, I will try to implement something similar
> for your case.

Message log attached.

Ken

[test19.debug.xz (application/octet-stream, attachment)]

Message #20 received at 25854 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 25854 <at> debbugs.gnu.org
Subject: Re: bug#25854: 26.0.50; tramp-test19-directory-files-and-attributes
 fails on 32-bit Cygwin
Date: Fri, 24 Feb 2017 10:45:57 -0500

[Message part 1 (text/plain, inline)]

On 2/24/2017 9:49 AM, Ken Brown wrote:
> On 2/24/2017 9:04 AM, Michael Albinus wrote:
>> Ken, could you pls set `tramp-verbose' to 6, and rerun the test? With
>> the debug buffer as example, I will try to implement something similar
>> for your case.
>
> Message log attached.

Sorry, I sent the ert messages rather than the debug buffer.  Here's the 
latter.

Ken

[test19.debug_buffer.xz (application/octet-stream, attachment)]

Message #23 received at 25854 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 25854 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#25854: 26.0.50;
 tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin
Date: Fri, 24 Feb 2017 17:02:40 +0100

Ken Brown <kbrown <at> cornell.edu> writes:

Hi Ken,

>> Message log attached.
>
> Sorry, I sent the ert messages rather than the debug buffer.  Here's
> the latter.

Thanks for both. I have sufficient data now; I'll look into this over
the weekend.

> Ken

Best regards, Michael.

Message #26 received at 25854 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 25854 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#25854: 26.0.50;
 tramp-test19-directory-files-and-attributes fails on 32-bit Cygwin
Date: Sat, 25 Feb 2017 15:05:36 +0100

Ken Brown <kbrown <at> cornell.edu> writes:

Hi Ken,

>>> Ken, could you pls set `tramp-verbose' to 6, and rerun the test? With
>>> the debug buffer as example, I will try to implement something similar
>>> for your case.
>>
>> Message log attached.
>
> Sorry, I sent the ert messages rather than the debug buffer.  Here's
> the latter.

I've pushed a patch to master, which should fix this. Could you, pls, check?

> Ken

Best regards, Michael.

Message #31 received at 25854-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 25854-done <at> debbugs.gnu.org
Subject: Re: bug#25854: 26.0.50; tramp-test19-directory-files-and-attributes
 fails on 32-bit Cygwin
Date: Sat, 25 Feb 2017 10:19:05 -0500

On 2/25/2017 9:05 AM, Michael Albinus wrote:
> I've pushed a patch to master, which should fix this. Could you, pls, check?

That fixes it.  Thanks.

I'm closing the bug.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.