GNU bug report logs - #25839
26.0.50; Bug in gnus-registry-article-marks-to-chars

Previous Next

Full log

Message #19 received at control <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 25839 <at> debbugs.gnu.org
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 22:18:02 -0500

[Message part 1 (text/plain, inline)]

tags 25839 patch
quit

Forwarding message to list.

[Message part 2 (message/rfc822, inline)]

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 17:28:24 -0800

[Message part 3 (text/plain, inline)]

On 02/22/17 13:53 PM, Noam Postavsky wrote:
> On Wed, Feb 22, 2017 at 1:34 PM, Eric Abrahamsen
> <eric <at> ericabrahamsen.net> wrote:
>>
>> On 02/22/17 13:16 PM, Noam Postavsky wrote:
>>> On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen
>>> <eric <at> ericabrahamsen.net> wrote:
>>>>
>>>> The current implementation of gnus-registry-article-marks-to-chars
>>>> errors out because it tries to use mapconcat on a list of characters.
>>>> I've attached a patch that extracts the characters first and then uses
>>>> the mapconcat with char-to-string.
>>>>
>>>
>>>> +    (mapconcat #'char-to-string mark-chars "")))
>>>
>>> AFAIK, this should be the same as (apply #'string mark-chars).
>>
>> Good point! Let me stare at this a bit longer, and post another patch.
>>
>
> Or actually even simpler: (concat mark-chars)

Very nice! Here's another one.

[0001-Don-t-use-mapconcat-with-chars-in-gnus-registry-mark.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.