GNU bug report logs - #25839
26.0.50; Bug in gnus-registry-article-marks-to-chars

Previous Next

Package: emacs;

Reported by: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Date: Wed, 22 Feb 2017 17:24:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 26.0.50

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25839 in the body.
You can then email your comments to 25839 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25839; Package emacs. (Wed, 22 Feb 2017 17:24:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 22 Feb 2017 17:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 09:23:16 -0800

[Message part 1 (text/plain, inline)]
The current implementation of gnus-registry-article-marks-to-chars
errors out because it tries to use mapconcat on a list of characters.
I've attached a patch that extracts the characters first and then uses
the mapconcat with char-to-string.
[0001-Use-char-to-string-in-gnus-registry-article-marks-to.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]

In GNU Emacs 26.0.50 (build 28, x86_64-unknown-linux-gnu, GTK+ Version 3.22.8)
 of 2017-02-19 built on clem
Repository revision: c8d14cfc6c2d19077d137c7e917fbb4f104de222
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25839; Package emacs. (Wed, 22 Feb 2017 18:17:01 GMT) Full text and rfc822 format available.

Message #8 received at 25839 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 25839 <at> debbugs.gnu.org
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 13:16:10 -0500

On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen
<eric <at> ericabrahamsen.net> wrote:
>
> The current implementation of gnus-registry-article-marks-to-chars
> errors out because it tries to use mapconcat on a list of characters.
> I've attached a patch that extracts the characters first and then uses
> the mapconcat with char-to-string.
>

> +    (mapconcat #'char-to-string mark-chars "")))

AFAIK, this should be the same as (apply #'string mark-chars).
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25839; Package emacs. (Wed, 22 Feb 2017 18:35:01 GMT) Full text and rfc822 format available.

Message #11 received at 25839 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 25839 <at> debbugs.gnu.org
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 10:34:03 -0800

On 02/22/17 13:16 PM, Noam Postavsky wrote:
> On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen
> <eric <at> ericabrahamsen.net> wrote:
>>
>> The current implementation of gnus-registry-article-marks-to-chars
>> errors out because it tries to use mapconcat on a list of characters.
>> I've attached a patch that extracts the characters first and then uses
>> the mapconcat with char-to-string.
>>
>
>> +    (mapconcat #'char-to-string mark-chars "")))
>
> AFAIK, this should be the same as (apply #'string mark-chars).

Good point! Let me stare at this a bit longer, and post another patch.

E
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25839; Package emacs. (Wed, 22 Feb 2017 18:54:01 GMT) Full text and rfc822 format available.

Message #14 received at 25839 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 25839 <at> debbugs.gnu.org
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 13:53:29 -0500

On Wed, Feb 22, 2017 at 1:34 PM, Eric Abrahamsen
<eric <at> ericabrahamsen.net> wrote:
>
> On 02/22/17 13:16 PM, Noam Postavsky wrote:
>> On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen
>> <eric <at> ericabrahamsen.net> wrote:
>>>
>>> The current implementation of gnus-registry-article-marks-to-chars
>>> errors out because it tries to use mapconcat on a list of characters.
>>> I've attached a patch that extracts the characters first and then uses
>>> the mapconcat with char-to-string.
>>>
>>
>>> +    (mapconcat #'char-to-string mark-chars "")))
>>
>> AFAIK, this should be the same as (apply #'string mark-chars).
>
> Good point! Let me stare at this a bit longer, and post another patch.
>

Or actually even simpler: (concat mark-chars)
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25839; Package emacs. (Thu, 23 Feb 2017 03:17:02 GMT) Full text and rfc822 format available.

Message #17 received at 25839 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 25839 <at> debbugs.gnu.org
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 22:18:02 -0500

[Message part 1 (text/plain, inline)]
tags 25839 patch
quit

Forwarding message to list.


[Message part 2 (message/rfc822, inline)]
From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Wed, 22 Feb 2017 17:28:24 -0800

[Message part 3 (text/plain, inline)]
On 02/22/17 13:53 PM, Noam Postavsky wrote:
> On Wed, Feb 22, 2017 at 1:34 PM, Eric Abrahamsen
> <eric <at> ericabrahamsen.net> wrote:
>>
>> On 02/22/17 13:16 PM, Noam Postavsky wrote:
>>> On Wed, Feb 22, 2017 at 12:23 PM, Eric Abrahamsen
>>> <eric <at> ericabrahamsen.net> wrote:
>>>>
>>>> The current implementation of gnus-registry-article-marks-to-chars
>>>> errors out because it tries to use mapconcat on a list of characters.
>>>> I've attached a patch that extracts the characters first and then uses
>>>> the mapconcat with char-to-string.
>>>>
>>>
>>>> +    (mapconcat #'char-to-string mark-chars "")))
>>>
>>> AFAIK, this should be the same as (apply #'string mark-chars).
>>
>> Good point! Let me stare at this a bit longer, and post another patch.
>>
>
> Or actually even simpler: (concat mark-chars)

Very nice! Here's another one.


[0001-Don-t-use-mapconcat-with-chars-in-gnus-registry-mark.patch (text/x-diff, attachment)]
Added tag(s) patch. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Thu, 23 Feb 2017 03:17:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25839; Package emacs. (Wed, 01 Mar 2017 03:01:02 GMT) Full text and rfc822 format available.

Message #22 received at 25839 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 25839 <at> debbugs.gnu.org
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Tue, 28 Feb 2017 22:01:24 -0500

tags 25839 fixed
close 25839 26.1
quit

> From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
> Date: Wed, 22 Feb 2017 17:26:11 -0800
> Subject: [PATCH] Don't use mapconcat with chars in gnus registry marks

Pushed to master [1: 16e304f38e].

1: 2017-02-28 21:57:07 -0500 16e304f38e57a9a31f1468ba6ebcb8a71efd253d
  Don't use mapconcat with chars in gnus registry marks (Bug#25839)
Added tag(s) fixed. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Wed, 01 Mar 2017 03:01:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 26.1, send any further explanations to 25839 <at> debbugs.gnu.org and Eric Abrahamsen <eric <at> ericabrahamsen.net> Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Wed, 01 Mar 2017 03:01:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25839; Package emacs. (Tue, 14 Mar 2017 19:26:02 GMT) Full text and rfc822 format available.

Message #29 received at 25839 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: npostavs <at> users.sourceforge.net
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 25839 <at> debbugs.gnu.org
Subject: Re: bug#25839: 26.0.50; Bug in gnus-registry-article-marks-to-chars
Date: Tue, 14 Mar 2017 15:25:22 -0400

On Tue, 28 Feb 2017 22:01:24 -0500 npostavs <at> users.sourceforge.net wrote: 

n> tags 25839 fixed
n> close 25839 26.1
n> quit

>> From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
>> Date: Wed, 22 Feb 2017 17:26:11 -0800
>> Subject: [PATCH] Don't use mapconcat with chars in gnus registry marks

n> Pushed to master [1: 16e304f38e].

n> 1: 2017-02-28 21:57:07 -0500 16e304f38e57a9a31f1468ba6ebcb8a71efd253d
n>   Don't use mapconcat with chars in gnus registry marks (Bug#25839)

That's so much better :) Thanks!

Ted
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 12 Apr 2017 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 121 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.