GNU bug report logs -
#25723
[PATCH] gnu: Add python-cycler.
Previous Next
Reported by: Marius Bakke <mbakke <at> fastmail.com>
Date: Tue, 14 Feb 2017 14:41:02 UTC
Severity: normal
Tags: patch
Done: Marius Bakke <mbakke <at> fastmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#25723: [PATCH] gnu: Add python-cycler.
which was filed against the guix-patches package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 25723 <at> debbugs.gnu.org.
--
25723: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25723
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
[Message part 3 (text/plain, inline)]
Hi Ricardo,
Thanks a lot for the feedback!
Ricardo Wurmus <rekado <at> elephly.net> writes:
>> + (propagated-inputs
>> + `(("python-six" ,python-six)))
>
> Is python-six really required at runtime? Since you offer a variant for
> Python 2, should python-six only be used with one of these variants?
python-six is imported unconditionally by cycler.py. I believe this is
common practice, and the "six" class offers compatibility "both ways",
not just e.g. 2->3.
>> + (home-page "http://matplotlib.org/cycler/")
>> + (synopsis "Composable kwarg iterator")
>
> I assume that “kwarg” is a generally known term in Python, but maybe it
> is not. Could this be replaced with “keyword argument”?
Yes, that is better, thanks!
>
>> + (description
>> + "When using @code{matplotlib} and plotting more than one line, it is
>> +common to want to be able to cycle over one or more artist styles; but the
>> +plotting logic can quickly become involved.
>> +
>> +To address this and enable easy cycling over arbitrary @code{kwargs}, the
>> +@code{Cycler} class was developed.")
>
> I would remove the empty line.
>
>> + (license license:bsd-3)))
>> +
>> +(define-public python2-cycler
>> + (package-with-python2 python-cycler))
>> +
>
> See question above about python-six.
> Other than that it looks good to me. Thank you!
Committed with these changes, thank you!
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
This is required for recent versions of matplotlib.
* gnu/packages/python.scm (python-cycler, python2-cycler): New variables.
---
gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 22a4c590b..5ebca3b6a 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3601,6 +3601,37 @@ transcendental functions).")
(define-public python2-numexpr
(package-with-python2 python-numexpr))
+(define-public python-cycler
+ (package
+ (name "python-cycler")
+ (version "0.10.0")
+ (source (origin
+ (method url-fetch)
+ (uri (pypi-uri "cycler" version))
+ (sha256
+ (base32
+ "1n69n23fak1gjxlrbhqisi2b9pv3ckrfj98llx3p53953082syyd"))))
+ (build-system python-build-system)
+ (arguments
+ ;; XXX: The current version requires 'coveralls' which we don't have.
+ ;; Enable this for the next release which uses 'python-pytest'.
+ '(#:tests? #f))
+ (propagated-inputs
+ `(("python-six" ,python-six)))
+ (home-page "http://matplotlib.org/cycler/")
+ (synopsis "Composable kwarg iterator")
+ (description
+ "When using @code{matplotlib} and plotting more than one line, it is
+common to want to be able to cycle over one or more artist styles; but the
+plotting logic can quickly become involved.
+
+To address this and enable easy cycling over arbitrary @code{kwargs}, the
+@code{Cycler} class was developed.")
+ (license license:bsd-3)))
+
+(define-public python2-cycler
+ (package-with-python2 python-cycler))
+
(define-public python-matplotlib
(package
(name "python-matplotlib")
--
2.11.1
This bug report was last modified 8 years and 95 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.