GNU bug report logs - #25723
[PATCH] gnu: Add python-cycler.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25723 in the body.
You can then email your comments to 25723 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: [PATCH] gnu: Add python-cycler.
Date: Tue, 14 Feb 2017 15:39:19 +0100

This is required for recent versions of matplotlib.

* gnu/packages/python.scm (python-cycler, python2-cycler): New variables.
---
 gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 22a4c590b..5ebca3b6a 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3601,6 +3601,37 @@ transcendental functions).")
 (define-public python2-numexpr
   (package-with-python2 python-numexpr))
 
+(define-public python-cycler
+  (package
+    (name "python-cycler")
+    (version "0.10.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "cycler" version))
+              (sha256
+               (base32
+                "1n69n23fak1gjxlrbhqisi2b9pv3ckrfj98llx3p53953082syyd"))))
+    (build-system python-build-system)
+    (arguments
+     ;; XXX: The current version requires 'coveralls' which we don't have.
+     ;; Enable this for the next release which uses 'python-pytest'.
+     '(#:tests? #f))
+    (propagated-inputs
+     `(("python-six" ,python-six)))
+    (home-page "http://matplotlib.org/cycler/")
+    (synopsis "Composable kwarg iterator")
+    (description
+     "When using @code{matplotlib} and plotting more than one line, it is
+common to want to be able to cycle over one or more artist styles; but the
+plotting logic can quickly become involved.
+
+To address this and enable easy cycling over arbitrary @code{kwargs}, the
+@code{Cycler} class was developed.")
+    (license license:bsd-3)))
+
+(define-public python2-cycler
+  (package-with-python2 python-cycler))
+
 (define-public python-matplotlib
   (package
     (name "python-matplotlib")
-- 
2.11.1

Message #8 received at 25723 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 25723 <at> debbugs.gnu.org
Subject: Re: bug#25723: [PATCH] gnu: Add python-cycler.
Date: Fri, 17 Feb 2017 18:38:43 +0100

Marius Bakke <mbakke <at> fastmail.com> writes:

> This is required for recent versions of matplotlib.
>
> * gnu/packages/python.scm (python-cycler, python2-cycler): New variables.
> ---
>  gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 22a4c590b..5ebca3b6a 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3601,6 +3601,37 @@ transcendental functions).")
>  (define-public python2-numexpr
>    (package-with-python2 python-numexpr))
>
> +(define-public python-cycler
> +  (package
> +    (name "python-cycler")
> +    (version "0.10.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "cycler" version))
> +              (sha256
> +               (base32
> +                "1n69n23fak1gjxlrbhqisi2b9pv3ckrfj98llx3p53953082syyd"))))
> +    (build-system python-build-system)
> +    (arguments
> +     ;; XXX: The current version requires 'coveralls' which we don't have.
> +     ;; Enable this for the next release which uses 'python-pytest'.
> +     '(#:tests? #f))
> +    (propagated-inputs
> +     `(("python-six" ,python-six)))

Is python-six really required at runtime?  Since you offer a variant for
Python 2, should python-six only be used with one of these variants?

> +    (home-page "http://matplotlib.org/cycler/")
> +    (synopsis "Composable kwarg iterator")

I assume that “kwarg” is a generally known term in Python, but maybe it
is not.  Could this be replaced with “keyword argument”?

> +    (description
> +     "When using @code{matplotlib} and plotting more than one line, it is
> +common to want to be able to cycle over one or more artist styles; but the
> +plotting logic can quickly become involved.
> +
> +To address this and enable easy cycling over arbitrary @code{kwargs}, the
> +@code{Cycler} class was developed.")

I would remove the empty line.

> +    (license license:bsd-3)))
> +
> +(define-public python2-cycler
> +  (package-with-python2 python-cycler))
> +

See question above about python-six.
Other than that it looks good to me.  Thank you!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #13 received at 25723-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 25723-done <at> debbugs.gnu.org
Subject: Re: bug#25723: [PATCH] gnu: Add python-cycler.
Date: Sun, 19 Feb 2017 22:49:47 +0100

[Message part 1 (text/plain, inline)]

Hi Ricardo,

Thanks a lot for the feedback! 

Ricardo Wurmus <rekado <at> elephly.net> writes:

>> +    (propagated-inputs
>> +     `(("python-six" ,python-six)))
>
> Is python-six really required at runtime?  Since you offer a variant for
> Python 2, should python-six only be used with one of these variants?

python-six is imported unconditionally by cycler.py. I believe this is
common practice, and the "six" class offers compatibility "both ways",
not just e.g. 2->3.

>> +    (home-page "http://matplotlib.org/cycler/")
>> +    (synopsis "Composable kwarg iterator")
>
> I assume that “kwarg” is a generally known term in Python, but maybe it
> is not.  Could this be replaced with “keyword argument”?

Yes, that is better, thanks!

>
>> +    (description
>> +     "When using @code{matplotlib} and plotting more than one line, it is
>> +common to want to be able to cycle over one or more artist styles; but the
>> +plotting logic can quickly become involved.
>> +
>> +To address this and enable easy cycling over arbitrary @code{kwargs}, the
>> +@code{Cycler} class was developed.")
>
> I would remove the empty line.
>
>> +    (license license:bsd-3)))
>> +
>> +(define-public python2-cycler
>> +  (package-with-python2 python-cycler))
>> +
>
> See question above about python-six.
> Other than that it looks good to me.  Thank you!

Committed with these changes, thank you!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.