GNU bug report logs - #25702
26.0.50; `message-make-fqdn' break when `(system-name)' doesn't ends in `.local'

Previous Next

Full log

Message #8 received at 25702 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Rasmus <rasmus <at> gmx.us>
Cc: 25702 <at> debbugs.gnu.org
Subject: Re: bug#25702: 26.0.50;
 `message-make-fqdn' break when `(system-name)' doesn't ends in
 `.local'
Date: Mon, 13 May 2019 17:14:21 -0400

Rasmus <rasmus <at> gmx.us> writes:

> The combination of 3485c1693ef (see #24570) and maybe the removal of
> `message-valid-fqdn-regexp' means that `message-make-fqdn' has broken for
> me.
>
> My (system-name) is the model number of the machine I use (e.g. "X200s").
> So now it's selected as the fdqn via `message-make-fqdn':
>
>     ((not (string-match message-bogus-system-names sysname))
>           ;; `system-name' returned the right result.
>           sysname)
>
> Thus, MESSAGE-ID are something <at> X200s, which is a bogus address.

I think this has been fixed in Emacs in 2017.  The code is now:

     ;; A system name without any dots is unlikely to be a good fully
     ;; qualified domain name.
     ((and (string-match "[.]" sysname)
	   (not (string-match message-bogus-system-names sysname)))
      ;; `system-name' returned the right result.
      sysname)

So it won't use sysname if there's no dot.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.