GNU bug report logs - #25605
[DRAFT PATCH 1/2] Simplify use of FOR_EACH_TAIL

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Wed, 1 Feb 2017 23:57:01 UTC

Severity: normal

Tags: patch

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: eggert <at> cs.ucla.edu, 25605 <at> debbugs.gnu.org
Subject: bug#25605: [DRAFT PATCH 1/2] Simplify use of FOR_EACH_TAIL
Date: Thu, 02 Feb 2017 19:29:43 +0200

> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Wed,  1 Feb 2017 15:56:21 -0800
> Cc: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> * src/data.c (circular_list): New function.
> * src/lisp.h (FOR_EACH_TAIL): Use Brent’s algorithm and C99 for-loop
> decl, to eliminate the need for the args TAIL, TORTOISE and N, and
> to speed things up a bit on typical hosts with optimization.
> All uses changed.

Thanks, but I wonder if you could add some tests for the relevant
functions, I really feel uneasy about changing the implementation of
such basic functionality without any regression tests.
This bug report was last modified 8 years and 93 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.